[GitHub] [superset] rusackas commented on a diff in pull request #23402: feat(lang): update messages.po(t) and add missing German translations

["rusackas (via GitHub)" <gi...@apache.org>]

rusackas commented on code in PR #23402:
URL: https://github.com/apache/superset/pull/23402#discussion_r1160745841


##########
scripts/babel_update.sh:
##########
@@ -54,4 +54,17 @@ pybabel update \
   -d superset/translations \
   --ignore-obsolete
 
+# Chop off last blankline from po/pot files, see https://github.com/python-babel/babel/issues/799

Review Comment:
   Was the extra line causing a problem (e.g. linting issues) or is this just cleanup to feel good about things? Only asking because the other solution might be to tweak the linting rule for these files. This seems fine, I'm just curious. ¯\\\_(ツ)_/¯ 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org