You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by Sergey Shelukhin <se...@hortonworks.com> on 2017/12/21 22:19:39 UTC

Review Request 64787: HIVE-18326 LLAP Tez scheduler - only preempt tasks if there's a dependency between them

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64787/
-----------------------------------------------------------

Review request for hive, Gopal V and Siddharth Seth.


Repository: hive-git


Description
-------

see jira


Diffs
-----

  common/src/java/org/apache/hadoop/hive/conf/HiveConf.java be83489cb3 
  llap-tez/src/java/org/apache/hadoop/hive/llap/tezplugins/LlapTaskSchedulerService.java e97a267843 


Diff: https://reviews.apache.org/r/64787/diff/1/


Testing
-------


Thanks,

Sergey Shelukhin


Re: Review Request 64787: HIVE-18326 LLAP Tez scheduler - only preempt tasks if there's a dependency between them

Posted by Eric Wohlstadter <ew...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64787/#review194374
-----------------------------------------------------------




llap-tez/src/java/org/apache/hadoop/hive/llap/tezplugins/LlapTaskSchedulerService.java
Lines 389 (patched)
<https://reviews.apache.org/r/64787/#comment273132>

    When I tried calling getContext().getCurrentDagInfo() inside of the constructor of YarnTaskSchedulerService (the Tez-native TaskScheduler), it returns null. It was only initialized inside both overloads of allocateTask.


- Eric Wohlstadter


On Dec. 21, 2017, 10:19 p.m., Sergey Shelukhin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64787/
> -----------------------------------------------------------
> 
> (Updated Dec. 21, 2017, 10:19 p.m.)
> 
> 
> Review request for hive, Gopal V and Siddharth Seth.
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> see jira
> 
> 
> Diffs
> -----
> 
>   common/src/java/org/apache/hadoop/hive/conf/HiveConf.java be83489cb3 
>   llap-tez/src/java/org/apache/hadoop/hive/llap/tezplugins/LlapTaskSchedulerService.java e97a267843 
> 
> 
> Diff: https://reviews.apache.org/r/64787/diff/1/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Sergey Shelukhin
> 
>


Re: Review Request 64787: HIVE-18326 LLAP Tez scheduler - only preempt tasks if there's a dependency between them

Posted by Sergey Shelukhin <se...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64787/
-----------------------------------------------------------

(Updated Jan. 5, 2018, 9:32 p.m.)


Review request for hive, Gopal V and Siddharth Seth.


Repository: hive-git


Description
-------

see jira


Diffs (updated)
-----

  common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 1dc7501291 
  llap-tez/src/java/org/apache/hadoop/hive/llap/tezplugins/LlapTaskSchedulerService.java e97a267843 


Diff: https://reviews.apache.org/r/64787/diff/3/

Changes: https://reviews.apache.org/r/64787/diff/2-3/


Testing
-------


Thanks,

Sergey Shelukhin


Re: Review Request 64787: HIVE-18326 LLAP Tez scheduler - only preempt tasks if there's a dependency between them

Posted by Sergey Shelukhin <se...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64787/
-----------------------------------------------------------

(Updated Dec. 22, 2017, 10:51 p.m.)


Review request for hive, Gopal V and Siddharth Seth.


Repository: hive-git


Description
-------

see jira


Diffs (updated)
-----

  common/src/java/org/apache/hadoop/hive/conf/HiveConf.java be83489cb3 
  llap-tez/src/java/org/apache/hadoop/hive/llap/tezplugins/LlapTaskSchedulerService.java e97a267843 


Diff: https://reviews.apache.org/r/64787/diff/2/

Changes: https://reviews.apache.org/r/64787/diff/1-2/


Testing
-------


Thanks,

Sergey Shelukhin