You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@accumulo.apache.org by "dlmarion (via GitHub)" <gi...@apache.org> on 2026/09/23 12:42:41 UTC
[PR] Added check in TabletClientHandler.getTabletStats [accumulo]
dlmarion opened a new pull request, #6556:
URL: https://github.com/apache/accumulo/pull/6556
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Added check in TabletClientHandler.getTabletStats [accumulo]
Posted by "dlmarion (via GitHub)" <gi...@apache.org>.
dlmarion merged PR #6556:
URL: https://github.com/apache/accumulo/pull/6556
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Added check in TabletClientHandler.getTabletStats [accumulo]
Posted by "dlmarion (via GitHub)" <gi...@apache.org>.
dlmarion commented on code in PR #6556:
URL: https://github.com/apache/accumulo/pull/6556#discussion_r4105897600
##########
server/tserver/src/main/java/org/apache/accumulo/tserver/TabletClientHandler.java:
##########
@@ -1106,13 +1106,21 @@ public TabletServerStatus getTabletServerStatus(TInfo tinfo, TCredentials creden
}
@Override
- public List<TabletStats> getTabletStats(TInfo tinfo, TCredentials credentials, String tableId) {
+ public List<TabletStats> getTabletStats(TInfo tinfo, TCredentials credentials, String tableId)
Review Comment:
That's a fair point. I can add that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Added check in TabletClientHandler.getTabletStats [accumulo]
Posted by "DomGarguilo (via GitHub)" <gi...@apache.org>.
DomGarguilo commented on code in PR #6556:
URL: https://github.com/apache/accumulo/pull/6556#discussion_r4105880666
##########
server/tserver/src/main/java/org/apache/accumulo/tserver/TabletClientHandler.java:
##########
@@ -1106,13 +1106,21 @@ public TabletServerStatus getTabletServerStatus(TInfo tinfo, TCredentials creden
}
@Override
- public List<TabletStats> getTabletStats(TInfo tinfo, TCredentials credentials, String tableId) {
+ public List<TabletStats> getTabletStats(TInfo tinfo, TCredentials credentials, String tableId)
Review Comment:
Not that I can tell. But it might protect from future changes if other reasons for that to be thrown are added that we are not accounting for now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Added check in TabletClientHandler.getTabletStats [accumulo]
Posted by "DomGarguilo (via GitHub)" <gi...@apache.org>.
DomGarguilo commented on code in PR #6556:
URL: https://github.com/apache/accumulo/pull/6556#discussion_r4105750395
##########
server/tserver/src/main/java/org/apache/accumulo/tserver/TabletClientHandler.java:
##########
@@ -1106,13 +1106,21 @@ public TabletServerStatus getTabletServerStatus(TInfo tinfo, TCredentials creden
}
@Override
- public List<TabletStats> getTabletStats(TInfo tinfo, TCredentials credentials, String tableId) {
+ public List<TabletStats> getTabletStats(TInfo tinfo, TCredentials credentials, String tableId)
Review Comment:
> Fixed in [ee63a14](https://github.com/apache/accumulo/commit/ee63a14af09cdfafc8f4a042fa23b0d69ce20de9)
That fixes things. I'm wondering if we want to be more specific and only return the empty list when `e.getCode() == SecurityErrorCode.TABLE_DOESNT_EXIST` and otherwise just throw the error or if returning the empty list is best on any `ThriftSecurityException`. I don't know which is more correct.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Added check in TabletClientHandler.getTabletStats [accumulo]
Posted by "dlmarion (via GitHub)" <gi...@apache.org>.
dlmarion commented on code in PR #6556:
URL: https://github.com/apache/accumulo/pull/6556#discussion_r4105864020
##########
server/tserver/src/main/java/org/apache/accumulo/tserver/TabletClientHandler.java:
##########
@@ -1106,13 +1106,21 @@ public TabletServerStatus getTabletServerStatus(TInfo tinfo, TCredentials creden
}
@Override
- public List<TabletStats> getTabletStats(TInfo tinfo, TCredentials credentials, String tableId) {
+ public List<TabletStats> getTabletStats(TInfo tinfo, TCredentials credentials, String tableId)
Review Comment:
Is there a different reason for a ThriftSecurityException being thrown in the call path? I'm not seeing one.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Added check in TabletClientHandler.getTabletStats [accumulo]
Posted by "dlmarion (via GitHub)" <gi...@apache.org>.
dlmarion commented on code in PR #6556:
URL: https://github.com/apache/accumulo/pull/6556#discussion_r4105649765
##########
server/tserver/src/main/java/org/apache/accumulo/tserver/TabletClientHandler.java:
##########
@@ -1106,13 +1106,21 @@ public TabletServerStatus getTabletServerStatus(TInfo tinfo, TCredentials creden
}
@Override
- public List<TabletStats> getTabletStats(TInfo tinfo, TCredentials credentials, String tableId) {
+ public List<TabletStats> getTabletStats(TInfo tinfo, TCredentials credentials, String tableId)
Review Comment:
Fixed in ee63a14
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Added check in TabletClientHandler.getTabletStats [accumulo]
Posted by "DomGarguilo (via GitHub)" <gi...@apache.org>.
DomGarguilo commented on code in PR #6556:
URL: https://github.com/apache/accumulo/pull/6556#discussion_r4097744139
##########
server/tserver/src/main/java/org/apache/accumulo/tserver/TabletClientHandler.java:
##########
@@ -1106,13 +1106,21 @@ public TabletServerStatus getTabletServerStatus(TInfo tinfo, TCredentials creden
}
@Override
- public List<TabletStats> getTabletStats(TInfo tinfo, TCredentials credentials, String tableId) {
+ public List<TabletStats> getTabletStats(TInfo tinfo, TCredentials credentials, String tableId)
Review Comment:
So it looks like if the given table doesn't exist, the old code would return an empty list. Now, I think in this case `getNamespaceId()` might throw a table doesnt exist exception. We might want to catch that and return an empty list again in that case.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org