You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@ignite.apache.org by GitBox <gi...@apache.org> on 2020/09/21 13:33:31 UTC
[GitHub] [ignite] zstan opened a new pull request #8261: IGNITE-13463 Rework RootNode rows exchange
zstan opened a new pull request #8261:
URL: https://github.com/apache/ignite/pull/8261
Thank you for submitting the pull request to the Apache Ignite.
In order to streamline the review of the contribution
we ask you to ensure the following steps have been taken:
### The Contribution Checklist
- [ ] There is a single JIRA ticket related to the pull request.
- [ ] The web-link to the pull request is attached to the JIRA ticket.
- [ ] The JIRA ticket has the _Patch Available_ state.
- [ ] The pull request body describes changes that have been made.
The description explains _WHAT_ and _WHY_ was made instead of _HOW_.
- [ ] The pull request title is treated as the final commit message.
The following pattern must be used: `IGNITE-XXXX Change summary` where `XXXX` - number of JIRA issue.
- [ ] A reviewer has been mentioned through the JIRA comments
(see [the Maintainers list](https://cwiki.apache.org/confluence/display/IGNITE/How+to+Contribute#HowtoContribute-ReviewProcessandMaintainers))
- [ ] The pull request has been checked by the Teamcity Bot and
the `green visa` attached to the JIRA ticket (see [TC.Bot: Check PR](https://mtcga.gridgain.com/prs.html))
### Notes
- [How to Contribute](https://cwiki.apache.org/confluence/display/IGNITE/How+to+Contribute)
- [Coding abbreviation rules](https://cwiki.apache.org/confluence/display/IGNITE/Abbreviation+Rules)
- [Coding Guidelines](https://cwiki.apache.org/confluence/display/IGNITE/Coding+Guidelines)
- [Apache Ignite Teamcity Bot](https://cwiki.apache.org/confluence/display/IGNITE/Apache+Ignite+Teamcity+Bot)
If you need any help, please email dev@ignite.apache.org or ask anу advice on http://asf.slack.com _#ignite_ channel.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite] zstan commented on a change in pull request #8261: IGNITE-13463 Rework RootNode rows exchange
Posted by GitBox <gi...@apache.org>.
zstan commented on a change in pull request #8261:
URL: https://github.com/apache/ignite/pull/8261#discussion_r492147953
##########
File path: modules/calcite/src/main/java/org/apache/ignite/internal/processors/query/calcite/exec/rel/RootNode.java
##########
@@ -236,61 +214,55 @@ else if (state == State.END || state == State.CLOSED)
}
/** */
- private Row take() {
+ private void exchangeBuffers() {
assert !F.isEmpty(sources()) && sources().size() == 1;
lock.lock();
try {
while (true) {
- checkCancelled();
- assert state == State.RUNNING;
+ //checkException();
Review comment:
return checkException
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite] gvvinblade commented on a change in pull request #8261: IGNITE-13463 Rework RootNode rows exchange
Posted by GitBox <gi...@apache.org>.
gvvinblade commented on a change in pull request #8261:
URL: https://github.com/apache/ignite/pull/8261#discussion_r492128618
##########
File path: modules/calcite/src/main/java/org/apache/ignite/internal/processors/query/calcite/exec/rel/RootNode.java
##########
@@ -236,61 +214,55 @@ else if (state == State.END || state == State.CLOSED)
}
/** */
- private Row take() {
+ private void exchangeBuffers() {
assert !F.isEmpty(sources()) && sources().size() == 1;
lock.lock();
try {
while (true) {
- checkCancelled();
- assert state == State.RUNNING;
+ //checkException();
Review comment:
we need this call because without it client code will finish successfully in case it was waiting on a condition at the cancellation time
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite] zstan closed pull request #8261: IGNITE-13463 Rework RootNode rows exchange
Posted by GitBox <gi...@apache.org>.
zstan closed pull request #8261:
URL: https://github.com/apache/ignite/pull/8261
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite] zstan closed pull request #8261: IGNITE-13463 Rework RootNode rows exchange
Posted by GitBox <gi...@apache.org>.
zstan closed pull request #8261:
URL: https://github.com/apache/ignite/pull/8261
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite] zstan commented on a change in pull request #8261: IGNITE-13463 Rework RootNode rows exchange
Posted by GitBox <gi...@apache.org>.
zstan commented on a change in pull request #8261:
URL: https://github.com/apache/ignite/pull/8261#discussion_r492147953
##########
File path: modules/calcite/src/main/java/org/apache/ignite/internal/processors/query/calcite/exec/rel/RootNode.java
##########
@@ -236,61 +214,55 @@ else if (state == State.END || state == State.CLOSED)
}
/** */
- private Row take() {
+ private void exchangeBuffers() {
assert !F.isEmpty(sources()) && sources().size() == 1;
lock.lock();
try {
while (true) {
- checkCancelled();
- assert state == State.RUNNING;
+ //checkException();
Review comment:
return checkException
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite] gvvinblade commented on a change in pull request #8261: IGNITE-13463 Rework RootNode rows exchange
Posted by GitBox <gi...@apache.org>.
gvvinblade commented on a change in pull request #8261:
URL: https://github.com/apache/ignite/pull/8261#discussion_r492128618
##########
File path: modules/calcite/src/main/java/org/apache/ignite/internal/processors/query/calcite/exec/rel/RootNode.java
##########
@@ -236,61 +214,55 @@ else if (state == State.END || state == State.CLOSED)
}
/** */
- private Row take() {
+ private void exchangeBuffers() {
assert !F.isEmpty(sources()) && sources().size() == 1;
lock.lock();
try {
while (true) {
- checkCancelled();
- assert state == State.RUNNING;
+ //checkException();
Review comment:
we need this call because without it client code will finish successfully in case it was waiting on a condition at the cancellation time
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite] zstan commented on pull request #8261: IGNITE-13463 Rework RootNode rows exchange
Posted by GitBox <gi...@apache.org>.
zstan commented on pull request #8261:
URL: https://github.com/apache/ignite/pull/8261#issuecomment-696614685
@gvvinblade seems no conflicts here
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite] zstan commented on pull request #8261: IGNITE-13463 Rework RootNode rows exchange
Posted by GitBox <gi...@apache.org>.
zstan commented on pull request #8261:
URL: https://github.com/apache/ignite/pull/8261#issuecomment-696614685
@gvvinblade seems no conflicts here
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org