You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hawq.apache.org by xunzhang <gi...@git.apache.org> on 2016/03/30 17:22:16 UTC
[GitHub] incubator-hawq pull request: HAWQ-608. Libyarn hotrefactor
GitHub user xunzhang opened a pull request:
https://github.com/apache/incubator-hawq/pull/534
HAWQ-608. Libyarn hotrefactor
Solve https://issues.apache.org/jira/browse/HAWQ-608.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/xunzhang/incubator-hawq libyarn-hotrefactor
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-hawq/pull/534.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #534
----
commit 88b2007e4f8a061bf7d3b4c088815b015c81faa4
Author: xunzhang <xu...@gmail.com>
Date: 2016-03-30T13:35:47Z
HAWQ-608. hot refactor libyarn to fix bug under higher version of gcc
commit 015414ea08acdd6625a6c879fef461b3f107c301
Author: xunzhang <xu...@gmail.com>
Date: 2016-03-30T14:33:36Z
HAWQ-608. Bugfix for name conflict building error
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq pull request: HAWQ-608. Libyarn hotrefactor
Posted by xunzhang <gi...@git.apache.org>.
Github user xunzhang commented on the pull request:
https://github.com/apache/incubator-hawq/pull/534#issuecomment-203714483
Of course, this pr only contains a hot refactor for build. I will refactor it later on since there are so many mistakes and wrong ways to use STL in `libyarn`.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq pull request: HAWQ-608. Libyarn hotrefactor
Posted by linwen <gi...@git.apache.org>.
Github user linwen commented on the pull request:
https://github.com/apache/incubator-hawq/pull/534#issuecomment-204238545
Merging this into master
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq pull request: HAWQ-608. Libyarn hotrefactor
Posted by xunzhang <gi...@git.apache.org>.
Github user xunzhang commented on the pull request:
https://github.com/apache/incubator-hawq/pull/534#issuecomment-203486230
@linwen @wangzw plz review. Local CI passed at https://travis-ci.org/xunzhang/incubator-hawq/builds/119545927.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq pull request: HAWQ-608. Libyarn hotrefactor
Posted by xunzhang <gi...@git.apache.org>.
Github user xunzhang commented on the pull request:
https://github.com/apache/incubator-hawq/pull/534#issuecomment-204271018
@linwen , thanks for merging, I will close this pull request.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq pull request: HAWQ-608. Libyarn hotrefactor
Posted by wangzw <gi...@git.apache.org>.
Github user wangzw commented on the pull request:
https://github.com/apache/incubator-hawq/pull/534#issuecomment-203714003
The fix is ok to me. +1
ps. It is a good C++ practice to not include ```using namespace ...``` or ``` using ...``` in header file since header file will be included into other source code without any protection. It may cause conflicts. So I believe libyarn code needs more refactor.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq pull request: HAWQ-608. Libyarn hotrefactor
Posted by xunzhang <gi...@git.apache.org>.
Github user xunzhang closed the pull request at:
https://github.com/apache/incubator-hawq/pull/534
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---