[GitHub] [incubator-kyuubi] pan3793 commented on a change in pull request #1287: [TEST] Refacotor test hierarchical

[GitBox <gi...@apache.org>]

pan3793 commented on a change in pull request #1287:
URL: https://github.com/apache/incubator-kyuubi/pull/1287#discussion_r736208823



##########
File path: kyuubi-server/src/test/scala/org/apache/kyuubi/operation/KyuubiOperationPerGroupSuite.scala
##########
@@ -21,19 +21,26 @@ import org.apache.hadoop.security.UserGroupInformation
 
 import org.apache.kyuubi.WithKyuubiServer
 import org.apache.kyuubi.config.KyuubiConf
-import org.apache.kyuubi.util.KyuubiHadoopUtils
 
-class KyuubiOperationGroupSuite extends WithKyuubiServer with JDBCTests {
+class KyuubiOperationPerGroupSuite extends WithKyuubiServer with BasicQueryTests {
 
   override protected def jdbcUrl: String = getJdbcUrl
 
-  override protected val conf: KyuubiConf = {
-    val c = KyuubiConf().set(KyuubiConf.ENGINE_SHARE_LEVEL, "group")
-      .set("hadoop.user.group.static.mapping.overrides",
-        s"user1=testGG,group_tt;user2=testGG")
-    UserGroupInformation.setConfiguration(KyuubiHadoopUtils.newHadoopConf(c))
-    c.set(s"hadoop.proxyuser.$user.groups", "*")

Review comment:
       After L34,
   ```
   Groups
     .getUserToGroupsMappingServiceWithLoadedConfiguration(newHadoopConf)
     .getGroups("user1") // return ["testGG", "group_tt"]
   ```
   ```
   UserGroupInformation.createRemoteUser("user1").getGroups // return empty array
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org