[GitHub] [activemq-artemis] clebertsuconic commented on a diff in pull request #4473: ARTEMIS-4279 Shutdown critical analyzer thread if error on broker ini…

["clebertsuconic (via GitHub)" <gi...@apache.org>]

clebertsuconic commented on code in PR #4473:
URL: https://github.com/apache/activemq-artemis/pull/4473#discussion_r1194388745


##########
artemis-commons/src/main/java/org/apache/activemq/artemis/utils/critical/CriticalAnalyzerImpl.java:
##########
@@ -48,11 +51,28 @@ public CriticalAnalyzerImpl() {
        *  issues and won't be able to shutdown the server or halt the VM
        */
       this.scheduledComponent = new ActiveMQScheduledComponent(null, null, checkTimeNanoSeconds, TimeUnit.NANOSECONDS, false) {
+
          @Override
          public void run() {
             logger.trace("Checking critical analyzer");
             check();
          }
+
+         @Override
+         protected ActiveMQThreadFactory getThreadFactory() {
+            return new ActiveMQThreadFactory("CriticalAnalyzer", "Critical-Analyzer-", true, getThisClassLoader());

Review Comment:
   @jbertram I was actually talking to @sjhiggs .. I think these thread should always been daemon. It was a mistake not to.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org