You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by neojato <gi...@git.apache.org> on 2014/08/08 18:11:18 UTC
[GitHub] cordova-plugin-network-information pull request: Update NetworkMan...
GitHub user neojato opened a pull request:
https://github.com/apache/cordova-plugin-network-information/pull/16
Update NetworkManager.java
Added support for Android L (API 20) network information "TypeName" response of "CELLULAR"
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/neojato/cordova-plugin-network-information master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-plugin-network-information/pull/16.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #16
----
commit f667d898bb6b0e572f9b2980f778272cf563ca32
Author: neojato <kp...@gmail.com>
Date: 2014-08-08T16:07:28Z
Update NetworkManager.java
Added support for Android L (API 20) network information "TypeName" response of "CELLULAR"
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cordova-plugin-network-information pull request: [CB-7301] Adding ...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-plugin-network-information/pull/16
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-network-information pull request: [CB-7301] Adding ...
Posted by neojato <gi...@git.apache.org>.
Github user neojato commented on the pull request:
https://github.com/apache/cordova-plugin-network-information/pull/16#issuecomment-52111456
@jsoref - I believe I have everything in order now, let me know if I've missed anything. I also just received an email that acknowledges receipt of my ICLA. Thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cordova-plugin-network-information pull request: Update NetworkMan...
Posted by jsoref <gi...@git.apache.org>.
Github user jsoref commented on the pull request:
https://github.com/apache/cordova-plugin-network-information/pull/16#issuecomment-52085276
@neojato please see:
http://wiki.apache.org/cordova/ContributorWorkflow (ICLA)
http://wiki.apache.org/cordova/IssueWorkflow (file a bug in jira; include bug id and meaningful description of change in commit message)
the filename `NetworkManager.java` isn't important,
Adding `NetworkManager::getType` support for `NetworkInfo.getTypeName() returning "CELLULAR"` is.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cordova-plugin-network-information pull request: [CB-7301] Adding ...
Posted by zakrn <gi...@git.apache.org>.
Github user zakrn commented on the pull request:
https://github.com/apache/cordova-plugin-network-information/pull/16#issuecomment-52186103
Sounds complicated lol
On Aug 13, 2014 2:19 PM, "neojato" <no...@github.com> wrote:
> @jsoref <https://github.com/jsoref> - Thanks for the links. I wasn't
> aware of those steps being that I came to this repo from PhoneGap's direct
> reference to it.
>
> I've completed a majority of the steps and awaiting confirmation on the
> rest. I went ahead and created the jira case (
> https://issues.apache.org/jira/browse/CB-7301) with a meaningful
> description for this issue.
>
> Since I've already created the pull request for this issue, how would you
> advise this moving forward? Another commit? Changing the title for the pull
> request to include a more meaningful description? Including the case id in
> this title?
>
> Thanks in advance.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/apache/cordova-plugin-network-information/pull/16#issuecomment-52096890>
> .
>
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cordova-plugin-network-information pull request: Update NetworkMan...
Posted by neojato <gi...@git.apache.org>.
Github user neojato commented on the pull request:
https://github.com/apache/cordova-plugin-network-information/pull/16#issuecomment-52096890
@jsoref - Thanks for the links. I wasn't aware of those steps being that I came to this repo from PhoneGap's direct reference to it.
I've completed a majority of the steps and awaiting confirmation on the rest. I went ahead and created the jira case (https://issues.apache.org/jira/browse/CB-7301) with a meaningful description for this issue.
Since I've already created the pull request for this issue, how would you advise this moving forward? Another commit? Changing the title for the pull request to include a more meaningful description? Including the case id in this title?
Thanks in advance.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cordova-plugin-network-information pull request: Update NetworkMan...
Posted by jsoref <gi...@git.apache.org>.
Github user jsoref commented on the pull request:
https://github.com/apache/cordova-plugin-network-information/pull/16#issuecomment-52099327
Please feel free to change the summary of the PR.
Please commit --amend / rebase -i (and squash/fold commits) including the jira id/etc in the first line.
Then push -f the same branch to your github repo, github will do the rest.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---