You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@zeppelin.apache.org by "Reamer (via GitHub)" <gi...@apache.org> on 2023/09/28 14:06:44 UTC
[GitHub] [zeppelin] Reamer commented on pull request #4652: [ZEPPELIN-5946][FOLLOWUP] Use Spark 3.4.1 in default
Reamer commented on PR #4652:
URL: https://github.com/apache/zeppelin/pull/4652#issuecomment-1739296440
> The profiles `scala-2.11` and `scala-2.12` defined at root `pom.xml` seems only affects the livy module's test, if so, do we really need to maintain such profiles? Why not hardcode in `livy/pom.xml`(seems livy is not much active, the latest version only support Scala 2.11)
The profiles `scala-2.11` and `scala-2.12` set the properties `scala.version` and `scala.binary.version`.
I see accesses to these properties in the Zeppelin Display Module and Zeppelin Distribution Module. Unfortunately, I don't currently know why Scala dependencies are needed in the Zeppelin Distribution Module.
https://github.com/apache/zeppelin/blob/85bb3b4ca2d4a5c79194f8c12a90b732d777ccc5/zeppelin-display/pom.xml#L34-L55
https://github.com/apache/zeppelin/blob/85bb3b4ca2d4a5c79194f8c12a90b732d777ccc5/zeppelin-distribution/pom.xml#L49-L73
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@zeppelin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org