You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/02/11 17:00:03 UTC

[GitHub] [airflow] kaxil commented on a change in pull request #14197: Allow viewers to see all docs links

kaxil commented on a change in pull request #14197:
URL: https://github.com/apache/airflow/pull/14197#discussion_r574668336



##########
File path: airflow/security/permissions.py
##########
@@ -24,6 +24,10 @@
 RESOURCE_DAG_PREFIX = "DAG:"
 RESOURCE_DOCS_MENU = "Docs"
 RESOURCE_DOCS_LINK = "Documentation"
+RESOURCE_DOCS_WEBSITE = "Airflow Website"
+RESOURCE_DOCS_REPO = "GitHub Repo"
+RESOURCE_DOCS_API_SWAGGER = "REST API Reference (Swagger UI)"
+RESOURCE_DOCS_API_REDOC = "REST API Reference (Redoc)"

Review comment:
       Would be good to club them into a single `RESOURCE_DOCS_LINK` resource.
   
   WDYT @jhtimmins 

##########
File path: airflow/security/permissions.py
##########
@@ -24,6 +24,10 @@
 RESOURCE_DAG_PREFIX = "DAG:"
 RESOURCE_DOCS_MENU = "Docs"
 RESOURCE_DOCS_LINK = "Documentation"
+RESOURCE_DOCS_WEBSITE = "Airflow Website"
+RESOURCE_DOCS_REPO = "GitHub Repo"
+RESOURCE_DOCS_API_SWAGGER = "REST API Reference (Swagger UI)"
+RESOURCE_DOCS_API_REDOC = "REST API Reference (Redoc)"

Review comment:
       Would be good to club them into a single `RESOURCE_DOCS_LINK` resource.
   
   WDYT?
   
   cc @jhtimmins 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org