You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/09/30 12:55:48 UTC
[GitHub] [arrow] nealrichardson opened a new pull request, #14282: ARROW-17848: [R] Skip lubridate::format_ISO8601 tests until next release
nealrichardson opened a new pull request, #14282:
URL: https://github.com/apache/arrow/pull/14282
Code comment explains the story. If all CI passes, this has worked.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot commented on pull request #14282: ARROW-17848: [R] Skip lubridate::format_ISO8601 tests until next release
Posted by GitBox <gi...@apache.org>.
ursabot commented on PR #14282:
URL: https://github.com/apache/arrow/pull/14282#issuecomment-1264203066
Benchmark runs are scheduled for baseline = 2748f3d9fa15415bc0c92c12debf0c900103e0cc and contender = d60d8c6dd497a7a648ede550f1c7fb9ec63b3d42. d60d8c6dd497a7a648ede550f1c7fb9ec63b3d42 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished :arrow_down:0.0% :arrow_up:0.0%] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/2b091dd09135401e9878aa8db6898273...cff08f6956f4433db1d699baf1da0778/)
[Failed :arrow_down:0.34% :arrow_up:0.0%] [test-mac-arm](https://conbench.ursa.dev/compare/runs/61b27165240c4c4291ebd6112809653d...d38270f4004b4c24ae24316dcb45b5b8/)
[Failed :arrow_down:0.0% :arrow_up:0.0%] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/1a484b5881f948918d2482feedb2ae5b...b59bcc9c165a4045b5c9954ce8c9225f/)
[Finished :arrow_down:0.07% :arrow_up:0.0%] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/062b93bcbf984b1fa12a69eebe91f8d2...457a055197b54e408b8b9fe9831d9ac4/)
Buildkite builds:
[Finished] [`d60d8c6d` ec2-t3-xlarge-us-east-2](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/1606)
[Failed] [`d60d8c6d` test-mac-arm](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/1625)
[Failed] [`d60d8c6d` ursa-i9-9960x](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/1608)
[Finished] [`d60d8c6d` ursa-thinkcentre-m75q](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/1619)
[Finished] [`2748f3d9` ec2-t3-xlarge-us-east-2](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/1605)
[Failed] [`2748f3d9` test-mac-arm](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/1623)
[Failed] [`2748f3d9` ursa-i9-9960x](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/1606)
[Finished] [`2748f3d9` ursa-thinkcentre-m75q](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/1618)
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #14282: ARROW-17848: [R] Skip lubridate::format_ISO8601 tests until next release
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #14282:
URL: https://github.com/apache/arrow/pull/14282#issuecomment-1263540294
https://issues.apache.org/jira/browse/ARROW-17848
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] nealrichardson commented on pull request #14282: ARROW-17848: [R] Skip lubridate::format_ISO8601 tests until next release
Posted by GitBox <gi...@apache.org>.
nealrichardson commented on PR #14282:
URL: https://github.com/apache/arrow/pull/14282#issuecomment-1264031491
There's still one R devel failure:
```
-- Failure (test-dplyr-funcs-datetime.R:3175:3): date round/floor/ceil works for units of 1 day or less --
`object` (`actual`) not equal to `expected` (`expected`).
`actual$date_floored`: "2021-09-09" NA
`expected$date_floored`: "2021-09-09" "1970-01-01"
Backtrace:
x
1. +-test_df %>% check_date_rounding("1 day") at test-dplyr-funcs-datetime.R:3175:2
2. \-arrow (local) check_date_rounding(., "1 day")
3. \-arrow:::expect_equal(...) at test-dplyr-funcs-datetime.R:3134:2
4. \-testthat::expect_equal(...) at D:\a\arrow\arrow\r\check\arrow.Rcheck\tests\testthat\helper-expectation.R:42:4
```
This does not seem to involve format_ISO8601. I can reproduce this:
I suspect it is related to a different change: https://github.com/wch/r-source/commit/4f70ce0d79eeda7464cf97448e515275cbef754b
Now that I'm sucked into this, I'll spend a little more time trying to understand the issue and report the bug wherever it goes. For now, I'll probably just skip here so we can move on.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] nealrichardson merged pull request #14282: ARROW-17848: [R] Skip lubridate::format_ISO8601 tests until next release
Posted by GitBox <gi...@apache.org>.
nealrichardson merged PR #14282:
URL: https://github.com/apache/arrow/pull/14282
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org