You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by "tejaswini-imply (via GitHub)" <gi...@apache.org> on 2023/03/22 08:17:20 UTC
[GitHub] [druid] tejaswini-imply opened a new pull request, #13962: Cache mvn dependencies for cron job tests
tejaswini-imply opened a new pull request, #13962:
URL: https://github.com/apache/druid/pull/13962
With this PR, mvn dependencies are cached prior to running jdk11 ITs in cron workflow.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] tejaswini-imply commented on a diff in pull request #13962: Cache mvn dependencies for cron workflow ITs
Posted by "tejaswini-imply (via GitHub)" <gi...@apache.org>.
tejaswini-imply commented on code in PR #13962:
URL: https://github.com/apache/druid/pull/13962#discussion_r1151467625
##########
.github/workflows/cron-job-its.yml:
##########
@@ -17,14 +17,44 @@ name: Cron Job ITs
on:
schedule: # Runs by default on master branch
- cron: '0 3 * * *' # Runs every day at 3:00 AM UTC
+ pull_request:
+ paths:
+ - 'owasp-dependency-check-suppressions.xml'
+ branches:
+ - master
+ - /^\d+\.\d+\.\d+(-\S*)?$/ # release branches
jobs:
+ build:
+ if: github.event_name == 'schedule'
+ name: build (jdk8)
+ runs-on: ubuntu-latest
+ steps:
+ - name: Checkout branch
+ uses: actions/checkout@v3
+
+ - name: Setup java
+ run: export JAVA_HOME=$JAVA_HOME_8_X64
+
+ - name: Cache Maven m2 repository
+ id: maven
+ uses: actions/cache@v3
+ with:
+ path: ~/.m2/repository
+ key: maven-${{ runner.os }}-8-${{ github.sha }}
+
+ - name: Maven build
+ id: maven_build
+ run: |
+ ./it.sh ci
Review Comment:
Yes, build happens the same way independently in the old (standard&revised) IT workflow. Also, old IT workflow builds docker container for revised ITs. Its not needed here as of now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] abhishekagarwal87 commented on a diff in pull request #13962: Cache mvn dependencies for cron workflow ITs
Posted by "abhishekagarwal87 (via GitHub)" <gi...@apache.org>.
abhishekagarwal87 commented on code in PR #13962:
URL: https://github.com/apache/druid/pull/13962#discussion_r1151463924
##########
.github/workflows/cron-job-its.yml:
##########
@@ -17,14 +17,44 @@ name: Cron Job ITs
on:
schedule: # Runs by default on master branch
- cron: '0 3 * * *' # Runs every day at 3:00 AM UTC
+ pull_request:
+ paths:
+ - 'owasp-dependency-check-suppressions.xml'
+ branches:
+ - master
+ - /^\d+\.\d+\.\d+(-\S*)?$/ # release branches
jobs:
+ build:
+ if: github.event_name == 'schedule'
+ name: build (jdk8)
+ runs-on: ubuntu-latest
+ steps:
+ - name: Checkout branch
+ uses: actions/checkout@v3
+
+ - name: Setup java
+ run: export JAVA_HOME=$JAVA_HOME_8_X64
+
+ - name: Cache Maven m2 repository
+ id: maven
+ uses: actions/cache@v3
+ with:
+ path: ~/.m2/repository
+ key: maven-${{ runner.os }}-8-${{ github.sha }}
+
+ - name: Maven build
+ id: maven_build
+ run: |
+ ./it.sh ci
Review Comment:
this works for old IT workflow as well?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] imply-elliott commented on a diff in pull request #13962: Cache mvn dependencies for cron workflow ITs
Posted by "imply-elliott (via GitHub)" <gi...@apache.org>.
imply-elliott commented on code in PR #13962:
URL: https://github.com/apache/druid/pull/13962#discussion_r1153471889
##########
.github/workflows/cron-job-its.yml:
##########
@@ -82,8 +115,16 @@ jobs:
- name: Checkout branch
uses: actions/checkout@v3
+ - name: setup java
Review Comment:
That makes sense. However, we can do the same by using the same caching parameters the setup java action uses, which just follows this convention: https://github.com/actions/cache/blob/0638051e9af2c23d10bb70fa9beffcad6cff9ce3/examples.md#java---maven
Again, not a big deal, but will save a bit of time downloading and setting up java.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] abhishekagarwal87 merged pull request #13962: Cache mvn dependencies for cron workflow ITs
Posted by "abhishekagarwal87 (via GitHub)" <gi...@apache.org>.
abhishekagarwal87 merged PR #13962:
URL: https://github.com/apache/druid/pull/13962
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] imply-elliott commented on a diff in pull request #13962: Cache mvn dependencies for cron workflow ITs
Posted by "imply-elliott (via GitHub)" <gi...@apache.org>.
imply-elliott commented on code in PR #13962:
URL: https://github.com/apache/druid/pull/13962#discussion_r1152195732
##########
.github/workflows/cron-job-its.yml:
##########
@@ -82,8 +115,16 @@ jobs:
- name: Checkout branch
uses: actions/checkout@v3
+ - name: setup java
Review Comment:
Just a note, we're using the on-runner java now to save time.
Example here: https://github.com/implydata/druid/blob/c882bd95ceea3df9d5dc3624cef6a25681f1af39/.github/workflows/unit-and-integration-tests-unified.yml#L63
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] imply-elliott commented on a diff in pull request #13962: Cache mvn dependencies for cron workflow ITs
Posted by "imply-elliott (via GitHub)" <gi...@apache.org>.
imply-elliott commented on code in PR #13962:
URL: https://github.com/apache/druid/pull/13962#discussion_r1152195732
##########
.github/workflows/cron-job-its.yml:
##########
@@ -82,8 +115,16 @@ jobs:
- name: Checkout branch
uses: actions/checkout@v3
+ - name: setup java
Review Comment:
Just a note, we're using the on-runner java now to save time.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] tejaswini-imply commented on a diff in pull request #13962: Cache mvn dependencies for cron workflow ITs
Posted by "tejaswini-imply (via GitHub)" <gi...@apache.org>.
tejaswini-imply commented on code in PR #13962:
URL: https://github.com/apache/druid/pull/13962#discussion_r1152208655
##########
.github/workflows/cron-job-its.yml:
##########
@@ -82,8 +115,16 @@ jobs:
- name: Checkout branch
uses: actions/checkout@v3
+ - name: setup java
Review Comment:
I understand that, I have used this setup only for `security_vulnerabilities` job to take the advantage of GHA powered maven cache and incase of CVE suppression PRs `security_vulnerabilities` job alone runs and still cache maven dependencies across workflows.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org