[GitHub] [arrow-rs] tustvold commented on a diff in pull request #3064: Fix row format decode loses timezone (#3063)

[GitBox <gi...@apache.org>]

tustvold commented on code in PR #3064:
URL: https://github.com/apache/arrow-rs/pull/3064#discussion_r1017687437


##########
arrow/src/row/fixed.rs:
##########
@@ -267,7 +267,11 @@ pub fn decode_bool(rows: &mut [&[u8]], options: SortOptions) -> BooleanArray {
 }
 
 /// Decodes a `ArrayData` from rows based on the provided `FixedLengthEncoding` `T`
-fn decode_fixed<T: FixedLengthEncoding + ToByteSlice>(
+///
+/// # Safety
+///
+/// `data_type` must be appropriate native type for `T`
+unsafe fn decode_fixed<T: FixedLengthEncoding + ToByteSlice>(

Review Comment:
   This was unsafe before, I just had neglected to mark it as such



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org