You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@eventmesh.apache.org by "pandaapo (via GitHub)" <gi...@apache.org> on 2023/05/08 15:38:32 UTC
[GitHub] [eventmesh] pandaapo opened a new pull request, #3889: [ISSUE #3887]The method of verifying no exception thrown is not appropriate.
pandaapo opened a new pull request, #3889:
URL: https://github.com/apache/eventmesh/pull/3889
Fixes #3887.
### Motivation
See "" in issue.
### Modifications
See "" in issue.
### Documentation
- Does this pull request introduce a new feature? (yes / no)
- If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
- If a feature is not applicable for documentation, explain why?
- If a feature is not documented yet in this PR, please create a followup issue for adding the documentation
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
Re: [PR] [ISSUE #3887]The method of verifying no exception thrown is not appropriate. (eventmesh)
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #3889:
URL: https://github.com/apache/eventmesh/pull/3889#issuecomment-2070567670
It has been 60 days since the last activity on this pull request. I am reaching out here to gently remind you that the Apache EventMesh community values every pull request, and please feel free to get in touch with the reviewers at any time. They are available to assist you in advancing the progress of your pull request and offering the latest feedback.
If you encounter any challenges during development, seeking support within the community is encouraged. We sincerely appreciate your contributions to Apache EventMesh.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: issues-help@eventmesh.apache.org
Re: [PR] [ISSUE #3887]The method of verifying no exception thrown is not appropriate. (eventmesh)
Posted by "Pil0tXia (via GitHub)" <gi...@apache.org>.
Pil0tXia commented on code in PR #3889:
URL: https://github.com/apache/eventmesh/pull/3889#discussion_r1575616371
##########
eventmesh-common/src/main/java/org/apache/eventmesh/common/loadbalance/WeightRandomLoadBalanceSelector.java:
##########
@@ -74,4 +74,8 @@ public T select() {
public LoadBalanceType getType() {
return LoadBalanceType.WEIGHT_RANDOM;
}
+
+ boolean isSameWeightGroup() {
+ return sameWeightGroup;
+ }
Review Comment:
How about using a `@Getter` lombok annotation?
Well, this method doesn't take up a lot of space and can be left unchanged in this PR if you don't feel it's necessary.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: issues-help@eventmesh.apache.org
[GitHub] [eventmesh] codecov[bot] commented on pull request #3889: [ISSUE #3887]The method of verifying no exception thrown is not appropriate.
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #3889:
URL: https://github.com/apache/eventmesh/pull/3889#issuecomment-1539602452
## [Codecov](https://app.codecov.io/gh/apache/eventmesh/pull/3889?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#3889](https://app.codecov.io/gh/apache/eventmesh/pull/3889?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (e532cc3) into [master](https://app.codecov.io/gh/apache/eventmesh/commit/d976bbf635b7f4bcdc032b1af5da175b6246e4b3?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (d976bbf) will **increase** coverage by `0.02%`.
> The diff coverage is `4.08%`.
> :exclamation: Current head e532cc3 differs from pull request most recent head 9dd2986. Consider uploading reports for the commit 9dd2986 to get more accurate results
```diff
@@ Coverage Diff @@
## master #3889 +/- ##
============================================
+ Coverage 13.91% 13.93% +0.02%
- Complexity 1291 1292 +1
============================================
Files 572 570 -2
Lines 28888 28848 -40
Branches 2816 2811 -5
============================================
+ Hits 4019 4020 +1
+ Misses 24496 24455 -41
Partials 373 373
```
| [Impacted Files](https://app.codecov.io/gh/apache/eventmesh/pull/3889?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...pache/eventmesh/common/EventMeshThreadFactory.java](https://app.codecov.io/gh/apache/eventmesh/pull/3889?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZXZlbnRtZXNoL2NvbW1vbi9FdmVudE1lc2hUaHJlYWRGYWN0b3J5LmphdmE=) | `69.56% <ø> (ø)` | |
| [.../eventmesh/runtime/core/protocol/RetryContext.java](https://app.codecov.io/gh/apache/eventmesh/pull/3889?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLXJ1bnRpbWUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2V2ZW50bWVzaC9ydW50aW1lL2NvcmUvcHJvdG9jb2wvUmV0cnlDb250ZXh0LmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...ore/protocol/grpc/producer/SendMessageContext.java](https://app.codecov.io/gh/apache/eventmesh/pull/3889?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLXJ1bnRpbWUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2V2ZW50bWVzaC9ydW50aW1lL2NvcmUvcHJvdG9jb2wvZ3JwYy9wcm9kdWNlci9TZW5kTWVzc2FnZUNvbnRleHQuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...e/core/protocol/grpc/push/AbstractPushRequest.java](https://app.codecov.io/gh/apache/eventmesh/pull/3889?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLXJ1bnRpbWUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2V2ZW50bWVzaC9ydW50aW1lL2NvcmUvcHJvdG9jb2wvZ3JwYy9wdXNoL0Fic3RyYWN0UHVzaFJlcXVlc3QuamF2YQ==) | `0.00% <ø> (ø)` | |
| [.../runtime/core/protocol/grpc/retry/GrpcRetryer.java](https://app.codecov.io/gh/apache/eventmesh/pull/3889?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLXJ1bnRpbWUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2V2ZW50bWVzaC9ydW50aW1lL2NvcmUvcHJvdG9jb2wvZ3JwYy9yZXRyeS9HcnBjUmV0cnllci5qYXZh) | `0.00% <ø> (ø)` | |
| [...ore/protocol/http/producer/SendMessageContext.java](https://app.codecov.io/gh/apache/eventmesh/pull/3889?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLXJ1bnRpbWUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2V2ZW50bWVzaC9ydW50aW1lL2NvcmUvcHJvdG9jb2wvaHR0cC9wcm9kdWNlci9TZW5kTWVzc2FnZUNvbnRleHQuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...re/protocol/http/push/AbstractHTTPPushRequest.java](https://app.codecov.io/gh/apache/eventmesh/pull/3889?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLXJ1bnRpbWUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2V2ZW50bWVzaC9ydW50aW1lL2NvcmUvcHJvdG9jb2wvaHR0cC9wdXNoL0Fic3RyYWN0SFRUUFB1c2hSZXF1ZXN0LmphdmE=) | `0.00% <ø> (ø)` | |
| [.../core/protocol/http/push/AsyncHTTPPushRequest.java](https://app.codecov.io/gh/apache/eventmesh/pull/3889?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLXJ1bnRpbWUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2V2ZW50bWVzaC9ydW50aW1lL2NvcmUvcHJvdG9jb2wvaHR0cC9wdXNoL0FzeW5jSFRUUFB1c2hSZXF1ZXN0LmphdmE=) | `0.00% <ø> (ø)` | |
| [.../runtime/core/protocol/http/retry/HttpRetryer.java](https://app.codecov.io/gh/apache/eventmesh/pull/3889?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLXJ1bnRpbWUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2V2ZW50bWVzaC9ydW50aW1lL2NvcmUvcHJvdG9jb2wvaHR0cC9yZXRyeS9IdHRwUmV0cnllci5qYXZh) | `0.00% <ø> (ø)` | |
| [...time/core/protocol/tcp/client/session/Session.java](https://app.codecov.io/gh/apache/eventmesh/pull/3889?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLXJ1bnRpbWUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2V2ZW50bWVzaC9ydW50aW1lL2NvcmUvcHJvdG9jb2wvdGNwL2NsaWVudC9zZXNzaW9uL1Nlc3Npb24uamF2YQ==) | `2.40% <0.00%> (+0.28%)` | :arrow_up: |
| ... and [10 more](https://app.codecov.io/gh/apache/eventmesh/pull/3889?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: issues-help@eventmesh.apache.org
Re: [PR] [ISSUE #3887]The method of verifying no exception thrown is not appropriate. (eventmesh)
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #3889:
URL: https://github.com/apache/eventmesh/pull/3889#issuecomment-2070568137
## [Codecov](https://app.codecov.io/gh/apache/eventmesh/pull/3889?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
All modified and coverable lines are covered by tests :white_check_mark:
> Project coverage is 13.93%. Comparing base [(`0ce8d57`)](https://app.codecov.io/gh/apache/eventmesh/commit/0ce8d57e6a87890354fdc0643f06aae4acb6cc41?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) to head [(`e532cc3`)](https://app.codecov.io/gh/apache/eventmesh/pull/3889?dropdown=coverage&src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
> Report is 431 commits behind head on master.
> :exclamation: Current head e532cc3 differs from pull request most recent head 63953ba. Consider uploading reports for the commit 63953ba to get more accurate results
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #3889 +/- ##
============================================
- Coverage 14.24% 13.93% -0.31%
+ Complexity 1320 1292 -28
============================================
Files 579 570 -9
Lines 28967 28848 -119
Branches 2802 2811 +9
============================================
- Hits 4125 4020 -105
- Misses 24450 24455 +5
+ Partials 392 373 -19
```
</details>
[:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/eventmesh/pull/3889?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: issues-help@eventmesh.apache.org