You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2022/08/03 21:22:54 UTC

[GitHub] [tvm] yelite commented on a diff in pull request #12299: [TVMScript] TracedObject class that simplifies tracing ObjectPaths

yelite commented on code in PR #12299:
URL: https://github.com/apache/tvm/pull/12299#discussion_r937148401


##########
src/script/printer/traced_object.h:
##########
@@ -0,0 +1,410 @@
+/*

Review Comment:
   Can you move this to the public headers (include/...)? Because it's used by the actual printer functions, which could be outside of libtvm.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org