You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@echarts.apache.org by GitBox <gi...@apache.org> on 2020/06/28 15:23:30 UTC
[GitHub] [incubator-echarts] susiwen8 opened a new pull request #12861: Fix #12857: condition for adding commas
susiwen8 opened a new pull request #12861:
URL: https://github.com/apache/incubator-echarts/pull/12861
<!-- Please fill in the following information to help us review your PR more efficiently. -->
## Brief Information
This pull request is in the type of:
- [ ] bug fixing
- [ ] new feature
- [ ] others
### What does this PR do?
Add a parameter for controlling commas addition
### Fixed issues
Close #12857
## Details
### Before: What was the problem?
<img width="327" alt="Screen Shot 2020-06-28 at 23 22 43" src="https://user-images.githubusercontent.com/20318608/85951547-4d387500-b996-11ea-97e1-94e38871d69f.png">
### After: How is it fixed in this PR?
<img width="381" alt="Screen Shot 2020-06-28 at 23 22 24" src="https://user-images.githubusercontent.com/20318608/85951553-545f8300-b996-11ea-9504-20b699cbf393.png">
## Usage
### Are there any API changes?
- [ ] The API has been changed.
<!-- LIST THE API CHANGES HERE -->
### Related test cases or examples to use the new APIs
NA.
## Others
### Merging options
- [x] Please squash the commits into a single one when merge.
### Other information
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [incubator-echarts] susiwen8 closed pull request #12861: Fix #12857: condition for adding commas
Posted by GitBox <gi...@apache.org>.
susiwen8 closed pull request #12861:
URL: https://github.com/apache/incubator-echarts/pull/12861
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [incubator-echarts] echarts-bot[bot] commented on pull request #12861: Fix #12857: condition for adding commas
Posted by GitBox <gi...@apache.org>.
echarts-bot[bot] commented on pull request #12861:
URL: https://github.com/apache/incubator-echarts/pull/12861#issuecomment-650779703
Thanks for your contribution!
The community will review it ASAP. In the meanwhile, please checkout [the coding standard](https://echarts.apache.org/en/coding-standard.html) and Wiki about [How to make a pull request](https://github.com/apache/incubator-echarts/wiki/How-to-make-a-pull-request).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [incubator-echarts] plainheart edited a comment on pull request #12861: Fix #12857: condition for adding commas
Posted by GitBox <gi...@apache.org>.
plainheart edited a comment on pull request #12861:
URL: https://github.com/apache/incubator-echarts/pull/12861#issuecomment-650856840
Seems to be related to #10810(PR) and #10786(Issue).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [incubator-echarts] plainheart commented on pull request #12861: Fix #12857: condition for adding commas
Posted by GitBox <gi...@apache.org>.
plainheart commented on pull request #12861:
URL: https://github.com/apache/incubator-echarts/pull/12861#issuecomment-650856840
Seems to be related to #10810(PR) and #12857(Issue).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [incubator-echarts] susiwen8 commented on pull request #12861: Fix #12857: condition for adding commas
Posted by GitBox <gi...@apache.org>.
susiwen8 commented on pull request #12861:
URL: https://github.com/apache/incubator-echarts/pull/12861#issuecomment-650857384
> Seems to be related to #10810(PR) and #10786(Issue).
Yeah, same issue
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org