You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@activemq.apache.org by franz1981 <gi...@git.apache.org> on 2018/01/18 19:55:23 UTC

[GitHub] activemq-artemis pull request #1790: ARTEMIS-1606 - Change AddressInfo Routi...

GitHub user franz1981 opened a pull request:

    https://github.com/apache/activemq-artemis/pull/1790

    ARTEMIS-1606 - Change AddressInfo RoutingType Set to use EnumSet

    This is fixing the broken testUnsupportedRoutingType test

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/franz1981/activemq-artemis fixed_routing_type_test

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/activemq-artemis/pull/1790.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1790
    
----
commit 48604155d21719ce204f0d31018b781140c03beb
Author: Francesco Nigro <ni...@...>
Date:   2018-01-18T19:54:53Z

    ARTEMIS-1606 - Change AddressInfo RoutingType Set to use EnumSet
    
    This is fixing the broken testUnsupportedRoutingType test

----


---

[GitHub] activemq-artemis pull request #1790: ARTEMIS-1606 - Change AddressInfo Routi...

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/activemq-artemis/pull/1790


---

[GitHub] activemq-artemis issue #1790: ARTEMIS-1606 - Change AddressInfo RoutingType ...

Posted by franz1981 <gi...@git.apache.org>.

Github user franz1981 commented on the issue:

    https://github.com/apache/activemq-artemis/pull/1790
  
    @michaelandrepearce The past PR has broken just this test: this is fixing it :+1: 


---

[GitHub] activemq-artemis issue #1790: ARTEMIS-1606 - Change AddressInfo RoutingType ...

Posted by michaelandrepearce <gi...@git.apache.org>.

Github user michaelandrepearce commented on the issue:

    https://github.com/apache/activemq-artemis/pull/1790
  
    Looks like master is broken since merge of https://github.com/apache/activemq-artemis/pull/1742 thus your PR build failed, this fix though looks fine, i have run it manually offline :) , ill merge it.


---