[GitHub] [hive] pvary commented on a change in pull request #3116: HIVE-26053: Non blocking DROP VIEW

[GitBox <gi...@apache.org>]

pvary commented on a change in pull request #3116:
URL: https://github.com/apache/hive/pull/3116#discussion_r831870673



##########
File path: ql/src/java/org/apache/hadoop/hive/ql/ddl/view/drop/DropViewAnalyzer.java
##########
@@ -50,7 +50,7 @@ public void analyzeInternal(ASTNode root) throws SemanticException {
     Table view = getTable(viewName, throwException);
     if (view != null) {
       inputs.add(new ReadEntity(view));
-      outputs.add(new WriteEntity(view, WriteEntity.WriteType.DDL_EXCLUSIVE));
+      outputs.add(new WriteEntity(view, WriteEntity.WriteType.DDL_NO_LOCK)); // see AcidUtils.needsLock(output)

Review comment:
       What about materialized view-s where the view could be used for optimising the query and it could be used as a source instead of the original source table?
   
   Or that is a different story?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org