[GitHub] DavidStrausz opened a new pull request #417: CB-13580: (android) fix build for multiple apks (different product flavors)

[GitBox <gi...@apache.org>]

DavidStrausz opened a new pull request #417: CB-13580: (android) fix build for multiple apks (different product flavors)
URL: https://github.com/apache/cordova-android/pull/417
 
 
   <!--
   Please make sure the checklist boxes are all checked before submitting the PR. The checklist
   is intended as a quick reference, for complete details please see our Contributor Guidelines:
   
   http://cordova.apache.org/contribute/contribute_guidelines.html
   
   Thanks!
   -->
   
   ### Platforms affected
   cordova-android
   
   ### What does this PR do?
   This PR fixes the build if cdvBuildMultipleApks is set to true by defining `flavorDimensions "default"` in `build.gradle` and by adapting the `findOutputApksHelper` method in `GenericBuilder.js` to recursively scan the `build/outputs/apk` directory for matching candidates.
   
   ### What testing has been done on this change?
   I ran the unit tests and the connectedAndroidTest tests and did manual tests of builds with crosswalk (multiple APKs) and builds without crosswalk (single APK).
   
   ### Checklist
   - [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database
   - [x] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
   - [ ] Added automated test coverage as appropriate for this change.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org