[GitHub] [kafka] kirktrue opened a new pull request #11618: KAFKA-13558: NioEchoServer fails to close resources

[GitBox <gi...@apache.org>]

kirktrue opened a new pull request #11618:
URL: https://github.com/apache/kafka/pull/11618


   Due to resource leaks in the `NioEchoServer`, at times it won't start properly to accept clients and will throw an exception in the `ServerSocketChannel.accept()` call. Previous to this change, the error was not being logged. The logged error was that there were too many open files.
   
   Using the `UnixOperatingSystemMXBean`, I was able to detect that use of the `NioEchoServer` creates several file descriptors but does not close them. This then caused the client to never be able to connect to the server, so the waitForCondition failed intermittently.
   
   This change closes the internal `Selector` and the `AcceptorThread`'s selector so that the file descriptors are reclaimed.
   
   ### Committer Checklist (excluded from commit message)
   - [ ] Verify design and implementation 
   - [ ] Verify test coverage and CI build status
   - [ ] Verify documentation (including upgrade notes)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] ijuma merged pull request #11618: KAFKA-13558: NioEchoServer fails to close resources

[GitBox <gi...@apache.org>]

ijuma merged pull request #11618:
URL: https://github.com/apache/kafka/pull/11618


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org