You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cocoon.apache.org by "Andrew Cave (JIRA)" <ji...@apache.org> on 2007/07/31 22:50:52 UTC
[jira] Created: (COCOON-2104) [PATCH] Add base URI fixup support to
XIncludeTransformer
[PATCH] Add base URI fixup support to XIncludeTransformer
---------------------------------------------------------
Key: COCOON-2104
URL: https://issues.apache.org/jira/browse/COCOON-2104
Project: Cocoon
Issue Type: Bug
Components: * Cocoon Core
Affects Versions: 2.1.11-dev (Current SVN), 2.2-dev (Current SVN)
Reporter: Andrew Cave
Priority: Minor
Fix For: 2.1.11-dev (Current SVN), 2.2-dev (Current SVN)
Attachments: baseFixup-2.1-r561455.diff, baseFixup-2.2-r561499.diff
As discussed at [1], the XIncludeTransformer fails to perform the base URI fixup specified in the W3C's XInclude spec [2]. The spec says that the base URIs of elements do not change when passed through a conformant XInclude processor. Meaning, xml:base attributes must be added to the result set. The reason being that relative URIs in the included document should not break; this provides a mechanism to resolve them properly.
This patch results in the XIncludeTransformer adding xml:base attributes to top-level included elements. It does this only when the the base URI of the included element differs from the base URI of the parent element (meaning: for almost every case except where the included document is the current document).
The XIncludeTransformer's JUnit test is also updated by this patch to reflect the fact that the resulting XML file (xinclude-result-1.xml) has an xml:base attribute added.
[1] http://www.mail-archive.com/dev@cocoon.apache.org/msg52803.html
[2] http://www.w3.org/TR/xinclude/#base - The Base URI Fixup section of the W3C's XInclude specification
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (COCOON-2104) [PATCH] Add base URI fixup support to
XIncludeTransformer
Posted by "Jasha Joachimsthal (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/COCOON-2104?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jasha Joachimsthal closed COCOON-2104.
--------------------------------------
Fix version (Component): Parent values: Components: Pipeline(10228).
Affects version (Component): Parent values: Components: Pipeline(10157).
Fix Version/s: 2.1.12-dev (Current SVN)
2.2-dev (Current SVN)
Resolution: Fixed
Thanks Andrew for the patches
> [PATCH] Add base URI fixup support to XIncludeTransformer
> ---------------------------------------------------------
>
> Key: COCOON-2104
> URL: https://issues.apache.org/jira/browse/COCOON-2104
> Project: Cocoon
> Issue Type: Bug
> Components: * Cocoon Core
> Affects Versions: 2.1.11, 2.2
> Reporter: Andrew Cave
> Assignee: Jasha Joachimsthal
> Priority: Minor
> Fix For: 2.1.12-dev (Current SVN), 2.2-dev (Current SVN)
>
> Attachments: baseFixup-2.1-r561455.diff, baseFixup-2.2-r561499.diff
>
>
> As discussed at [1], the XIncludeTransformer fails to perform the base URI fixup specified in the W3C's XInclude spec [2]. The spec says that the base URIs of elements do not change when passed through a conformant XInclude processor. Meaning, xml:base attributes must be added to the result set. The reason being that relative URIs in the included document should not break; this provides a mechanism to resolve them properly.
> This patch results in the XIncludeTransformer adding xml:base attributes to top-level included elements. It does this only when the the base URI of the included element differs from the base URI of the parent element (meaning: for almost every case except where the included document is the current document).
> The XIncludeTransformer's JUnit test is also updated by this patch to reflect the fact that the resulting XML file (xinclude-result-1.xml) has an xml:base attribute added.
> [1] http://www.mail-archive.com/dev@cocoon.apache.org/msg52803.html
> [2] http://www.w3.org/TR/xinclude/#base - The Base URI Fixup section of the W3C's XInclude specification
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Assigned: (COCOON-2104) [PATCH] Add base URI fixup support
to XIncludeTransformer
Posted by "Jörg Heinicke (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/COCOON-2104?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jörg Heinicke reassigned COCOON-2104:
-------------------------------------
Assignee: Jörg Heinicke
> [PATCH] Add base URI fixup support to XIncludeTransformer
> ---------------------------------------------------------
>
> Key: COCOON-2104
> URL: https://issues.apache.org/jira/browse/COCOON-2104
> Project: Cocoon
> Issue Type: Bug
> Components: * Cocoon Core
> Affects Versions: 2.1.11, 2.2-dev (Current SVN)
> Reporter: Andrew Cave
> Assignee: Jörg Heinicke
> Priority: Minor
> Attachments: baseFixup-2.1-r561455.diff, baseFixup-2.2-r561499.diff
>
>
> As discussed at [1], the XIncludeTransformer fails to perform the base URI fixup specified in the W3C's XInclude spec [2]. The spec says that the base URIs of elements do not change when passed through a conformant XInclude processor. Meaning, xml:base attributes must be added to the result set. The reason being that relative URIs in the included document should not break; this provides a mechanism to resolve them properly.
> This patch results in the XIncludeTransformer adding xml:base attributes to top-level included elements. It does this only when the the base URI of the included element differs from the base URI of the parent element (meaning: for almost every case except where the included document is the current document).
> The XIncludeTransformer's JUnit test is also updated by this patch to reflect the fact that the resulting XML file (xinclude-result-1.xml) has an xml:base attribute added.
> [1] http://www.mail-archive.com/dev@cocoon.apache.org/msg52803.html
> [2] http://www.w3.org/TR/xinclude/#base - The Base URI Fixup section of the W3C's XInclude specification
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (COCOON-2104) [PATCH] Add base URI fixup support to
XIncludeTransformer
Posted by "Andrew Cave (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/COCOON-2104?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Andrew Cave updated COCOON-2104:
--------------------------------
Attachment: baseFixup-2.2-r561499.diff
Patch for trunk.
> [PATCH] Add base URI fixup support to XIncludeTransformer
> ---------------------------------------------------------
>
> Key: COCOON-2104
> URL: https://issues.apache.org/jira/browse/COCOON-2104
> Project: Cocoon
> Issue Type: Bug
> Components: * Cocoon Core
> Affects Versions: 2.1.11-dev (Current SVN), 2.2-dev (Current SVN)
> Reporter: Andrew Cave
> Priority: Minor
> Fix For: 2.1.11-dev (Current SVN), 2.2-dev (Current SVN)
>
> Attachments: baseFixup-2.1-r561455.diff, baseFixup-2.2-r561499.diff
>
>
> As discussed at [1], the XIncludeTransformer fails to perform the base URI fixup specified in the W3C's XInclude spec [2]. The spec says that the base URIs of elements do not change when passed through a conformant XInclude processor. Meaning, xml:base attributes must be added to the result set. The reason being that relative URIs in the included document should not break; this provides a mechanism to resolve them properly.
> This patch results in the XIncludeTransformer adding xml:base attributes to top-level included elements. It does this only when the the base URI of the included element differs from the base URI of the parent element (meaning: for almost every case except where the included document is the current document).
> The XIncludeTransformer's JUnit test is also updated by this patch to reflect the fact that the resulting XML file (xinclude-result-1.xml) has an xml:base attribute added.
> [1] http://www.mail-archive.com/dev@cocoon.apache.org/msg52803.html
> [2] http://www.w3.org/TR/xinclude/#base - The Base URI Fixup section of the W3C's XInclude specification
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (COCOON-2104) [PATCH] Add base URI fixup support to
XIncludeTransformer
Posted by "Andrew Cave (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/COCOON-2104?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Andrew Cave updated COCOON-2104:
--------------------------------
Attachment: baseFixup-2.1-r561455.diff
Patch for the 2.1.X branch.
> [PATCH] Add base URI fixup support to XIncludeTransformer
> ---------------------------------------------------------
>
> Key: COCOON-2104
> URL: https://issues.apache.org/jira/browse/COCOON-2104
> Project: Cocoon
> Issue Type: Bug
> Components: * Cocoon Core
> Affects Versions: 2.1.11-dev (Current SVN), 2.2-dev (Current SVN)
> Reporter: Andrew Cave
> Priority: Minor
> Fix For: 2.1.11-dev (Current SVN), 2.2-dev (Current SVN)
>
> Attachments: baseFixup-2.1-r561455.diff, baseFixup-2.2-r561499.diff
>
>
> As discussed at [1], the XIncludeTransformer fails to perform the base URI fixup specified in the W3C's XInclude spec [2]. The spec says that the base URIs of elements do not change when passed through a conformant XInclude processor. Meaning, xml:base attributes must be added to the result set. The reason being that relative URIs in the included document should not break; this provides a mechanism to resolve them properly.
> This patch results in the XIncludeTransformer adding xml:base attributes to top-level included elements. It does this only when the the base URI of the included element differs from the base URI of the parent element (meaning: for almost every case except where the included document is the current document).
> The XIncludeTransformer's JUnit test is also updated by this patch to reflect the fact that the resulting XML file (xinclude-result-1.xml) has an xml:base attribute added.
> [1] http://www.mail-archive.com/dev@cocoon.apache.org/msg52803.html
> [2] http://www.w3.org/TR/xinclude/#base - The Base URI Fixup section of the W3C's XInclude specification
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (COCOON-2104) [PATCH] Add base URI fixup support
to XIncludeTransformer
Posted by "Jasha Joachimsthal (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/COCOON-2104?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jasha Joachimsthal reassigned COCOON-2104:
------------------------------------------
Assignee: Jasha Joachimsthal (was: Jörg Heinicke)
> [PATCH] Add base URI fixup support to XIncludeTransformer
> ---------------------------------------------------------
>
> Key: COCOON-2104
> URL: https://issues.apache.org/jira/browse/COCOON-2104
> Project: Cocoon
> Issue Type: Bug
> Components: * Cocoon Core
> Affects Versions: 2.1.11, 2.2
> Reporter: Andrew Cave
> Assignee: Jasha Joachimsthal
> Priority: Minor
> Attachments: baseFixup-2.1-r561455.diff, baseFixup-2.2-r561499.diff
>
>
> As discussed at [1], the XIncludeTransformer fails to perform the base URI fixup specified in the W3C's XInclude spec [2]. The spec says that the base URIs of elements do not change when passed through a conformant XInclude processor. Meaning, xml:base attributes must be added to the result set. The reason being that relative URIs in the included document should not break; this provides a mechanism to resolve them properly.
> This patch results in the XIncludeTransformer adding xml:base attributes to top-level included elements. It does this only when the the base URI of the included element differs from the base URI of the parent element (meaning: for almost every case except where the included document is the current document).
> The XIncludeTransformer's JUnit test is also updated by this patch to reflect the fact that the resulting XML file (xinclude-result-1.xml) has an xml:base attribute added.
> [1] http://www.mail-archive.com/dev@cocoon.apache.org/msg52803.html
> [2] http://www.w3.org/TR/xinclude/#base - The Base URI Fixup section of the W3C's XInclude specification
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (COCOON-2104) [PATCH] Add base URI fixup support to
XIncludeTransformer
Posted by "Grzegorz Kossakowski (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/COCOON-2104?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Grzegorz Kossakowski updated COCOON-2104:
-----------------------------------------
Fix Version/s: (was: 2.2-dev (Current SVN))
(was: 2.1.11)
Thanks Andrew for providing a patch.
It will be applied after 2.2 final release.
> [PATCH] Add base URI fixup support to XIncludeTransformer
> ---------------------------------------------------------
>
> Key: COCOON-2104
> URL: https://issues.apache.org/jira/browse/COCOON-2104
> Project: Cocoon
> Issue Type: Bug
> Components: * Cocoon Core
> Affects Versions: 2.1.11, 2.2-dev (Current SVN)
> Reporter: Andrew Cave
> Priority: Minor
> Attachments: baseFixup-2.1-r561455.diff, baseFixup-2.2-r561499.diff
>
>
> As discussed at [1], the XIncludeTransformer fails to perform the base URI fixup specified in the W3C's XInclude spec [2]. The spec says that the base URIs of elements do not change when passed through a conformant XInclude processor. Meaning, xml:base attributes must be added to the result set. The reason being that relative URIs in the included document should not break; this provides a mechanism to resolve them properly.
> This patch results in the XIncludeTransformer adding xml:base attributes to top-level included elements. It does this only when the the base URI of the included element differs from the base URI of the parent element (meaning: for almost every case except where the included document is the current document).
> The XIncludeTransformer's JUnit test is also updated by this patch to reflect the fact that the resulting XML file (xinclude-result-1.xml) has an xml:base attribute added.
> [1] http://www.mail-archive.com/dev@cocoon.apache.org/msg52803.html
> [2] http://www.w3.org/TR/xinclude/#base - The Base URI Fixup section of the W3C's XInclude specification
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.