[Bug 55557] New: Some cppcheck reports

[bu...@apache.org]

https://issues.apache.org/bugzilla/show_bug.cgi?id=55557

            Bug ID: 55557
           Summary: Some cppcheck reports
           Product: Apache httpd-2
           Version: 2.5-HEAD
          Hardware: PC
                OS: Linux
            Status: NEW
          Severity: normal
          Priority: P2
         Component: All
          Assignee: bugs@httpd.apache.org
          Reporter: serval2412@yahoo.fr

Hello,

With httpd svn sources updated today + cppcheck (static C++ analyzer) git
updated today, I retrieved these reports:
[support/firehose.c:464]: (style) Array index 'i' is used before limits check
    464     for (i = 0; str[i] && i < APR_UUID_FORMATTED_LENGTH; i++) {
    465         header->uuid[i] = str[i];
    466     }

I tried to filter because cppcheck is normally used for c++, so there were
quite a lot of false positives.

[server/mpm/winnt/mpm_winnt.c:607]: (error) Memory leak: args
[server/mpm/winnt/mpm_winnt.c:617]: (error) Memory leak: args

[modules/arch/win32/mod_win32.c:501] -> [modules/arch/win32/mod_win32.c:497]:
(style) Found duplicate branches for 'if' and 'else'.
[modules/generators/mod_cgi.c:170] -> [modules/generators/mod_cgi.c:170]:
(style) Found duplicate branches for 'if' and 'else'.
[modules/generators/mod_cgid.c:1050] -> [modules/generators/mod_cgid.c:1050]:
(style) Found duplicate branches for 'if' and 'else'.
[modules/ssl/ssl_engine_dh.c:133] -> [modules/ssl/ssl_engine_dh.c:131]: (style)
Found duplicate branches for 'if' and 'else'.

[modules/filters/mod_proxy_html.c:381] ->
[modules/filters/mod_proxy_html.c:374]: (style) Duplicate conditions in 'if'
and related 'else if'

[modules/proxy/proxy_util.c:2800]: (warning) When using 'char' variables in bit
operations, sign extension can generate unexpected results.
[modules/ssl/ssl_util.c:481]: (error) Possible null pointer dereference: psaptr
[server/apreq_module_cgi.c:232]: (warning) Ineffective statement similar to
'*A++;'. Did you intend to write '(*A)++;'?
[server/mpm/netware/mpm_netware.c:1189]: (warning) Redundant assignment of
'screenID' to itself.



Hope it helps a little.

Julien

-- 
You are receiving this mail because:
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: bugs-unsubscribe@httpd.apache.org
For additional commands, e-mail: bugs-help@httpd.apache.org