You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@wicket.apache.org by Igor Vaynberg <ig...@gmail.com> on 2012/09/20 18:59:56 UTC
[mostly devs] flyouts are dead
we have decided to move away from flyouts because of various ux
problems. i have deprecated FlyoutAction and introduced ModalAction
which works as a drop in replacement.
things to lookout for when doing the migration:
when you switch over to modal action you may want to pass in an extra
constructor arg that controls the title of the modal. by default it
will set the title to the name of the action, but sometimes an action
called "Edit" does not give enough context so use the ("Edit", "Edit
Semester Requirement") constructor.
switching over requires some markup tweaks as well. for example, the
title ("Edit Semester Requirement") above is currently embedded in the
flyout markup - so that needs to be removed. also, Leslie has to
change some css to make alignment work. if you switch over you have to
let her know.
actionbar now has closeModal() so when you are done migrating your
code change calls to closeFlyout() to use closeModal() instead.
i will be slowly moving bits and pieces away from flyouts during my
slack time at a rate that wont burden Leslie so i may not get to a
lot. i will also only be migrating the actionbar stuff first. we
should probably set up tech debt at the end of this itreration to
handle the rest of the places.
-igor
Re: [mostly devs] flyouts are dead
Posted by Igor Vaynberg <ig...@gmail.com>.
sigh. indeed. stupid gmail autocomplete :/
-igor
On Thu, Sep 20, 2012 at 10:06 AM, Jeremy Thomerson
<je...@wickettraining.com> wrote:
> On Thu, Sep 20, 2012 at 11:59 AM, Igor Vaynberg <ig...@gmail.com>wrote:
>
>> we have decided to move away from flyouts because of various ux
>> problems. i have deprecated FlyoutAction and introduced ModalAction
>> which works as a drop in replacement.
>>
>> things to lookout for when doing the migration:
>>
>> when you switch over to modal action you may want to pass in an extra
>> constructor arg that controls the title of the modal. by default it
>> will set the title to the name of the action, but sometimes an action
>> called "Edit" does not give enough context so use the ("Edit", "Edit
>> Semester Requirement") constructor.
>>
>> switching over requires some markup tweaks as well. for example, the
>> title ("Edit Semester Requirement") above is currently embedded in the
>> flyout markup - so that needs to be removed. also, Leslie has to
>> change some css to make alignment work. if you switch over you have to
>> let her know.
>>
>> actionbar now has closeModal() so when you are done migrating your
>> code change calls to closeFlyout() to use closeModal() instead.
>>
>>
>>
>> i will be slowly moving bits and pieces away from flyouts during my
>> slack time at a rate that wont burden Leslie so i may not get to a
>> lot. i will also only be migrating the actionbar stuff first. we
>> should probably set up tech debt at the end of this itreration to
>> handle the rest of the places.
>>
>> -igor
>>
>
> Wrong email address?
>
> --
> Jeremy Thomerson
> http://wickettraining.com
> *Need a CMS for Wicket? Use Brix! http://brixcms.org*
Re: [mostly devs] flyouts are dead
Posted by Jeremy Thomerson <je...@wickettraining.com>.
On Thu, Sep 20, 2012 at 11:59 AM, Igor Vaynberg <ig...@gmail.com>wrote:
> we have decided to move away from flyouts because of various ux
> problems. i have deprecated FlyoutAction and introduced ModalAction
> which works as a drop in replacement.
>
> things to lookout for when doing the migration:
>
> when you switch over to modal action you may want to pass in an extra
> constructor arg that controls the title of the modal. by default it
> will set the title to the name of the action, but sometimes an action
> called "Edit" does not give enough context so use the ("Edit", "Edit
> Semester Requirement") constructor.
>
> switching over requires some markup tweaks as well. for example, the
> title ("Edit Semester Requirement") above is currently embedded in the
> flyout markup - so that needs to be removed. also, Leslie has to
> change some css to make alignment work. if you switch over you have to
> let her know.
>
> actionbar now has closeModal() so when you are done migrating your
> code change calls to closeFlyout() to use closeModal() instead.
>
>
>
> i will be slowly moving bits and pieces away from flyouts during my
> slack time at a rate that wont burden Leslie so i may not get to a
> lot. i will also only be migrating the actionbar stuff first. we
> should probably set up tech debt at the end of this itreration to
> handle the rest of the places.
>
> -igor
>
Wrong email address?
--
Jeremy Thomerson
http://wickettraining.com
*Need a CMS for Wicket? Use Brix! http://brixcms.org*