You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "autophagy (via GitHub)" <gi...@apache.org> on 2025/08/11 14:21:37 UTC
[PR] [hotfix][python] Use `uv run` to run Python lint/testing tools, rather than directly installing [flink]
autophagy opened a new pull request, #26891:
URL: https://github.com/apache/flink/pull/26891
<!--
*Thank you very much for contributing to Apache Flink - we are happy that you want to help us improve Flink. To help the community review your contribution in the best possible way, please go through the checklist below, which will get the contribution into a shape in which it can be best reviewed.*
*Please understand that we do not do this to make contributions to Flink a hassle. In order to uphold a high standard of quality for code contributions, while at the same time managing a large number of contributions, we need contributors to prepare the contributions well, and give reviewers enough contextual information for the review. Please also understand that contributions that do not follow this guide will take longer to review and thus typically be picked up with lower priority by the community.*
## Contribution Checklist
- Make sure that the pull request corresponds to a [JIRA issue](https://issues.apache.org/jira/projects/FLINK/issues). Exceptions are made for typos in JavaDoc or documentation files, which need no JIRA issue.
- Name the pull request in the form "[FLINK-XXXX] [component] Title of the pull request", where *FLINK-XXXX* should be replaced by the actual issue number. Skip *component* if you are unsure about which is the best component.
Typo fixes that have no associated JIRA issue should be named following this pattern: `[hotfix] [docs] Fix typo in event time introduction` or `[hotfix] [javadocs] Expand JavaDoc for PuncuatedWatermarkGenerator`.
- Fill out the template below to describe the changes contributed by the pull request. That will give reviewers the context they need to do the review.
- Make sure that the change passes the automated tests, i.e., `mvn clean verify` passes. You can set up Azure Pipelines CI to do that following [this guide](https://cwiki.apache.org/confluence/display/FLINK/Azure+Pipelines#AzurePipelines-Tutorial:SettingupAzurePipelinesforaforkoftheFlinkrepository).
- Each pull request should address only one issue, not mix up code from multiple issues.
- Each commit in the pull request has a meaningful commit message (including the JIRA id)
- Once all items of the checklist are addressed, remove the above text and this checklist, leaving only the filled out template below.
**(The sections below can be removed for hotfixes of typos)**
-->
## What is the purpose of the change
With [FLINK-37775](https://issues.apache.org/jira/browse/FLINK-37775) and [FLINK-36900](https://issues.apache.org/jira/browse/FLINK-36900) we have started to use `uv` for managing Python testing environments and installing linting tools, as well as defining test/lint/typecheck dependencies in `pyproject.toml`.
Previously, the `lint-python.sh` script would have install and then tool run steps where it would first install the required tool for a lint stage into a venv, and then run the tool later. This PR removes this install step, instead using `uv run` to run the tools directly, which takes care of installing the tools and dependencies into a virtual environment. This simplifies the `lint-python.sh` script a little. I've also changed the tox install command to use uv to build apache-flink-libraries when needed, as well as using uv in the build-wheels script.
To do this, the apache-flink pyproject.toml needed a `project` table, so I've moved the static metadata out of the `setup.py` and into the pyproject's `project` table.
Lastly, I also added the `apache-flink-libraries` path as a source for uv to use in development. This means that if you do `uv pip install .` in the `apache-flink` project, `uv` automatically resolves the `apache-flink-libraries` dependency by building and installing it from source, so users no longer need to `python setup.py sdist` and `pip install dist/*` manually to get the `apache-flink-libraries` dependency.
## Brief change log
- Modified `lint-python.sh` to use `uv run` for running testing/lint/doc tools, rather than installing into a venv directly.
- Modified `build-wheels.sh` to use `uv` for both building the packages and for running auditwheel in linux environments.
- Moved `apache-flink`'s static metadata to `pyproject.toml`
- Added `apache-flink-libraries` as a local path source for `uv` for local development
## Verifying this change
This change is already covered by existing tests, such as the Python CI tests.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (no)
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
- The serializers: (no)
- The runtime per-record code paths (performance sensitive): (no)
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (no)
- The S3 file system connector: (no)
## Documentation
- Does this pull request introduce a new feature? (no)
- If yes, how is the feature documented? (no)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [hotfix][python] Use `uv run` to run Python lint/testing tools, rather than directly installing [flink]
Posted by "autophagy (via GitHub)" <gi...@apache.org>.
autophagy closed pull request #26891: [hotfix][python] Use `uv run` to run Python lint/testing tools, rather than directly installing
URL: https://github.com/apache/flink/pull/26891
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [hotfix][python] Use `uv run` to run Python lint/testing tools, rather than directly installing [flink]
Posted by "autophagy (via GitHub)" <gi...@apache.org>.
autophagy commented on PR #26891:
URL: https://github.com/apache/flink/pull/26891#issuecomment-3177876707
Just going to put this as a draft since I think theres more places that we could use `uv` - specifically for managing versions for building the wheels, maybe even for tox with `tox-uv`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [hotfix][python] Use `uv run` to run Python lint/testing tools, rather than directly installing [flink]
Posted by "flinkbot (via GitHub)" <gi...@apache.org>.
flinkbot commented on PR #26891:
URL: https://github.com/apache/flink/pull/26891#issuecomment-3175118050
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "e4acac5ee302defd295a4b5bd1cf54c1b2c270c4",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "e4acac5ee302defd295a4b5bd1cf54c1b2c270c4",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* e4acac5ee302defd295a4b5bd1cf54c1b2c270c4 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org