You are viewing a plain text version of this content. The canonical link for it is here.
Posted to gitbox@activemq.apache.org by GitBox <gi...@apache.org> on 2022/04/26 12:43:52 UTC
[GitHub] [activemq-artemis] gemmellr opened a new pull request, #4050: ARTEMIS-3804: make version number available to docs build
gemmellr opened a new pull request, #4050:
URL: https://github.com/apache/activemq-artemis/pull/4050
Make the version number available to reference in the user manual, add it to the intro page
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-artemis] gemmellr commented on pull request #4050: ARTEMIS-3804: make version number available to docs build
Posted by GitBox <gi...@apache.org>.
gemmellr commented on PR #4050:
URL: https://github.com/apache/activemq-artemis/pull/4050#issuecomment-1109897780
@clebertsuconic pushed an update for RELEASE.md ...like that?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-artemis] gemmellr commented on pull request #4050: ARTEMIS-3804: make version number available to docs build
Posted by GitBox <gi...@apache.org>.
gemmellr commented on PR #4050:
URL: https://github.com/apache/activemq-artemis/pull/4050#issuecomment-1109840918
I assumed that the artemis-website module was what you used for the website update during release, since thats what its called, and is already specifically building the doc during the release. The 'scratch' is just an intermediate filtered copy, whereas artemis-website was building from the same source originally.
I simply never envisaged that you didnt actually use the 'website' build output built during the release, so if thats how you do the release then yes it would need to change, or else the variable wouldnt be filtered/substituted.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-artemis] clebertsuconic commented on pull request #4050: ARTEMIS-3804: make version number available to docs build
Posted by GitBox <gi...@apache.org>.
clebertsuconic commented on PR #4050:
URL: https://github.com/apache/activemq-artemis/pull/4050#issuecomment-1109862314
I'm file with using a profile also.. Im just checking what we need to change on the Release... we will need to update the RELEASE.md as well. can you do that?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-artemis] clebertsuconic merged pull request #4050: ARTEMIS-3804: make version number available to docs build
Posted by GitBox <gi...@apache.org>.
clebertsuconic merged PR #4050:
URL: https://github.com/apache/activemq-artemis/pull/4050
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-artemis] gemmellr commented on pull request #4050: ARTEMIS-3804: make version number available to docs build
Posted by GitBox <gi...@apache.org>.
gemmellr commented on PR #4050:
URL: https://github.com/apache/activemq-artemis/pull/4050#issuecomment-1109841727
I'm fine with it being profiled, it seems unecessary to build it every time...in fact I would like to move the javadoc bit into the profile since its a massive waste of time on each build.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-artemis] clebertsuconic commented on pull request #4050: ARTEMIS-3804: make version number available to docs build
Posted by GitBox <gi...@apache.org>.
clebertsuconic commented on PR #4050:
URL: https://github.com/apache/activemq-artemis/pull/4050#issuecomment-1109833127
isn't that changing how we do release? we need now to build the release out of the scratch doc...
I usually just go to the user/en and type gitbook pdf, gitbook epub, gitbook build
and copy the files over.
now we will need to change the procedure a little bit, right?
perhaps this scratch build should be removed out of the release profile and always be ran?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-artemis] clebertsuconic commented on pull request #4050: ARTEMIS-3804: make version number available to docs build
Posted by GitBox <gi...@apache.org>.
clebertsuconic commented on PR #4050:
URL: https://github.com/apache/activemq-artemis/pull/4050#issuecomment-1109917729
thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org