You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sling.apache.org by "Dominique Jäggi (JIRA)" <ji...@apache.org> on 2008/02/19 17:20:43 UTC
[jira] Created: (SLING-259) Resource resolver needs to adapt to
repository node instead of bundle resource for component resolution
Resource resolver needs to adapt to repository node instead of bundle resource for component resolution
-------------------------------------------------------------------------------------------------------
Key: SLING-259
URL: https://issues.apache.org/jira/browse/SLING-259
Project: Sling
Issue Type: Bug
Components: Core
Reporter: Dominique Jäggi
When JSPs are deployed as bundle resources, the rendering/resolving of the associated JSP scripts works fine. the subsequent resolution of the component however fails, as the folder in the bundle takes precedence over the repository node.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (SLING-259) Bundle based Resource should be able to
adapt to Repository Item
Posted by "Felix Meschberger (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SLING-259?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Felix Meschberger updated SLING-259:
------------------------------------
Component/s: (was: Core)
Resource
Description:
When using bundle based Resources, items stored in the repository may be hidden by the actual bundle resources. This is ok for file-like resources but might be problematic in some situations for folders.
It would probably be helpfull, if bundle based resources would be able to adapt to repository items if an item would exist at the path of the resource.
was:When JSPs are deployed as bundle resources, the rendering/resolving of the associated JSP scripts works fine. the subsequent resolution of the component however fails, as the folder in the bundle takes precedence over the repository node.
Fix Version/s: 2.0.0
Assignee: Felix Meschberger
Issue Type: Improvement (was: Bug)
Summary: Bundle based Resource should be able to adapt to Repository Item (was: Resource resolver needs to adapt to repository node instead of bundle resource for component resolution)
Clarify issue description and summary
> Bundle based Resource should be able to adapt to Repository Item
> ----------------------------------------------------------------
>
> Key: SLING-259
> URL: https://issues.apache.org/jira/browse/SLING-259
> Project: Sling
> Issue Type: Improvement
> Components: Resource
> Reporter: Dominique Jäggi
> Assignee: Felix Meschberger
> Fix For: 2.0.0
>
>
> When using bundle based Resources, items stored in the repository may be hidden by the actual bundle resources. This is ok for file-like resources but might be problematic in some situations for folders.
> It would probably be helpfull, if bundle based resources would be able to adapt to repository items if an item would exist at the path of the resource.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SLING-259) Bundle based Resource should be able
to adapt to Repository Item
Posted by "Felix Meschberger (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SLING-259?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12570316#action_12570316 ]
Felix Meschberger commented on SLING-259:
-----------------------------------------
Implemented support in the BundleResource class to adapt to Node and Property in Rev. 629166.
It is probably still to be decided whether generalized support for JCR "shine-through" might be a good thing:
* If the BundleResource represents a folder (nt:folder by default) let the underlying Repository Item shine
through such that adaptTo adapts to Node or Property and the resource type is actually the resource
type of the underlying node. Likewise the URL and InputStream would actually point to the underlying
repository item.
* If the BundleResource represents a file (nt:file) the underlying JCR item should probably be completly
hidden. Likewise the URL and InputStream point to the bundle file resource.
WDYT ?
> Bundle based Resource should be able to adapt to Repository Item
> ----------------------------------------------------------------
>
> Key: SLING-259
> URL: https://issues.apache.org/jira/browse/SLING-259
> Project: Sling
> Issue Type: Improvement
> Components: Resource
> Reporter: Dominique Jäggi
> Assignee: Felix Meschberger
> Fix For: 2.0.0
>
>
> When using bundle based Resources, items stored in the repository may be hidden by the actual bundle resources. This is ok for file-like resources but might be problematic in some situations for folders.
> It would probably be helpfull, if bundle based resources would be able to adapt to repository items if an item would exist at the path of the resource.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Issue Comment Edited: (SLING-259) Bundle based Resource
should be able to adapt to Repository Item
Posted by "Felix Meschberger (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SLING-259?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12578173#action_12578173 ]
fmeschbe edited comment on SLING-259 at 3/13/08 12:46 AM:
-------------------------------------------------------------------
Fixed as indicated in previous comments in Rev. 636658.
Now a BundleResource is only created, if ...
* the path addresses an existing Bundle resource file
or
* the path addresses an existing Bundle resource folder and no repository item of the same name exists
Otherwise, particularly in case of a Bundle resource folder hiding an existing repository item, no BundleResource is returned.
As a consequence BundleResource instances do not adapt to repository items any more. This would just be very confusing as one resource might have two different contents (as per InputStream) and URLs.
was (Author: fmeschbe):
Fixed as indicated in previous comments in Rev. 636658.
Now a BundleResource is only created, if ...
* the path addresses an existing Bundle resource file
or
* the path addresses an existing Bundle resource folder and no repository item of the same name exists
Otherwise, particularly in case of a Bundle resource folder hiding an existing repository item, no BundleResource is returned.
> Bundle based Resource should be able to adapt to Repository Item
> ----------------------------------------------------------------
>
> Key: SLING-259
> URL: https://issues.apache.org/jira/browse/SLING-259
> Project: Sling
> Issue Type: Improvement
> Components: Resource
> Reporter: Dominique Jäggi
> Assignee: Felix Meschberger
> Fix For: 2.0.0
>
>
> When using bundle based Resources, items stored in the repository may be hidden by the actual bundle resources. This is ok for file-like resources but might be problematic in some situations for folders.
> It would probably be helpfull, if bundle based resources would be able to adapt to repository items if an item would exist at the path of the resource.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SLING-259) Bundle based Resource should be able
to adapt to Repository Item
Posted by "Felix Meschberger (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SLING-259?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12578060#action_12578060 ]
Felix Meschberger commented on SLING-259:
-----------------------------------------
Actually, to amend my last comment: A BundleResource should only be created for file resources in bundles not for folders. If a path resolves to a Bundle Based Folder and a repository item exists for the same path, the repository based resource should be returned instead of a BundleResource
> Bundle based Resource should be able to adapt to Repository Item
> ----------------------------------------------------------------
>
> Key: SLING-259
> URL: https://issues.apache.org/jira/browse/SLING-259
> Project: Sling
> Issue Type: Improvement
> Components: Resource
> Reporter: Dominique Jäggi
> Assignee: Felix Meschberger
> Fix For: 2.0.0
>
>
> When using bundle based Resources, items stored in the repository may be hidden by the actual bundle resources. This is ok for file-like resources but might be problematic in some situations for folders.
> It would probably be helpfull, if bundle based resources would be able to adapt to repository items if an item would exist at the path of the resource.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (SLING-259) Bundle based Resource should be able to
adapt to Repository Item
Posted by "Felix Meschberger (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SLING-259?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Felix Meschberger closed SLING-259.
-----------------------------------
Resolution: Fixed
Fixed as indicated in previous comments in Rev. 636658.
Now a BundleResource is only created, if ...
* the path addresses an existing Bundle resource file
or
* the path addresses an existing Bundle resource folder and no repository item of the same name exists
Otherwise, particularly in case of a Bundle resource folder hiding an existing repository item, no BundleResource is returned.
> Bundle based Resource should be able to adapt to Repository Item
> ----------------------------------------------------------------
>
> Key: SLING-259
> URL: https://issues.apache.org/jira/browse/SLING-259
> Project: Sling
> Issue Type: Improvement
> Components: Resource
> Reporter: Dominique Jäggi
> Assignee: Felix Meschberger
> Fix For: 2.0.0
>
>
> When using bundle based Resources, items stored in the repository may be hidden by the actual bundle resources. This is ok for file-like resources but might be problematic in some situations for folders.
> It would probably be helpfull, if bundle based resources would be able to adapt to repository items if an item would exist at the path of the resource.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.