You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/01/06 02:15:15 UTC

[GitHub] [flink] zuston opened a new pull request #18276: [FLINK-25536] Minor Fix: Adjust the order of variable declaration and…

zuston opened a new pull request #18276:
URL: https://github.com/apache/flink/pull/18276


   … comment in StateAssignmentOperation
   
   
   ## What is the purpose of the change
   
   Just to adjust the order of variable declaration and comment in StateAssignmentOperation
   
   ## Brief change log
   
   
   
   ## Verifying this change
   
   
   
   ## Does this pull request potentially affect one of the following parts:
   
   
   ## Documentation
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] zuston commented on pull request #18276: [FLINK-25536] Adjust the order of variable declaration and…

Posted by GitBox <gi...@apache.org>.
zuston commented on pull request #18276:
URL: https://github.com/apache/flink/pull/18276#issuecomment-1007354466


   Thanks @Myasuka 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] zuston commented on pull request #18276: [FLINK-25536] Minor Fix: Adjust the order of variable declaration and…

Posted by GitBox <gi...@apache.org>.
zuston commented on pull request #18276:
URL: https://github.com/apache/flink/pull/18276#issuecomment-1006230442


   @gaoyunhaii When i look through the OperatorState code, i found some unreasonable code and do this minor fix.
   Please check it. Thanks


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] Myasuka merged pull request #18276: [FLINK-25536] Adjust the order of variable declaration and…

Posted by GitBox <gi...@apache.org>.
Myasuka merged pull request #18276:
URL: https://github.com/apache/flink/pull/18276


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] zuston commented on pull request #18276: [FLINK-25536] Minor Fix: Adjust the order of variable declaration and…

Posted by GitBox <gi...@apache.org>.
zuston commented on pull request #18276:
URL: https://github.com/apache/flink/pull/18276#issuecomment-1006470623


   @flinkbot run azure


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #18276: [FLINK-25536] Minor Fix: Adjust the order of variable declaration and…

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18276:
URL: https://github.com/apache/flink/pull/18276#issuecomment-1006230279


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "374e16b016529c231a4d03500e6cad9f1b0f6482",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=28996",
       "triggerID" : "374e16b016529c231a4d03500e6cad9f1b0f6482",
       "triggerType" : "PUSH"
     }, {
       "hash" : "",
       "status" : "CANCELED",
       "url" : "TBD",
       "triggerID" : "1006470623",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "b10444c12a6aeb60ad6b0ba2dfa921abbf180cec",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29030",
       "triggerID" : "1006470623",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "b10444c12a6aeb60ad6b0ba2dfa921abbf180cec",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29030",
       "triggerID" : "b10444c12a6aeb60ad6b0ba2dfa921abbf180cec",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   *  Unknown: [CANCELED](TBD) 
   * b10444c12a6aeb60ad6b0ba2dfa921abbf180cec Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29030) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #18276: [FLINK-25536] Minor Fix: Adjust the order of variable declaration and…

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18276:
URL: https://github.com/apache/flink/pull/18276#issuecomment-1006230279


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "374e16b016529c231a4d03500e6cad9f1b0f6482",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=28996",
       "triggerID" : "374e16b016529c231a4d03500e6cad9f1b0f6482",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 374e16b016529c231a4d03500e6cad9f1b0f6482 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=28996) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #18276: [FLINK-25536] Minor Fix: Adjust the order of variable declaration and…

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18276:
URL: https://github.com/apache/flink/pull/18276#issuecomment-1006230279


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "374e16b016529c231a4d03500e6cad9f1b0f6482",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=28996",
       "triggerID" : "374e16b016529c231a4d03500e6cad9f1b0f6482",
       "triggerType" : "PUSH"
     }, {
       "hash" : "b10444c12a6aeb60ad6b0ba2dfa921abbf180cec",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "1006470623",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "",
       "status" : "CANCELED",
       "url" : "TBD",
       "triggerID" : "1006470623",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "b10444c12a6aeb60ad6b0ba2dfa921abbf180cec",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "b10444c12a6aeb60ad6b0ba2dfa921abbf180cec",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   *  Unknown: [CANCELED](TBD) 
   * b10444c12a6aeb60ad6b0ba2dfa921abbf180cec UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] zuston commented on pull request #18276: [FLINK-25536] Minor Fix: Adjust the order of variable declaration and…

Posted by GitBox <gi...@apache.org>.
zuston commented on pull request #18276:
URL: https://github.com/apache/flink/pull/18276#issuecomment-1006470370


   Done. 
   Thanks for your review @Myasuka.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] Myasuka merged pull request #18276: [FLINK-25536] Adjust the order of variable declaration and…

Posted by GitBox <gi...@apache.org>.
Myasuka merged pull request #18276:
URL: https://github.com/apache/flink/pull/18276


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot commented on pull request #18276: [FLINK-25536] Minor Fix: Adjust the order of variable declaration and…

Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #18276:
URL: https://github.com/apache/flink/pull/18276#issuecomment-1006230279


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "374e16b016529c231a4d03500e6cad9f1b0f6482",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "374e16b016529c231a4d03500e6cad9f1b0f6482",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 374e16b016529c231a4d03500e6cad9f1b0f6482 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot commented on pull request #18276: [FLINK-25536] Minor Fix: Adjust the order of variable declaration and…

Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #18276:
URL: https://github.com/apache/flink/pull/18276#issuecomment-1006231028


   Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
   to review your pull request. We will use this comment to track the progress of the review.
   
   
   ## Automated Checks
   Last check on commit 374e16b016529c231a4d03500e6cad9f1b0f6482 (Thu Jan 06 02:19:04 UTC 2022)
   
   **Warnings:**
    * No documentation files were touched! Remember to keep the Flink docs up to date!
    * **This pull request references an unassigned [Jira ticket](https://issues.apache.org/jira/browse/FLINK-25536).** According to the [code contribution guide](https://flink.apache.org/contributing/contribute-code.html), tickets need to be assigned before starting with the implementation work.
   
   
   <sub>Mention the bot in a comment to re-run the automated checks.</sub>
   ## Review Progress
   
   * ❓ 1. The [description] looks good.
   * ❓ 2. There is [consensus] that the contribution should go into to Flink.
   * ❓ 3. Needs [attention] from.
   * ❓ 4. The change fits into the overall [architecture].
   * ❓ 5. Overall code [quality] is good.
   
   Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
    The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
    - `@flinkbot approve all` to approve all aspects
    - `@flinkbot approve-until architecture` to approve everything until `architecture`
    - `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
    - `@flinkbot disapprove architecture` to remove an approval you gave earlier
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] zuston commented on pull request #18276: [FLINK-25536] Adjust the order of variable declaration and…

Posted by GitBox <gi...@apache.org>.
zuston commented on pull request #18276:
URL: https://github.com/apache/flink/pull/18276#issuecomment-1007354466


   Thanks @Myasuka 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #18276: [FLINK-25536] Minor Fix: Adjust the order of variable declaration and…

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18276:
URL: https://github.com/apache/flink/pull/18276#issuecomment-1006230279


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "374e16b016529c231a4d03500e6cad9f1b0f6482",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=28996",
       "triggerID" : "374e16b016529c231a4d03500e6cad9f1b0f6482",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 374e16b016529c231a4d03500e6cad9f1b0f6482 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=28996) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #18276: [FLINK-25536] Minor Fix: Adjust the order of variable declaration and…

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18276:
URL: https://github.com/apache/flink/pull/18276#issuecomment-1006230279


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "374e16b016529c231a4d03500e6cad9f1b0f6482",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=28996",
       "triggerID" : "374e16b016529c231a4d03500e6cad9f1b0f6482",
       "triggerType" : "PUSH"
     }, {
       "hash" : "b10444c12a6aeb60ad6b0ba2dfa921abbf180cec",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29030",
       "triggerID" : "1006470623",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "b10444c12a6aeb60ad6b0ba2dfa921abbf180cec",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29030",
       "triggerID" : "b10444c12a6aeb60ad6b0ba2dfa921abbf180cec",
       "triggerType" : "PUSH"
     }, {
       "hash" : "",
       "status" : "DELETED",
       "url" : "TBD",
       "triggerID" : "1006470623",
       "triggerType" : "MANUAL"
     } ]
   }-->
   ## CI report:
   
   * b10444c12a6aeb60ad6b0ba2dfa921abbf180cec Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29030) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org