[jira] [Work logged] (MAPREDUCE-7311) Fix non-idempotent test in TestTaskProgressReporter

["ASF GitHub Bot (Jira)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/MAPREDUCE-7311?focusedWorklogId=637921&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-637921 ]

ASF GitHub Bot logged work on MAPREDUCE-7311:
---------------------------------------------

                Author: ASF GitHub Bot
            Created on: 14/Aug/21 02:00
            Start Date: 14/Aug/21 02:00
    Worklog Time Spent: 10m 
      Work Description: lzx404243 commented on pull request #2500:
URL: https://github.com/apache/hadoop/pull/2500#issuecomment-898794132


   Hi @aajisaka , could you please help reviewing this change? It resolves similar issues as #2499 . Thanks!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Issue Time Tracking
-------------------

            Worklog Id:     (was: 637921)
    Remaining Estimate: 0h
            Time Spent: 10m

> Fix non-idempotent test in TestTaskProgressReporter
> ---------------------------------------------------
>
>                 Key: MAPREDUCE-7311
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-7311
>             Project: Hadoop Map/Reduce
>          Issue Type: Test
>            Reporter: Zhengxi Li
>            Priority: Minor
>         Attachments: MAPREDUCE-7311.001.patch
>
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> The test {{`org.apache.hadoop.mapred.TestTaskProgressReporter.testBytesWrittenRespectingLimit`}} is not idempotent and fails if run twice in the same JVM, because it pollutes state shared among tests. It may be good to clean this state pollution so that some other tests do not fail in the future due to the shared state polluted by this test.
> h3. Details
> Running {{`TestTaskProgressReporter.testBytesWrittenRespectingLimit`}} twice would result in the second run failing with the following assertion:
> {noformat}
> Assert.assertEquals(failFast, threadExited)
> {noformat}
> The root cause for this is that when`testBytesWrittenRespectingLimit` writes some bytes on the local file system, some counters are being incremented. The problem is that, after the test is done, the counter is not reset. With this polluted shared state, assumptions are broken, resulting in test failure in the second run.
> PR link: https://github.com/apache/hadoop/pull/2500



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: mapreduce-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: mapreduce-issues-help@hadoop.apache.org