You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by "parisni (via GitHub)" <gi...@apache.org> on 2024/07/19 21:35:03 UTC
[PR] [HUDI-8006] Fix glue sync async call to update table [hudi]
parisni opened a new pull request, #11659:
URL: https://github.com/apache/hudi/pull/11659
### Change Logs
When multiple updateTable are chained, the async call may overlap and some intermediary table changes may be lost. By forcing the future, it fixes this behavior.
related to #11599
### Impact
Low
### Risk level (write none, low medium or high below)
none
### Documentation Update
_Describe any necessary documentation update if there is any new feature, config, or user-facing change. If not, put "none"._
- _The config description must be updated if new configs are added or the default value of the configs are changed_
- _Any new feature or user-facing change requires updating the Hudi website. Please create a Jira ticket, attach the
ticket number here and follow the [instruction](https://hudi.apache.org/contribute/developer-setup#website) to make
changes to the website._
### Contributor's checklist
- [ ] Read through [contributor's guide](https://hudi.apache.org/contribute/how-to-contribute)
- [ ] Change Logs and Impact were stated clearly
- [ ] Adequate tests were added if applicable
- [ ] CI passed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-8006] Fix glue sync async call to update table [hudi]
Posted by "danny0405 (via GitHub)" <gi...@apache.org>.
danny0405 merged PR #11659:
URL: https://github.com/apache/hudi/pull/11659
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-8006] Fix glue sync async call to update table [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #11659:
URL: https://github.com/apache/hudi/pull/11659#issuecomment-2240379823
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "b14f4b40f87e4b85fd8f6d64b3652926dc23da50",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "b14f4b40f87e4b85fd8f6d64b3652926dc23da50",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* b14f4b40f87e4b85fd8f6d64b3652926dc23da50 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-8006] Fix glue sync async call to update table [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #11659:
URL: https://github.com/apache/hudi/pull/11659#issuecomment-2243914393
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "b14f4b40f87e4b85fd8f6d64b3652926dc23da50",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=24922",
"triggerID" : "b14f4b40f87e4b85fd8f6d64b3652926dc23da50",
"triggerType" : "PUSH"
}, {
"hash" : "797bff381ffdd1420929e38896fff6a56ae9e566",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=24956",
"triggerID" : "797bff381ffdd1420929e38896fff6a56ae9e566",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 797bff381ffdd1420929e38896fff6a56ae9e566 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=24956)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-8006] Fix glue sync async call to update table [hudi]
Posted by "parisni (via GitHub)" <gi...@apache.org>.
parisni commented on code in PR #11659:
URL: https://github.com/apache/hudi/pull/11659#discussion_r1685282993
##########
hudi-aws/src/main/java/org/apache/hudi/aws/sync/AWSGlueCatalogSyncClient.java:
##########
@@ -497,7 +497,11 @@ && getTable(awsGlue, databaseName, tableName).partitionKeys().equals(partitionKe
.tableInput(updatedTableInput)
.build();
- awsGlue.updateTable(request);
+ try {
+ awsGlue.updateTable(request).get();
Review Comment:
The updateTable glue operation is pretty fast. So the impact is negligible.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-8006] Fix glue sync async call to update table [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #11659:
URL: https://github.com/apache/hudi/pull/11659#issuecomment-2243840486
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "b14f4b40f87e4b85fd8f6d64b3652926dc23da50",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=24922",
"triggerID" : "b14f4b40f87e4b85fd8f6d64b3652926dc23da50",
"triggerType" : "PUSH"
}, {
"hash" : "797bff381ffdd1420929e38896fff6a56ae9e566",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=24956",
"triggerID" : "797bff381ffdd1420929e38896fff6a56ae9e566",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* b14f4b40f87e4b85fd8f6d64b3652926dc23da50 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=24922)
* 797bff381ffdd1420929e38896fff6a56ae9e566 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=24956)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-8006] Fix glue sync async call to update table [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #11659:
URL: https://github.com/apache/hudi/pull/11659#issuecomment-2240413546
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "b14f4b40f87e4b85fd8f6d64b3652926dc23da50",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=24922",
"triggerID" : "b14f4b40f87e4b85fd8f6d64b3652926dc23da50",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* b14f4b40f87e4b85fd8f6d64b3652926dc23da50 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=24922)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-8006] Fix glue sync async call to update table [hudi]
Posted by "danny0405 (via GitHub)" <gi...@apache.org>.
danny0405 commented on code in PR #11659:
URL: https://github.com/apache/hudi/pull/11659#discussion_r1685168318
##########
hudi-aws/src/main/java/org/apache/hudi/aws/sync/AWSGlueCatalogSyncClient.java:
##########
@@ -497,7 +497,11 @@ && getTable(awsGlue, databaseName, tableName).partitionKeys().equals(partitionKe
.tableInput(updatedTableInput)
.build();
- awsGlue.updateTable(request);
+ try {
+ awsGlue.updateTable(request).get();
Review Comment:
Does this change impact the access efficiency?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-8006] Fix glue sync async call to update table [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #11659:
URL: https://github.com/apache/hudi/pull/11659#issuecomment-2240587892
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "b14f4b40f87e4b85fd8f6d64b3652926dc23da50",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=24922",
"triggerID" : "b14f4b40f87e4b85fd8f6d64b3652926dc23da50",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* b14f4b40f87e4b85fd8f6d64b3652926dc23da50 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=24922)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-8006] Fix glue sync async call to update table [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #11659:
URL: https://github.com/apache/hudi/pull/11659#issuecomment-2243778053
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "b14f4b40f87e4b85fd8f6d64b3652926dc23da50",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=24922",
"triggerID" : "b14f4b40f87e4b85fd8f6d64b3652926dc23da50",
"triggerType" : "PUSH"
}, {
"hash" : "797bff381ffdd1420929e38896fff6a56ae9e566",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "797bff381ffdd1420929e38896fff6a56ae9e566",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* b14f4b40f87e4b85fd8f6d64b3652926dc23da50 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=24922)
* 797bff381ffdd1420929e38896fff6a56ae9e566 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-8006] Fix glue sync async call to update table [hudi]
Posted by "danny0405 (via GitHub)" <gi...@apache.org>.
danny0405 commented on PR #11659:
URL: https://github.com/apache/hudi/pull/11659#issuecomment-2242393049
@parisni Have re-triggered the failed CI: https://dev.azure.com/apache-hudi-ci-org/apache-hudi-ci/_build/results?buildId=24922&view=results
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org