You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cocoon.apache.org by "Jasha Joachimsthal (JIRA)" <ji...@apache.org> on 2008/06/18 12:42:45 UTC
[jira] Created: (COCOON-2213) Change check on mime-type to enable
custom encoding of the body
Change check on mime-type to enable custom encoding of the body
---------------------------------------------------------------
Key: COCOON-2213
URL: https://issues.apache.org/jira/browse/COCOON-2213
Project: Cocoon
Issue Type: Improvement
Components: Blocks: Mail
Affects Versions: 2.1.11
Reporter: Jasha Joachimsthal
Priority: Minor
Fix For: 2.1.12-dev (Current SVN)
Since the patch in COCOON-1622 was applied, a check is done on the mime-type for the output format. It checks if the value is equal to either text/plain or text/html. It may be necessary to explicitly set a charset in the mime-type. This means the check for the mime type should not equals but startsWith.
COCOON-1622 seems to be only applied in the 2.1 branch, not in 2.2.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (COCOON-2213) Change check on mime-type to enable
custom encoding of the body
Posted by "Jasha Joachimsthal (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/COCOON-2213?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jasha Joachimsthal updated COCOON-2213:
---------------------------------------
Fix Version/s: 2.2-dev (Current SVN)
Affects Version/s: 2.2-dev (Current SVN)
> Change check on mime-type to enable custom encoding of the body
> ---------------------------------------------------------------
>
> Key: COCOON-2213
> URL: https://issues.apache.org/jira/browse/COCOON-2213
> Project: Cocoon
> Issue Type: Improvement
> Components: Blocks: Mail
> Affects Versions: 2.1.11, 2.2-dev (Current SVN)
> Reporter: Jasha Joachimsthal
> Assignee: Alfred Nathaniel
> Priority: Minor
> Fix For: 2.1.12-dev (Current SVN), 2.2-dev (Current SVN)
>
> Attachments: SendMailTransformer-plaintext.patch, SendMailTransformer_mime-type.patch
>
>
> Since the patch in COCOON-1622 was applied, a check is done on the mime-type for the output format. It checks if the value is equal to either text/plain or text/html. It may be necessary to explicitly set a charset in the mime-type. This means the check for the mime type should not equals but startsWith.
> COCOON-1622 seems to be only applied in the 2.1 branch, not in 2.2.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (COCOON-2213) Change check on mime-type to enable
custom encoding of the body
Posted by "Jasha Joachimsthal (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/COCOON-2213?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jasha Joachimsthal updated COCOON-2213:
---------------------------------------
Attachment: SendMailTransformer_mime-type.patch
Patch with changed mime-type check
> Change check on mime-type to enable custom encoding of the body
> ---------------------------------------------------------------
>
> Key: COCOON-2213
> URL: https://issues.apache.org/jira/browse/COCOON-2213
> Project: Cocoon
> Issue Type: Improvement
> Components: Blocks: Mail
> Affects Versions: 2.1.11
> Reporter: Jasha Joachimsthal
> Priority: Minor
> Fix For: 2.1.12-dev (Current SVN)
>
> Attachments: SendMailTransformer_mime-type.patch
>
>
> Since the patch in COCOON-1622 was applied, a check is done on the mime-type for the output format. It checks if the value is equal to either text/plain or text/html. It may be necessary to explicitly set a charset in the mime-type. This means the check for the mime type should not equals but startsWith.
> COCOON-1622 seems to be only applied in the 2.1 branch, not in 2.2.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (COCOON-2213) Change check on mime-type to enable
custom encoding of the body
Posted by "Jasha Joachimsthal (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/COCOON-2213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12605907#action_12605907 ]
Jasha Joachimsthal commented on COCOON-2213:
--------------------------------------------
Useful in cases like
<email:body mime-type="text/html;charset=UTF-8">
</email:body>
<email:body mime-type="text/plain;charset=UTF-8">
</email:body>
> Change check on mime-type to enable custom encoding of the body
> ---------------------------------------------------------------
>
> Key: COCOON-2213
> URL: https://issues.apache.org/jira/browse/COCOON-2213
> Project: Cocoon
> Issue Type: Improvement
> Components: Blocks: Mail
> Affects Versions: 2.1.11
> Reporter: Jasha Joachimsthal
> Priority: Minor
> Fix For: 2.1.12-dev (Current SVN)
>
> Attachments: SendMailTransformer_mime-type.patch
>
>
> Since the patch in COCOON-1622 was applied, a check is done on the mime-type for the output format. It checks if the value is equal to either text/plain or text/html. It may be necessary to explicitly set a charset in the mime-type. This means the check for the mime type should not equals but startsWith.
> COCOON-1622 seems to be only applied in the 2.1 branch, not in 2.2.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (COCOON-2213) Change check on mime-type to enable
custom encoding of the body
Posted by "Alfred Nathaniel (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/COCOON-2213?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Alfred Nathaniel updated COCOON-2213:
-------------------------------------
Status: On Hold (was: Open)
Applied your patch and synchronized branch and trunk versions.
That means that http://svn.apache.org/viewvc?view=rev&revision=314933 is now backported to 2.1
and that http://issues.apache.org/jira/browse/COCOON-1622 is now also in 2.2.
Please check and close issue.
> Change check on mime-type to enable custom encoding of the body
> ---------------------------------------------------------------
>
> Key: COCOON-2213
> URL: https://issues.apache.org/jira/browse/COCOON-2213
> Project: Cocoon
> Issue Type: Improvement
> Components: Blocks: Mail
> Affects Versions: 2.1.11
> Reporter: Jasha Joachimsthal
> Assignee: Alfred Nathaniel
> Priority: Minor
> Fix For: 2.1.12-dev (Current SVN)
>
> Attachments: SendMailTransformer_mime-type.patch
>
>
> Since the patch in COCOON-1622 was applied, a check is done on the mime-type for the output format. It checks if the value is equal to either text/plain or text/html. It may be necessary to explicitly set a charset in the mime-type. This means the check for the mime type should not equals but startsWith.
> COCOON-1622 seems to be only applied in the 2.1 branch, not in 2.2.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (COCOON-2213) Change check on mime-type to enable
custom encoding of the body
Posted by "Jasha Joachimsthal (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/COCOON-2213?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jasha Joachimsthal closed COCOON-2213.
--------------------------------------
Resolution: Fixed
Affects version (Component): Parent values: Blocks: Mail(10170). Level 1 values: 1.0.0(10394).
Fix version (Component): Parent values: Blocks: Mail(10242). Level 1 values: 1.1.0-SNAPSHOT(10401).
> Change check on mime-type to enable custom encoding of the body
> ---------------------------------------------------------------
>
> Key: COCOON-2213
> URL: https://issues.apache.org/jira/browse/COCOON-2213
> Project: Cocoon
> Issue Type: Improvement
> Components: Blocks: Mail
> Affects Versions: 2.1.11, 2.2-dev (Current SVN)
> Reporter: Jasha Joachimsthal
> Assignee: Alfred Nathaniel
> Priority: Minor
> Fix For: 2.1.12-dev (Current SVN), 2.2-dev (Current SVN)
>
> Attachments: SendMailTransformer-plaintext.patch, SendMailTransformer_mime-type.patch
>
>
> Since the patch in COCOON-1622 was applied, a check is done on the mime-type for the output format. It checks if the value is equal to either text/plain or text/html. It may be necessary to explicitly set a charset in the mime-type. This means the check for the mime type should not equals but startsWith.
> COCOON-1622 seems to be only applied in the 2.1 branch, not in 2.2.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (COCOON-2213) Change check on mime-type to enable
custom encoding of the body
Posted by "Alfred Nathaniel (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/COCOON-2213?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Alfred Nathaniel reassigned COCOON-2213:
----------------------------------------
Assignee: Alfred Nathaniel
> Change check on mime-type to enable custom encoding of the body
> ---------------------------------------------------------------
>
> Key: COCOON-2213
> URL: https://issues.apache.org/jira/browse/COCOON-2213
> Project: Cocoon
> Issue Type: Improvement
> Components: Blocks: Mail
> Affects Versions: 2.1.11
> Reporter: Jasha Joachimsthal
> Assignee: Alfred Nathaniel
> Priority: Minor
> Fix For: 2.1.12-dev (Current SVN)
>
> Attachments: SendMailTransformer_mime-type.patch
>
>
> Since the patch in COCOON-1622 was applied, a check is done on the mime-type for the output format. It checks if the value is equal to either text/plain or text/html. It may be necessary to explicitly set a charset in the mime-type. This means the check for the mime type should not equals but startsWith.
> COCOON-1622 seems to be only applied in the 2.1 branch, not in 2.2.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (COCOON-2213) Change check on mime-type to enable
custom encoding of the body
Posted by "Jasha Joachimsthal (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/COCOON-2213?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jasha Joachimsthal updated COCOON-2213:
---------------------------------------
Attachment: SendMailTransformer-plaintext.patch
Seems like one code changes breaks setting a charset on plain/text mails. I couldn't find your change in one of the patches for this issue or COCOON-1622. Created a patch to revert this.
> Change check on mime-type to enable custom encoding of the body
> ---------------------------------------------------------------
>
> Key: COCOON-2213
> URL: https://issues.apache.org/jira/browse/COCOON-2213
> Project: Cocoon
> Issue Type: Improvement
> Components: Blocks: Mail
> Affects Versions: 2.1.11
> Reporter: Jasha Joachimsthal
> Assignee: Alfred Nathaniel
> Priority: Minor
> Fix For: 2.1.12-dev (Current SVN)
>
> Attachments: SendMailTransformer-plaintext.patch, SendMailTransformer_mime-type.patch
>
>
> Since the patch in COCOON-1622 was applied, a check is done on the mime-type for the output format. It checks if the value is equal to either text/plain or text/html. It may be necessary to explicitly set a charset in the mime-type. This means the check for the mime type should not equals but startsWith.
> COCOON-1622 seems to be only applied in the 2.1 branch, not in 2.2.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.