You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "zhengruifeng (via GitHub)" <gi...@apache.org> on 2026/08/03 11:59:57 UTC
[PR] [SPARK-58463][INFRA][FOLLOWUP] Format merge summary output [spark]
zhengruifeng opened a new pull request, #57719:
URL: https://github.com/apache/spark/pull/57719
### What changes were proposed in this pull request?
This follow-up to SPARK-58463 updates dev/merge_spark_pr.py to render the terminal merge-summary block and its branch lines in bold. The attribution remains unbolded and directly follows the final merge line in the PR comment.
### Why are the changes needed?
The merge summary should be easy to scan without emphasizing the attribution, and the extra blank line before the attribution is unnecessary.
### Does this PR introduce _any_ user-facing change?
No.
### How was this patch tested?
Ran a no-post dry run of post_merge_comment with master and branch-4.x merge records, with the GitHub token cleared. Also ran git diff --check.
### Was this patch authored or co-authored using generative AI tooling?
Generated-by: Codex (GPT-5)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-58463][INFRA][FOLLOWUP] Format merge summary output [spark]
Posted by "zhengruifeng (via GitHub)" <gi...@apache.org>.
zhengruifeng commented on PR #57719:
URL: https://github.com/apache/spark/pull/57719#issuecomment-5166909770
**Merge Summary:**
- merged into master https://github.com/apache/spark/commit/bdb660b3e826206b51d91a613f12c83d42fea96a
*Posted by `merge_spark_pr.py`*
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-58463][INFRA][FOLLOWUP] Format merge summary output [spark]
Posted by "zhengruifeng (via GitHub)" <gi...@apache.org>.
zhengruifeng commented on code in PR #57719:
URL: https://github.com/apache/spark/pull/57719#discussion_r3708457116
##########
dev/merge_spark_pr.py:
##########
@@ -458,8 +458,13 @@ def post_merge_comment(pr_num, merged_commits):
"- merged into %s %s/%s" % (ref, GITHUB_COMMIT_BASE, commit_hash)
for ref, commit_hash in merged_commits
]
- body = "**Merge Summary:**\n" + "\n".join(lines) + "\n\n*Posted by `merge_spark_pr.py`*"
- print("\n%s\n\n%s" % (bold("Posting merge comment on PR #%s:" % pr_num), body))
+ summary = "**Merge Summary:**\n" + "\n".join(lines)
+ attribution = "*Posted by `merge_spark_pr.py`*"
+ body = "%s\n%s" % (summary, attribution)
Review Comment:
good catch, https://github.com/apache/spark/pull/57731
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-58463][INFRA][FOLLOWUP] Format merge summary output [spark]
Posted by "cloud-fan (via GitHub)" <gi...@apache.org>.
cloud-fan commented on code in PR #57719:
URL: https://github.com/apache/spark/pull/57719#discussion_r3704917381
##########
dev/merge_spark_pr.py:
##########
@@ -458,8 +458,13 @@ def post_merge_comment(pr_num, merged_commits):
"- merged into %s %s/%s" % (ref, GITHUB_COMMIT_BASE, commit_hash)
for ref, commit_hash in merged_commits
]
- body = "**Merge Summary:**\n" + "\n".join(lines) + "\n\n*Posted by `merge_spark_pr.py`*"
- print("\n%s\n\n%s" % (bold("Posting merge comment on PR #%s:" % pr_num), body))
+ summary = "**Merge Summary:**\n" + "\n".join(lines)
+ attribution = "*Posted by `merge_spark_pr.py`*"
+ body = "%s\n%s" % (summary, attribution)
Review Comment:
We need two `\n` to make the format correct, see https://github.com/apache/spark/pull/57712#issuecomment-5167796543
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-58463][INFRA][FOLLOWUP] Format merge summary output [spark]
Posted by "uros-b (via GitHub)" <gi...@apache.org>.
uros-b commented on PR #57719:
URL: https://github.com/apache/spark/pull/57719#issuecomment-5166157573
LGTM
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-58463][INFRA][FOLLOWUP] Format merge summary output [spark]
Posted by "zhengruifeng (via GitHub)" <gi...@apache.org>.
zhengruifeng closed pull request #57719: [SPARK-58463][INFRA][FOLLOWUP] Format merge summary output
URL: https://github.com/apache/spark/pull/57719
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org