[trafficserver] branch master updated: Ignore unsupported HTTP/2 settings parameters

[ma...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

masaori pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/trafficserver.git


The following commit(s) were added to refs/heads/master by this push:
     new 6ae8c58  Ignore unsupported HTTP/2 settings parameters
6ae8c58 is described below

commit 6ae8c58cccf4b2ed425c025df99830fd4532f5a8
Author: Masaori Koshiba <ma...@gmail.com>
AuthorDate: Fri Apr 12 09:28:38 2019 +0900

    Ignore unsupported HTTP/2 settings parameters
---
 proxy/http2/Http2ConnectionState.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/proxy/http2/Http2ConnectionState.h b/proxy/http2/Http2ConnectionState.h
index 50c2b39..57cd368 100644
--- a/proxy/http2/Http2ConnectionState.h
+++ b/proxy/http2/Http2ConnectionState.h
@@ -85,7 +85,7 @@ public:
     if (0 < id && id < HTTP2_SETTINGS_MAX) {
       return this->settings[indexof(id)] = value;
     } else {
-      ink_assert(!"Bad Settings Identifier");
+      // Do nothing - 6.5.3 Unsupported parameters MUST be ignored.
     }
 
     return 0;