[GitHub] [superset] rusackas commented on a change in pull request #16102: feat: add sticky state to tables and loadingcards state.

[GitBox <gi...@apache.org>]

rusackas commented on a change in pull request #16102:
URL: https://github.com/apache/superset/pull/16102#discussion_r685498325



##########
File path: superset-frontend/src/views/CRUD/welcome/Welcome.tsx
##########
@@ -118,6 +132,14 @@ const WelcomeNav = styled.div`
   }
 `;
 
+export const LoadingCards = ({ cover }: LoadingProps) => (
+  <CardContainer showThumbnails={cover} className="loading-cards">
+    {[...new Array(8)].map(() => (

Review comment:
       Is this 8 because of the Recents cards? I was wondering if this could actually import/use the `PAGE_SIZE` constant we already export from `CRUD/utils.tsx` which happens to be 5.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org