You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by "Tishj (via GitHub)" <gi...@apache.org> on 2025/05/02 14:42:30 UTC
[I] Confusing rules for `struct` defaults [iceberg]
Tishj opened a new issue, #12953:
URL: https://github.com/apache/iceberg/issues/12953
This line:
https://github.com/apache/iceberg/blob/61e8acecf512d8dd2a72727803e5836ea1099eed/format/spec.md?plain=1#L329
Says that a struct default can either be `null` or `{}`.
Any default for a field of a struct should be defined on that field itself.
These lines
https://github.com/apache/iceberg/blob/61e8acecf512d8dd2a72727803e5836ea1099eed/format/spec.md?plain=1#L330
https://github.com/apache/iceberg/blob/61e8acecf512d8dd2a72727803e5836ea1099eed/format/spec.md?plain=1#L331
Hint at the possibility for the struct default to contain defaults for fields, which the previous line has just explained is not allowed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [I] Confusing rules for `struct` defaults [iceberg]
Posted by "Tishj (via GitHub)" <gi...@apache.org>.
Tishj commented on issue #12953:
URL: https://github.com/apache/iceberg/issues/12953#issuecomment-2876688965
I'd honestly say just remove it, the first line is clear enough, especially with the accompanying table.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [I] Confusing rules for `struct` defaults [iceberg]
Posted by "Verest (via GitHub)" <gi...@apache.org>.
Verest commented on issue #12953:
URL: https://github.com/apache/iceberg/issues/12953#issuecomment-3140821861
I suspect lines 330/331 are outdated after https://github.com/apache/iceberg/pull/12841 was merged.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [I] Confusing rules for `struct` defaults [iceberg]
Posted by "RussellSpitzer (via GitHub)" <gi...@apache.org>.
RussellSpitzer commented on issue #12953:
URL: https://github.com/apache/iceberg/issues/12953#issuecomment-2847829940
Does the example make this clear?
point default | point.x default | point.y default | Data value | Result value
-- | -- | -- | -- | --
null | 0 | 0 | (missing) | null
null | 0 | 0 | {"x": 3} | {"x": 3, "y": 0}
{} | 0 | 0 | (missing) | {"x": 0, "y": 0}
{} | 0 | 0 | {"y": -1} | {"x": 0, "y": -1}
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [I] Confusing rules for `struct` defaults [iceberg]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on issue #12953:
URL: https://github.com/apache/iceberg/issues/12953#issuecomment-3887959912
This issue has been closed because it has not received any activity in the last 14 days since being marked as 'stale'
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [I] Confusing rules for `struct` defaults [iceberg]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on issue #12953:
URL: https://github.com/apache/iceberg/issues/12953#issuecomment-3814631097
This issue has been automatically marked as stale because it has been open for 180 days with no activity. It will be closed in next 14 days if no further activity occurs. To permanently prevent this issue from being considered stale, add the label 'not-stale', but commenting on the issue is preferred when possible.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [I] Confusing rules for `struct` defaults [iceberg]
Posted by "RussellSpitzer (via GitHub)" <gi...@apache.org>.
RussellSpitzer commented on issue #12953:
URL: https://github.com/apache/iceberg/issues/12953#issuecomment-2851300853
Got it, do you have a new wording you would suggest?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [I] Confusing rules for `struct` defaults [iceberg]
Posted by "Tishj (via GitHub)" <gi...@apache.org>.
Tishj commented on issue #12953:
URL: https://github.com/apache/iceberg/issues/12953#issuecomment-2849047886
Yes, the examples are great, like I said the intent is clear, but those 2 lines add nothing but confusion.
They talk about an alternative for a situation that is in direct contradiction with the spec, making that situation (having defaults for fields inside the default value for the `struct`) sound like it is legal in the spec
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [I] Confusing rules for `struct` defaults [iceberg]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] closed issue #12953: Confusing rules for `struct` defaults
URL: https://github.com/apache/iceberg/issues/12953
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org