You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2019/09/30 10:11:51 UTC

[GitHub] [flink] xuyang1706 commented on issue #9355: [FLINK-13577][ml] Add an util class to build result row and generate …

xuyang1706 commented on issue #9355: [FLINK-13577][ml] Add an util class to build result row and generate …
URL: https://github.com/apache/flink/pull/9355#issuecomment-536496832
 
 
   > thanks for the contribution @xuyang1706 . This is a relatively small PR. i was wondering if it is better to combine with the PR which actually uses this utility.
   > But regarding this contribution, I think overall it looks good. I left one comment regarding the API, and others are mostly questions regarding the JavaDoc and other APIs ( which prompts me to think it might be automatically answered if we combine with the actual contribution that uses the util).
   > Please let me know what do you think
   
   @walterddr , thanks for your comments and advice. I refined the code. Some PRs use this util, e.g. #9769 . 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services