[GitHub] spark pull request #14674: [SPARK-17002][CORE]: Document that spark.ssl.prot...

[srowen <gi...@git.apache.org>]

Github user srowen commented on a diff in the pull request:

    https://github.com/apache/spark/pull/14674#discussion_r75082040
  
    --- Diff: core/src/main/scala/org/apache/spark/SecurityManager.scala ---
    @@ -282,7 +282,9 @@ private[spark] class SecurityManager(sparkConf: SparkConf)
           }: TrustManager
         })
     
    -    val sslContext = SSLContext.getInstance(fileServerSSLOptions.protocol.getOrElse("Default"))
    +    require(fileServerSSLOptions.protocol != None,
    --- End diff --
    
    It's fine though you could also write `.isDefined` here, which might be a millimeter more canonical. Some would use `getOrElse` to throw an exception, but `require` seems a little tidier for this purpose. Of course the change's substance looks fine.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org