You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Jaimin Jetly <ja...@hortonworks.com> on 2015/01/23 01:49:08 UTC

Review Request 30201: Integrate Configure Identities page and Disable security page with the new API (kerberos descriptor provided as an artifact)

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30201/
-----------------------------------------------------------

Review request for Ambari, Srimanth Gunturi, Xi Wang, and Yusaku Sako.


Bugs: AMBARI-9284
    https://issues.apache.org/jira/browse/AMBARI-9284


Repository: ambari


Description
-------

Apart from integrating FE with new descriptor API, this patch also fixes an issue where incorrect admin credentials fails "Test Kerberos" command on "Install and Test Kerberos" page and does not inform anything to the enduser.

NOTE: After integration with the New API, customization of the identities and configs does not update relevant configurations in the service sites.


Diffs
-----

  ambari-web/app/controllers/main/admin/kerberos.js 7d1cc89 
  ambari-web/app/controllers/main/admin/kerberos/step6_controller.js 1b4e726 
  ambari-web/app/mixins/wizard/addSecurityConfigs.js 87fa2b6 
  ambari-web/app/routes/add_kerberos_routes.js 90ce279 
  ambari-web/app/utils/ajax/ajax.js 1f343dc 
  ambari-web/test/mixins/wizard/addSeccurityConfigs_test.js dcdd1d8 
  ambari-web/test/mock_data_setup/stack_descriptors.js 989d728 

Diff: https://reviews.apache.org/r/30201/diff/


Testing
-------

manually tested.

**ambari-web unit test result with the patch:**

  5251 tests complete (8 seconds)
  63 tests pending


Thanks,

Jaimin Jetly


Re: Review Request 30201: Integrate Configure Identities page and Disable security page with the new API (kerberos descriptor provided as an artifact)

Posted by Yusaku Sako <yu...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30201/#review69315
-----------------------------------------------------------

Ship it!


Ship It!

- Yusaku Sako


On Jan. 23, 2015, 12:49 a.m., Jaimin Jetly wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30201/
> -----------------------------------------------------------
> 
> (Updated Jan. 23, 2015, 12:49 a.m.)
> 
> 
> Review request for Ambari, Srimanth Gunturi, Xi Wang, and Yusaku Sako.
> 
> 
> Bugs: AMBARI-9284
>     https://issues.apache.org/jira/browse/AMBARI-9284
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Apart from integrating FE with new descriptor API, this patch also fixes an issue where incorrect admin credentials fails "Test Kerberos" command on "Install and Test Kerberos" page and does not inform anything to the enduser.
> 
> NOTE: After integration with the New API, customization of the identities and configs does not update relevant configurations in the service sites.
> 
> 
> Diffs
> -----
> 
>   ambari-web/app/controllers/main/admin/kerberos.js 7d1cc89 
>   ambari-web/app/controllers/main/admin/kerberos/step6_controller.js 1b4e726 
>   ambari-web/app/mixins/wizard/addSecurityConfigs.js 87fa2b6 
>   ambari-web/app/routes/add_kerberos_routes.js 90ce279 
>   ambari-web/app/utils/ajax/ajax.js 1f343dc 
>   ambari-web/test/mixins/wizard/addSeccurityConfigs_test.js dcdd1d8 
>   ambari-web/test/mock_data_setup/stack_descriptors.js 989d728 
> 
> Diff: https://reviews.apache.org/r/30201/diff/
> 
> 
> Testing
> -------
> 
> manually tested.
> 
> **ambari-web unit test result with the patch:**
> 
>   5251 tests complete (8 seconds)
>   63 tests pending
> 
> 
> Thanks,
> 
> Jaimin Jetly
> 
>