You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2021/03/01 03:15:58 UTC
[GitHub] [pulsar] saosir opened a new pull request #9134: Fix UnAckedMessageTracker timeout send redelivery messages
saosir opened a new pull request #9134:
URL: https://github.com/apache/pulsar/pull/9134
### Motivation
pulsar client `UnAckedMessageTracker` wait one more `tickDurationInMs` to send redelivery message at timeout
### Modifications
Fix the formula for calculating the size of `timePartitions` through the parameters `ackTimeoutMillis` and `tickDurationInMs`
### Does this pull request potentially affect one of the following parts:
*If `yes` was chosen, please highlight the changes*
- Dependencies (does it add or upgrade a dependency): (no)
- The public API: (no)
- The schema: (no)
- The default values of configurations: (no)
- The wire protocol: (no)
- The rest endpoints: (no)
- The admin cli options: (no)
- Anything that affects deployment: (no)
### Documentation
- Does this pull request introduce a new feature? (no)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] saosir removed a comment on pull request #9134: Fix UnAckedMessageTracker timeout send redelivery messages
Posted by GitBox <gi...@apache.org>.
saosir removed a comment on pull request #9134:
URL: https://github.com/apache/pulsar/pull/9134#issuecomment-765114853
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] saosir removed a comment on pull request #9134: Fix UnAckedMessageTracker timeout send redelivery messages
Posted by GitBox <gi...@apache.org>.
saosir removed a comment on pull request #9134:
URL: https://github.com/apache/pulsar/pull/9134#issuecomment-755854821
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] saosir removed a comment on pull request #9134: Fix UnAckedMessageTracker timeout send redelivery messages
Posted by GitBox <gi...@apache.org>.
saosir removed a comment on pull request #9134:
URL: https://github.com/apache/pulsar/pull/9134#issuecomment-771435646
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] saosir removed a comment on pull request #9134: Fix UnAckedMessageTracker timeout send redelivery messages
Posted by GitBox <gi...@apache.org>.
saosir removed a comment on pull request #9134:
URL: https://github.com/apache/pulsar/pull/9134#issuecomment-759181538
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] saosir commented on pull request #9134: Fix UnAckedMessageTracker timeout send redelivery messages
Posted by GitBox <gi...@apache.org>.
saosir commented on pull request #9134:
URL: https://github.com/apache/pulsar/pull/9134#issuecomment-755826920
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] BewareMyPower commented on pull request #9134: Fix UnAckedMessageTracker timeout send redelivery messages
Posted by GitBox <gi...@apache.org>.
BewareMyPower commented on pull request #9134:
URL: https://github.com/apache/pulsar/pull/9134#issuecomment-764626131
@saosir Maybe you can try to rebase to latest master because sometimes some flaky tests might be fixed. (I also noticed this PR's test failed for many times...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] saosir removed a comment on pull request #9134: Fix UnAckedMessageTracker timeout send redelivery messages
Posted by GitBox <gi...@apache.org>.
saosir removed a comment on pull request #9134:
URL: https://github.com/apache/pulsar/pull/9134#issuecomment-755886402
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] saosir commented on pull request #9134: Fix UnAckedMessageTracker timeout send redelivery messages
Posted by GitBox <gi...@apache.org>.
saosir commented on pull request #9134:
URL: https://github.com/apache/pulsar/pull/9134#issuecomment-758543944
I don't know why ci always failed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] saosir commented on pull request #9134: Fix UnAckedMessageTracker timeout send redelivery messages
Posted by GitBox <gi...@apache.org>.
saosir commented on pull request #9134:
URL: https://github.com/apache/pulsar/pull/9134#issuecomment-765114853
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] saosir commented on pull request #9134: Fix UnAckedMessageTracker timeout send redelivery messages
Posted by GitBox <gi...@apache.org>.
saosir commented on pull request #9134:
URL: https://github.com/apache/pulsar/pull/9134#issuecomment-766591621
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] BewareMyPower commented on pull request #9134: Fix UnAckedMessageTracker timeout send redelivery messages
Posted by GitBox <gi...@apache.org>.
BewareMyPower commented on pull request #9134:
URL: https://github.com/apache/pulsar/pull/9134#issuecomment-757116830
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] saosir commented on pull request #9134: Fix UnAckedMessageTracker timeout send redelivery messages
Posted by GitBox <gi...@apache.org>.
saosir commented on pull request #9134:
URL: https://github.com/apache/pulsar/pull/9134#issuecomment-757586421
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] saosir commented on pull request #9134: Fix UnAckedMessageTracker timeout send redelivery messages
Posted by GitBox <gi...@apache.org>.
saosir commented on pull request #9134:
URL: https://github.com/apache/pulsar/pull/9134#issuecomment-758623563
> What about extracting the computation to a static method and create unit tests?
> Even of it is a one line change it is not so obvious that the fix works
I don’t know why CI always fails, I give up
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] sijie commented on pull request #9134: Fix UnAckedMessageTracker timeout send redelivery messages
Posted by GitBox <gi...@apache.org>.
sijie commented on pull request #9134:
URL: https://github.com/apache/pulsar/pull/9134#issuecomment-779570448
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] saosir removed a comment on pull request #9134: Fix UnAckedMessageTracker timeout send redelivery messages
Posted by GitBox <gi...@apache.org>.
saosir removed a comment on pull request #9134:
URL: https://github.com/apache/pulsar/pull/9134#issuecomment-756605317
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] saosir commented on pull request #9134: Fix UnAckedMessageTracker timeout send redelivery messages
Posted by GitBox <gi...@apache.org>.
saosir commented on pull request #9134:
URL: https://github.com/apache/pulsar/pull/9134#issuecomment-756667527
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] saosir commented on pull request #9134: Fix UnAckedMessageTracker timeout send redelivery messages
Posted by GitBox <gi...@apache.org>.
saosir commented on pull request #9134:
URL: https://github.com/apache/pulsar/pull/9134#issuecomment-765159018
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] saosir commented on pull request #9134: Fix UnAckedMessageTracker timeout send redelivery messages
Posted by GitBox <gi...@apache.org>.
saosir commented on pull request #9134:
URL: https://github.com/apache/pulsar/pull/9134#issuecomment-765811706
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] saosir closed pull request #9134: Fix UnAckedMessageTracker timeout send redelivery messages
Posted by GitBox <gi...@apache.org>.
saosir closed pull request #9134:
URL: https://github.com/apache/pulsar/pull/9134
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] eolivelli commented on pull request #9134: Fix UnAckedMessageTracker timeout send redelivery messages
Posted by GitBox <gi...@apache.org>.
eolivelli commented on pull request #9134:
URL: https://github.com/apache/pulsar/pull/9134#issuecomment-758614401
What about extracting the computation to a static method and create unit tests?
Even of it is a one line change it is not so obvious that the fix works
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] BewareMyPower commented on pull request #9134: Fix UnAckedMessageTracker timeout send redelivery messages
Posted by GitBox <gi...@apache.org>.
BewareMyPower commented on pull request #9134:
URL: https://github.com/apache/pulsar/pull/9134#issuecomment-764626131
@saosir Maybe you can try to rebase to latest master because sometimes some flaky tests might be fixed. (I also noticed this PR's test failed for many times...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] saosir commented on pull request #9134: Fix UnAckedMessageTracker timeout send redelivery messages
Posted by GitBox <gi...@apache.org>.
saosir commented on pull request #9134:
URL: https://github.com/apache/pulsar/pull/9134#issuecomment-755886402
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] saosir commented on pull request #9134: Fix UnAckedMessageTracker timeout send redelivery messages
Posted by GitBox <gi...@apache.org>.
saosir commented on pull request #9134:
URL: https://github.com/apache/pulsar/pull/9134#issuecomment-771276702
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] saosir removed a comment on pull request #9134: Fix UnAckedMessageTracker timeout send redelivery messages
Posted by GitBox <gi...@apache.org>.
saosir removed a comment on pull request #9134:
URL: https://github.com/apache/pulsar/pull/9134#issuecomment-758603545
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] saosir commented on pull request #9134: Fix UnAckedMessageTracker timeout send redelivery messages
Posted by GitBox <gi...@apache.org>.
saosir commented on pull request #9134:
URL: https://github.com/apache/pulsar/pull/9134#issuecomment-755294343
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] saosir edited a comment on pull request #9134: Fix UnAckedMessageTracker timeout send redelivery messages
Posted by GitBox <gi...@apache.org>.
saosir edited a comment on pull request #9134:
URL: https://github.com/apache/pulsar/pull/9134#issuecomment-785554534
> @saosir Looks like the CI failed by this change. Please take a look. Thank you.
>
> I will push this to the next release.
OK, I am looking for time to fix this problem. Before I thought that modifying two lines of code would not have any impact on
test cases, but this caused some cases to fail.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] saosir commented on pull request #9134: Fix UnAckedMessageTracker timeout send redelivery messages
Posted by GitBox <gi...@apache.org>.
saosir commented on pull request #9134:
URL: https://github.com/apache/pulsar/pull/9134#issuecomment-770546156
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] saosir commented on pull request #9134: Fix UnAckedMessageTracker timeout send redelivery messages
Posted by GitBox <gi...@apache.org>.
saosir commented on pull request #9134:
URL: https://github.com/apache/pulsar/pull/9134#issuecomment-755117919
see https://github.com/apache/pulsar/pull/9072#issuecomment-754681663
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] saosir removed a comment on pull request #9134: Fix UnAckedMessageTracker timeout send redelivery messages
Posted by GitBox <gi...@apache.org>.
saosir removed a comment on pull request #9134:
URL: https://github.com/apache/pulsar/pull/9134#issuecomment-771435646
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] saosir removed a comment on pull request #9134: Fix UnAckedMessageTracker timeout send redelivery messages
Posted by GitBox <gi...@apache.org>.
saosir removed a comment on pull request #9134:
URL: https://github.com/apache/pulsar/pull/9134#issuecomment-759247002
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] saosir removed a comment on pull request #9134: Fix UnAckedMessageTracker timeout send redelivery messages
Posted by GitBox <gi...@apache.org>.
saosir removed a comment on pull request #9134:
URL: https://github.com/apache/pulsar/pull/9134#issuecomment-765188991
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] saosir commented on pull request #9134: Fix UnAckedMessageTracker timeout send redelivery messages
Posted by GitBox <gi...@apache.org>.
saosir commented on pull request #9134:
URL: https://github.com/apache/pulsar/pull/9134#issuecomment-759247002
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] saosir commented on pull request #9134: Fix UnAckedMessageTracker timeout send redelivery messages
Posted by GitBox <gi...@apache.org>.
saosir commented on pull request #9134:
URL: https://github.com/apache/pulsar/pull/9134#issuecomment-773765674
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] saosir removed a comment on pull request #9134: Fix UnAckedMessageTracker timeout send redelivery messages
Posted by GitBox <gi...@apache.org>.
saosir removed a comment on pull request #9134:
URL: https://github.com/apache/pulsar/pull/9134#issuecomment-757586421
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] saosir removed a comment on pull request #9134: Fix UnAckedMessageTracker timeout send redelivery messages
Posted by GitBox <gi...@apache.org>.
saosir removed a comment on pull request #9134:
URL: https://github.com/apache/pulsar/pull/9134#issuecomment-758537262
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] saosir commented on pull request #9134: Fix UnAckedMessageTracker timeout send redelivery messages
Posted by GitBox <gi...@apache.org>.
saosir commented on pull request #9134:
URL: https://github.com/apache/pulsar/pull/9134#issuecomment-786384591
```
2021-02-24T18:23:32.2405598Z [ERROR] testBatchReceiveAndRedeliveryNonPartitionedTopic(org.apache.pulsar.client.api.ConsumerBatchReceiveTest) Time elapsed: 3.495 s <<< FAILURE!
2021-02-24T18:23:32.2413924Z java.lang.AssertionError: expected [202] but found [200]
```
`BatchReceivePolicy` may cause send more redelivary ack in `UnAckedMessageTracker`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] saosir commented on pull request #9134: Fix UnAckedMessageTracker timeout send redelivery messages
Posted by GitBox <gi...@apache.org>.
saosir commented on pull request #9134:
URL: https://github.com/apache/pulsar/pull/9134#issuecomment-765176056
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] saosir commented on pull request #9134: Fix UnAckedMessageTracker timeout send redelivery messages
Posted by GitBox <gi...@apache.org>.
saosir commented on pull request #9134:
URL: https://github.com/apache/pulsar/pull/9134#issuecomment-758331581
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] saosir removed a comment on pull request #9134: Fix UnAckedMessageTracker timeout send redelivery messages
Posted by GitBox <gi...@apache.org>.
saosir removed a comment on pull request #9134:
URL: https://github.com/apache/pulsar/pull/9134#issuecomment-759146714
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] saosir removed a comment on pull request #9134: Fix UnAckedMessageTracker timeout send redelivery messages
Posted by GitBox <gi...@apache.org>.
saosir removed a comment on pull request #9134:
URL: https://github.com/apache/pulsar/pull/9134#issuecomment-762072721
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] saosir commented on pull request #9134: Fix UnAckedMessageTracker timeout send redelivery messages
Posted by GitBox <gi...@apache.org>.
saosir commented on pull request #9134:
URL: https://github.com/apache/pulsar/pull/9134#issuecomment-763454432
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] BewareMyPower commented on pull request #9134: Fix UnAckedMessageTracker timeout send redelivery messages
Posted by GitBox <gi...@apache.org>.
BewareMyPower commented on pull request #9134:
URL: https://github.com/apache/pulsar/pull/9134#issuecomment-757116830
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] saosir commented on pull request #9134: Fix UnAckedMessageTracker timeout send redelivery messages
Posted by GitBox <gi...@apache.org>.
saosir commented on pull request #9134:
URL: https://github.com/apache/pulsar/pull/9134#issuecomment-763259079
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] saosir commented on pull request #9134: Fix UnAckedMessageTracker timeout send redelivery messages
Posted by GitBox <gi...@apache.org>.
saosir commented on pull request #9134:
URL: https://github.com/apache/pulsar/pull/9134#issuecomment-765264185
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] saosir commented on pull request #9134: Fix UnAckedMessageTracker timeout send redelivery messages
Posted by GitBox <gi...@apache.org>.
saosir commented on pull request #9134:
URL: https://github.com/apache/pulsar/pull/9134#issuecomment-758603545
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] saosir commented on pull request #9134: Fix UnAckedMessageTracker timeout send redelivery messages
Posted by GitBox <gi...@apache.org>.
saosir commented on pull request #9134:
URL: https://github.com/apache/pulsar/pull/9134#issuecomment-755909127
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] saosir removed a comment on pull request #9134: Fix UnAckedMessageTracker timeout send redelivery messages
Posted by GitBox <gi...@apache.org>.
saosir removed a comment on pull request #9134:
URL: https://github.com/apache/pulsar/pull/9134#issuecomment-758331581
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] saosir commented on pull request #9134: Fix UnAckedMessageTracker timeout send redelivery messages
Posted by GitBox <gi...@apache.org>.
saosir commented on pull request #9134:
URL: https://github.com/apache/pulsar/pull/9134#issuecomment-764570977
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] saosir removed a comment on pull request #9134: Fix UnAckedMessageTracker timeout send redelivery messages
Posted by GitBox <gi...@apache.org>.
saosir removed a comment on pull request #9134:
URL: https://github.com/apache/pulsar/pull/9134#issuecomment-755294343
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] zymap commented on pull request #9134: Fix UnAckedMessageTracker timeout send redelivery messages
Posted by GitBox <gi...@apache.org>.
zymap commented on pull request #9134:
URL: https://github.com/apache/pulsar/pull/9134#issuecomment-785063283
Failure tests
```
[INFO]
Error: Failures:
Error: org.apache.pulsar.client.impl.PerMessageUnAcknowledgedRedeliveryTest.testSharedAckedNormalTopic(org.apache.pulsar.client.impl.PerMessageUnAcknowledgedRedeliveryTest)
[INFO] Run 1: PASS
Error: Run 2: PerMessageUnAcknowledgedRedeliveryTest.testSharedAckedNormalTopic:148 expected [5] but found [10]
[INFO]
Error: org.apache.pulsar.client.impl.PerMessageUnAcknowledgedRedeliveryTest.testSharedAckedPartitionedTopic(org.apache.pulsar.client.impl.PerMessageUnAcknowledgedRedeliveryTest)
[INFO] Run 1: PASS
Error: Run 2: PerMessageUnAcknowledgedRedeliveryTest.testSharedAckedPartitionedTopic:494 expected [5] but found [10]
[INFO]
[INFO]
Error: Tests run: 229, Failures: 2, Errors: 0, Skipped: 0
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] saosir commented on pull request #9134: Fix UnAckedMessageTracker timeout send redelivery messages
Posted by GitBox <gi...@apache.org>.
saosir commented on pull request #9134:
URL: https://github.com/apache/pulsar/pull/9134#issuecomment-758537262
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] saosir commented on pull request #9134: Fix UnAckedMessageTracker timeout send redelivery messages
Posted by GitBox <gi...@apache.org>.
saosir commented on pull request #9134:
URL: https://github.com/apache/pulsar/pull/9134#issuecomment-782585803
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] saosir removed a comment on pull request #9134: Fix UnAckedMessageTracker timeout send redelivery messages
Posted by GitBox <gi...@apache.org>.
saosir removed a comment on pull request #9134:
URL: https://github.com/apache/pulsar/pull/9134#issuecomment-765176056
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] saosir removed a comment on pull request #9134: Fix UnAckedMessageTracker timeout send redelivery messages
Posted by GitBox <gi...@apache.org>.
saosir removed a comment on pull request #9134:
URL: https://github.com/apache/pulsar/pull/9134#issuecomment-763454432
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] saosir removed a comment on pull request #9134: Fix UnAckedMessageTracker timeout send redelivery messages
Posted by GitBox <gi...@apache.org>.
saosir removed a comment on pull request #9134:
URL: https://github.com/apache/pulsar/pull/9134#issuecomment-758623563
> What about extracting the computation to a static method and create unit tests?
> Even of it is a one line change it is not so obvious that the fix works
I don’t know why CI always fails, I give up
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] saosir commented on pull request #9134: Fix UnAckedMessageTracker timeout send redelivery messages
Posted by GitBox <gi...@apache.org>.
saosir commented on pull request #9134:
URL: https://github.com/apache/pulsar/pull/9134#issuecomment-755163912
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] saosir commented on pull request #9134: Fix UnAckedMessageTracker timeout send redelivery messages
Posted by GitBox <gi...@apache.org>.
saosir commented on pull request #9134:
URL: https://github.com/apache/pulsar/pull/9134#issuecomment-758426162
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] BewareMyPower commented on pull request #9134: Fix UnAckedMessageTracker timeout send redelivery messages
Posted by GitBox <gi...@apache.org>.
BewareMyPower commented on pull request #9134:
URL: https://github.com/apache/pulsar/pull/9134#issuecomment-766036227
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] saosir removed a comment on pull request #9134: Fix UnAckedMessageTracker timeout send redelivery messages
Posted by GitBox <gi...@apache.org>.
saosir removed a comment on pull request #9134:
URL: https://github.com/apache/pulsar/pull/9134#issuecomment-762544238
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] saosir removed a comment on pull request #9134: Fix UnAckedMessageTracker timeout send redelivery messages
Posted by GitBox <gi...@apache.org>.
saosir removed a comment on pull request #9134:
URL: https://github.com/apache/pulsar/pull/9134#issuecomment-755945189
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] saosir commented on pull request #9134: Fix UnAckedMessageTracker timeout send redelivery messages
Posted by GitBox <gi...@apache.org>.
saosir commented on pull request #9134:
URL: https://github.com/apache/pulsar/pull/9134#issuecomment-785554534
> @saosir Looks like the CI failed by this change. Please take a look. Thank you.
>
> I will push this to the next release.
OK, I am looking for time to fix this problem. Before I thought that modifying two lines of code would not have any impact on
test cases, but this caused some cases to fail.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] sijie commented on pull request #9134: Fix UnAckedMessageTracker timeout send redelivery messages
Posted by GitBox <gi...@apache.org>.
sijie commented on pull request #9134:
URL: https://github.com/apache/pulsar/pull/9134#issuecomment-775765073
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] saosir removed a comment on pull request #9134: Fix UnAckedMessageTracker timeout send redelivery messages
Posted by GitBox <gi...@apache.org>.
saosir removed a comment on pull request #9134:
URL: https://github.com/apache/pulsar/pull/9134#issuecomment-765159018
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] sijie commented on pull request #9134: Fix UnAckedMessageTracker timeout send redelivery messages
Posted by GitBox <gi...@apache.org>.
sijie commented on pull request #9134:
URL: https://github.com/apache/pulsar/pull/9134#issuecomment-755227509
@saosir Can you rebase to the latest master? There are recent changes to fix the broken master.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] saosir removed a comment on pull request #9134: Fix UnAckedMessageTracker timeout send redelivery messages
Posted by GitBox <gi...@apache.org>.
saosir removed a comment on pull request #9134:
URL: https://github.com/apache/pulsar/pull/9134#issuecomment-755163912
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] saosir commented on pull request #9134: Fix UnAckedMessageTracker timeout send redelivery messages
Posted by GitBox <gi...@apache.org>.
saosir commented on pull request #9134:
URL: https://github.com/apache/pulsar/pull/9134#issuecomment-756076781
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] sijie commented on pull request #9134: Fix UnAckedMessageTracker timeout send redelivery messages
Posted by GitBox <gi...@apache.org>.
sijie commented on pull request #9134:
URL: https://github.com/apache/pulsar/pull/9134#issuecomment-777188940
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] zymap commented on pull request #9134: Fix UnAckedMessageTracker timeout send redelivery messages
Posted by GitBox <gi...@apache.org>.
zymap commented on pull request #9134:
URL: https://github.com/apache/pulsar/pull/9134#issuecomment-784191190
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] saosir commented on pull request #9134: Fix UnAckedMessageTracker timeout send redelivery messages
Posted by GitBox <gi...@apache.org>.
saosir commented on pull request #9134:
URL: https://github.com/apache/pulsar/pull/9134#issuecomment-766484231
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] saosir commented on pull request #9134: Fix UnAckedMessageTracker timeout send redelivery messages
Posted by GitBox <gi...@apache.org>.
saosir commented on pull request #9134:
URL: https://github.com/apache/pulsar/pull/9134#issuecomment-755854821
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] saosir commented on pull request #9134: Fix UnAckedMessageTracker timeout send redelivery messages
Posted by GitBox <gi...@apache.org>.
saosir commented on pull request #9134:
URL: https://github.com/apache/pulsar/pull/9134#issuecomment-768232996
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] saosir commented on pull request #9134: Fix UnAckedMessageTracker timeout send redelivery messages
Posted by GitBox <gi...@apache.org>.
saosir commented on pull request #9134:
URL: https://github.com/apache/pulsar/pull/9134#issuecomment-773765674
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] saosir removed a comment on pull request #9134: Fix UnAckedMessageTracker timeout send redelivery messages
Posted by GitBox <gi...@apache.org>.
saosir removed a comment on pull request #9134:
URL: https://github.com/apache/pulsar/pull/9134#issuecomment-759187575
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] saosir commented on pull request #9134: Fix UnAckedMessageTracker timeout send redelivery messages
Posted by GitBox <gi...@apache.org>.
saosir commented on pull request #9134:
URL: https://github.com/apache/pulsar/pull/9134#issuecomment-759146714
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] saosir commented on pull request #9134: Fix UnAckedMessageTracker timeout send redelivery messages
Posted by GitBox <gi...@apache.org>.
saosir commented on pull request #9134:
URL: https://github.com/apache/pulsar/pull/9134#issuecomment-764623191
Why the CI always fail? @BewareMyPower
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] zymap commented on pull request #9134: Fix UnAckedMessageTracker timeout send redelivery messages
Posted by GitBox <gi...@apache.org>.
zymap commented on pull request #9134:
URL: https://github.com/apache/pulsar/pull/9134#issuecomment-785515801
@saosir Looks like the CI failed by this change. Please take a look. Thank you.
I will push this to the next release.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] saosir commented on pull request #9134: Fix UnAckedMessageTracker timeout send redelivery messages
Posted by GitBox <gi...@apache.org>.
saosir commented on pull request #9134:
URL: https://github.com/apache/pulsar/pull/9134#issuecomment-759314293
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] saosir removed a comment on pull request #9134: Fix UnAckedMessageTracker timeout send redelivery messages
Posted by GitBox <gi...@apache.org>.
saosir removed a comment on pull request #9134:
URL: https://github.com/apache/pulsar/pull/9134#issuecomment-765264185
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] saosir removed a comment on pull request #9134: Fix UnAckedMessageTracker timeout send redelivery messages
Posted by GitBox <gi...@apache.org>.
saosir removed a comment on pull request #9134:
URL: https://github.com/apache/pulsar/pull/9134#issuecomment-756076781
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] saosir removed a comment on pull request #9134: Fix UnAckedMessageTracker timeout send redelivery messages
Posted by GitBox <gi...@apache.org>.
saosir removed a comment on pull request #9134:
URL: https://github.com/apache/pulsar/pull/9134#issuecomment-762544238
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] saosir commented on pull request #9134: Fix UnAckedMessageTracker timeout send redelivery messages
Posted by GitBox <gi...@apache.org>.
saosir commented on pull request #9134:
URL: https://github.com/apache/pulsar/pull/9134#issuecomment-785856879
look #3118
@codelipenghui pulsar client UnAckedMessageTracker wait one more `tickDurationInMs` to send redelivery message at timeout. Is it expected？The test case is also designed like this.
https://github.com/apache/pulsar/blob/796c0111c9e1c745061cf5f23cf538a1f8987b56/pulsar-broker/src/test/java/org/apache/pulsar/client/impl/PerMessageUnAcknowledgedRedeliveryTest.java#L480-L497
How about just close this pull request?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] saosir removed a comment on pull request #9134: Fix UnAckedMessageTracker timeout send redelivery messages
Posted by GitBox <gi...@apache.org>.
saosir removed a comment on pull request #9134:
URL: https://github.com/apache/pulsar/pull/9134#issuecomment-766484231
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] saosir removed a comment on pull request #9134: Fix UnAckedMessageTracker timeout send redelivery messages
Posted by GitBox <gi...@apache.org>.
saosir removed a comment on pull request #9134:
URL: https://github.com/apache/pulsar/pull/9134#issuecomment-759956280
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] saosir removed a comment on pull request #9134: Fix UnAckedMessageTracker timeout send redelivery messages
Posted by GitBox <gi...@apache.org>.
saosir removed a comment on pull request #9134:
URL: https://github.com/apache/pulsar/pull/9134#issuecomment-774808767
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] saosir commented on pull request #9134: Fix UnAckedMessageTracker timeout send redelivery messages
Posted by GitBox <gi...@apache.org>.
saosir commented on pull request #9134:
URL: https://github.com/apache/pulsar/pull/9134#issuecomment-766484231
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] saosir removed a comment on pull request #9134: Fix UnAckedMessageTracker timeout send redelivery messages
Posted by GitBox <gi...@apache.org>.
saosir removed a comment on pull request #9134:
URL: https://github.com/apache/pulsar/pull/9134#issuecomment-761922915
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] saosir commented on pull request #9134: Fix UnAckedMessageTracker timeout send redelivery messages
Posted by GitBox <gi...@apache.org>.
saosir commented on pull request #9134:
URL: https://github.com/apache/pulsar/pull/9134#issuecomment-758583476
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] saosir removed a comment on pull request #9134: Fix UnAckedMessageTracker timeout send redelivery messages
Posted by GitBox <gi...@apache.org>.
saosir removed a comment on pull request #9134:
URL: https://github.com/apache/pulsar/pull/9134#issuecomment-763259079
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] saosir removed a comment on pull request #9134: Fix UnAckedMessageTracker timeout send redelivery messages
Posted by GitBox <gi...@apache.org>.
saosir removed a comment on pull request #9134:
URL: https://github.com/apache/pulsar/pull/9134#issuecomment-762691326
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] saosir commented on pull request #9134: Fix UnAckedMessageTracker timeout send redelivery messages
Posted by GitBox <gi...@apache.org>.
saosir commented on pull request #9134:
URL: https://github.com/apache/pulsar/pull/9134#issuecomment-762691326
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] sijie commented on pull request #9134: Fix UnAckedMessageTracker timeout send redelivery messages
Posted by GitBox <gi...@apache.org>.
sijie commented on pull request #9134:
URL: https://github.com/apache/pulsar/pull/9134#issuecomment-755108354
@BewareMyPower Can you review this pull request?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] saosir commented on pull request #9134: Fix UnAckedMessageTracker timeout send redelivery messages
Posted by GitBox <gi...@apache.org>.
saosir commented on pull request #9134:
URL: https://github.com/apache/pulsar/pull/9134#issuecomment-774808767
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] saosir removed a comment on pull request #9134: Fix UnAckedMessageTracker timeout send redelivery messages
Posted by GitBox <gi...@apache.org>.
saosir removed a comment on pull request #9134:
URL: https://github.com/apache/pulsar/pull/9134#issuecomment-755909127
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] saosir commented on pull request #9134: Fix UnAckedMessageTracker timeout send redelivery messages
Posted by GitBox <gi...@apache.org>.
saosir commented on pull request #9134:
URL: https://github.com/apache/pulsar/pull/9134#issuecomment-771435646
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] saosir commented on pull request #9134: Fix UnAckedMessageTracker timeout send redelivery messages
Posted by GitBox <gi...@apache.org>.
saosir commented on pull request #9134:
URL: https://github.com/apache/pulsar/pull/9134#issuecomment-772136741
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] saosir commented on pull request #9134: Fix UnAckedMessageTracker timeout send redelivery messages
Posted by GitBox <gi...@apache.org>.
saosir commented on pull request #9134:
URL: https://github.com/apache/pulsar/pull/9134#issuecomment-784670997
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] saosir removed a comment on pull request #9134: Fix UnAckedMessageTracker timeout send redelivery messages
Posted by GitBox <gi...@apache.org>.
saosir removed a comment on pull request #9134:
URL: https://github.com/apache/pulsar/pull/9134#issuecomment-770606053
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] saosir removed a comment on pull request #9134: Fix UnAckedMessageTracker timeout send redelivery messages
Posted by GitBox <gi...@apache.org>.
saosir removed a comment on pull request #9134:
URL: https://github.com/apache/pulsar/pull/9134#issuecomment-786384591
```
2021-02-24T18:23:32.2405598Z [ERROR] testBatchReceiveAndRedeliveryNonPartitionedTopic(org.apache.pulsar.client.api.ConsumerBatchReceiveTest) Time elapsed: 3.495 s <<< FAILURE!
2021-02-24T18:23:32.2413924Z java.lang.AssertionError: expected [202] but found [200]
```
`BatchReceivePolicy.timeout` will pending message in `UnAckedMessageTracker`, it may cause send more redelivery ack
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] saosir edited a comment on pull request #9134: Fix UnAckedMessageTracker timeout send redelivery messages
Posted by GitBox <gi...@apache.org>.
saosir edited a comment on pull request #9134:
URL: https://github.com/apache/pulsar/pull/9134#issuecomment-786384591
```
2021-02-24T18:23:32.2405598Z [ERROR] testBatchReceiveAndRedeliveryNonPartitionedTopic(org.apache.pulsar.client.api.ConsumerBatchReceiveTest) Time elapsed: 3.495 s <<< FAILURE!
2021-02-24T18:23:32.2413924Z java.lang.AssertionError: expected [202] but found [200]
```
`BatchReceivePolicy.timeout` will pending message in `UnAckedMessageTracker`, it may cause send more redelivery ack
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] saosir commented on pull request #9134: Fix UnAckedMessageTracker timeout send redelivery messages
Posted by GitBox <gi...@apache.org>.
saosir commented on pull request #9134:
URL: https://github.com/apache/pulsar/pull/9134#issuecomment-755869675
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] saosir removed a comment on pull request #9134: Fix UnAckedMessageTracker timeout send redelivery messages
Posted by GitBox <gi...@apache.org>.
saosir removed a comment on pull request #9134:
URL: https://github.com/apache/pulsar/pull/9134#issuecomment-756605317
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] saosir edited a comment on pull request #9134: Fix UnAckedMessageTracker timeout send redelivery messages
Posted by GitBox <gi...@apache.org>.
saosir edited a comment on pull request #9134:
URL: https://github.com/apache/pulsar/pull/9134#issuecomment-785856879
see #3118
@codelipenghui pulsar client UnAckedMessageTracker wait one more `tickDurationInMs` to send redelivery message at timeout. Is it expected？The test case is also designed like this.
https://github.com/apache/pulsar/blob/796c0111c9e1c745061cf5f23cf538a1f8987b56/pulsar-broker/src/test/java/org/apache/pulsar/client/impl/PerMessageUnAcknowledgedRedeliveryTest.java#L480-L497
How about just close this pull request?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] saosir removed a comment on pull request #9134: Fix UnAckedMessageTracker timeout send redelivery messages
Posted by GitBox <gi...@apache.org>.
saosir removed a comment on pull request #9134:
URL: https://github.com/apache/pulsar/pull/9134#issuecomment-782585803
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] saosir removed a comment on pull request #9134: Fix UnAckedMessageTracker timeout send redelivery messages
Posted by GitBox <gi...@apache.org>.
saosir removed a comment on pull request #9134:
URL: https://github.com/apache/pulsar/pull/9134#issuecomment-755826920
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] saosir commented on pull request #9134: Fix UnAckedMessageTracker timeout send redelivery messages
Posted by GitBox <gi...@apache.org>.
saosir commented on pull request #9134:
URL: https://github.com/apache/pulsar/pull/9134#issuecomment-759181538
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] saosir commented on pull request #9134: Fix UnAckedMessageTracker timeout send redelivery messages
Posted by GitBox <gi...@apache.org>.
saosir commented on pull request #9134:
URL: https://github.com/apache/pulsar/pull/9134#issuecomment-756700517
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] saosir commented on pull request #9134: Fix UnAckedMessageTracker timeout send redelivery messages
Posted by GitBox <gi...@apache.org>.
saosir commented on pull request #9134:
URL: https://github.com/apache/pulsar/pull/9134#issuecomment-765188991
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] BewareMyPower commented on pull request #9134: Fix UnAckedMessageTracker timeout send redelivery messages
Posted by GitBox <gi...@apache.org>.
BewareMyPower commented on pull request #9134:
URL: https://github.com/apache/pulsar/pull/9134#issuecomment-756155942
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] saosir commented on pull request #9134: Fix UnAckedMessageTracker timeout send redelivery messages
Posted by GitBox <gi...@apache.org>.
saosir commented on pull request #9134:
URL: https://github.com/apache/pulsar/pull/9134#issuecomment-756605317
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] saosir commented on pull request #9134: Fix UnAckedMessageTracker timeout send redelivery messages
Posted by GitBox <gi...@apache.org>.
saosir commented on pull request #9134:
URL: https://github.com/apache/pulsar/pull/9134#issuecomment-758459229
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] saosir commented on pull request #9134: Fix UnAckedMessageTracker timeout send redelivery messages
Posted by GitBox <gi...@apache.org>.
saosir commented on pull request #9134:
URL: https://github.com/apache/pulsar/pull/9134#issuecomment-762072721
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] saosir commented on pull request #9134: Fix UnAckedMessageTracker timeout send redelivery messages
Posted by GitBox <gi...@apache.org>.
saosir commented on pull request #9134:
URL: https://github.com/apache/pulsar/pull/9134#issuecomment-758383167
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] saosir removed a comment on pull request #9134: Fix UnAckedMessageTracker timeout send redelivery messages
Posted by GitBox <gi...@apache.org>.
saosir removed a comment on pull request #9134:
URL: https://github.com/apache/pulsar/pull/9134#issuecomment-756667527
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] saosir commented on pull request #9134: Fix UnAckedMessageTracker timeout send redelivery messages
Posted by GitBox <gi...@apache.org>.
saosir commented on pull request #9134:
URL: https://github.com/apache/pulsar/pull/9134#issuecomment-758368314
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] saosir commented on pull request #9134: Fix UnAckedMessageTracker timeout send redelivery messages
Posted by GitBox <gi...@apache.org>.
saosir commented on pull request #9134:
URL: https://github.com/apache/pulsar/pull/9134#issuecomment-759956280
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] saosir commented on pull request #9134: Fix UnAckedMessageTracker timeout send redelivery messages
Posted by GitBox <gi...@apache.org>.
saosir commented on pull request #9134:
URL: https://github.com/apache/pulsar/pull/9134#issuecomment-761922915
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] saosir commented on pull request #9134: Fix UnAckedMessageTracker timeout send redelivery messages
Posted by GitBox <gi...@apache.org>.
saosir commented on pull request #9134:
URL: https://github.com/apache/pulsar/pull/9134#issuecomment-762544238
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] saosir commented on pull request #9134: Fix UnAckedMessageTracker timeout send redelivery messages
Posted by GitBox <gi...@apache.org>.
saosir commented on pull request #9134:
URL: https://github.com/apache/pulsar/pull/9134#issuecomment-770606053
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] saosir removed a comment on pull request #9134: Fix UnAckedMessageTracker timeout send redelivery messages
Posted by GitBox <gi...@apache.org>.
saosir removed a comment on pull request #9134:
URL: https://github.com/apache/pulsar/pull/9134#issuecomment-758383167
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] saosir commented on pull request #9134: Fix UnAckedMessageTracker timeout send redelivery messages
Posted by GitBox <gi...@apache.org>.
saosir commented on pull request #9134:
URL: https://github.com/apache/pulsar/pull/9134#issuecomment-756667527
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] saosir commented on pull request #9134: Fix UnAckedMessageTracker timeout send redelivery messages
Posted by GitBox <gi...@apache.org>.
saosir commented on pull request #9134:
URL: https://github.com/apache/pulsar/pull/9134#issuecomment-759187575
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] saosir removed a comment on pull request #9134: Fix UnAckedMessageTracker timeout send redelivery messages
Posted by GitBox <gi...@apache.org>.
saosir removed a comment on pull request #9134:
URL: https://github.com/apache/pulsar/pull/9134#issuecomment-755869675
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] saosir closed pull request #9134: Fix UnAckedMessageTracker timeout send redelivery messages
Posted by GitBox <gi...@apache.org>.
saosir closed pull request #9134:
URL: https://github.com/apache/pulsar/pull/9134
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] saosir commented on pull request #9134: Fix UnAckedMessageTracker timeout send redelivery messages
Posted by GitBox <gi...@apache.org>.
saosir commented on pull request #9134:
URL: https://github.com/apache/pulsar/pull/9134#issuecomment-755945189
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] saosir commented on pull request #9134: Fix UnAckedMessageTracker timeout send redelivery messages
Posted by GitBox <gi...@apache.org>.
saosir commented on pull request #9134:
URL: https://github.com/apache/pulsar/pull/9134#issuecomment-758524382
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] saosir removed a comment on pull request #9134: Fix UnAckedMessageTracker timeout send redelivery messages
Posted by GitBox <gi...@apache.org>.
saosir removed a comment on pull request #9134:
URL: https://github.com/apache/pulsar/pull/9134#issuecomment-758583476
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] saosir commented on pull request #9134: Fix UnAckedMessageTracker timeout send redelivery messages
Posted by GitBox <gi...@apache.org>.
saosir commented on pull request #9134:
URL: https://github.com/apache/pulsar/pull/9134#issuecomment-771276702
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] saosir removed a comment on pull request #9134: Fix UnAckedMessageTracker timeout send redelivery messages
Posted by GitBox <gi...@apache.org>.
saosir removed a comment on pull request #9134:
URL: https://github.com/apache/pulsar/pull/9134#issuecomment-766484231
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] saosir commented on pull request #9134: Fix UnAckedMessageTracker timeout send redelivery messages
Posted by GitBox <gi...@apache.org>.
saosir commented on pull request #9134:
URL: https://github.com/apache/pulsar/pull/9134#issuecomment-764570977
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org