You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Tamas Mate (Code Review)" <ge...@cloudera.org> on 2023/06/20 14:04:02 UTC

[Impala-ASF-CR] IMPALA-11949: Make backend AVRO CPP library available

Tamas Mate has uploaded this change for review. ( http://gerrit.cloudera.org:8080/20097


Change subject: IMPALA-11949: Make backend AVRO CPP library available
......................................................................

IMPALA-11949: Make backend AVRO CPP library available

The C++ library has been added earlier to the toolchain.

This is a small commit to allow downloading the C++ Avro library with
the toolchain and starting a build with it. Its aim is to help
transitioning from C to C++ library and eventually should be removed.

Testing:
 - Manualy tested switching and downloading the package

Change-Id: I397341db1ea7195db3649f5220a3ffe8a3919681
---
M bin/impala-config.sh
1 file changed, 9 insertions(+), 1 deletion(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/97/20097/1
-- 
To view, visit http://gerrit.cloudera.org:8080/20097
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I397341db1ea7195db3649f5220a3ffe8a3919681
Gerrit-Change-Number: 20097
Gerrit-PatchSet: 1
Gerrit-Owner: Tamas Mate <tm...@apache.org>

[Impala-ASF-CR] IMPALA-11949: Make backend AVRO C++ library available

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20097 )

Change subject: IMPALA-11949: Make backend AVRO C++ library available
......................................................................


Patch Set 1:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/13335/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/20097
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I397341db1ea7195db3649f5220a3ffe8a3919681
Gerrit-Change-Number: 20097
Gerrit-PatchSet: 1
Gerrit-Owner: Tamas Mate <tm...@apache.org>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Noemi Pap-Takacs <np...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Tue, 20 Jun 2023 14:26:46 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11949: Make backend AVRO C++ library available

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20097 )

Change subject: IMPALA-11949: Make backend AVRO C++ library available
......................................................................


Patch Set 3:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/13356/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/20097
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I397341db1ea7195db3649f5220a3ffe8a3919681
Gerrit-Change-Number: 20097
Gerrit-PatchSet: 3
Gerrit-Owner: Tamas Mate <tm...@apache.org>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Noemi Pap-Takacs <np...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@apache.org>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Wed, 21 Jun 2023 10:06:54 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11949: Make backend AVRO C++ library available

Posted by "Tamas Mate (Code Review)" <ge...@cloudera.org>.
Hello Gabor Kaszab, Zoltan Borok-Nagy, Noemi Pap-Takacs, Impala Public Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/20097

to look at the new patch set (#3).

Change subject: IMPALA-11949: Make backend AVRO C++ library available
......................................................................

IMPALA-11949: Make backend AVRO C++ library available

The C++ library has been added earlier to the toolchain.

This is a small commit to allow downloading the C++ Avro library with
the toolchain and starting a build with it. Its aim is to help
transitioning from C to C++ library and eventually should be removed.

Testing:
 - Manualy tested switching and downloading the package

Change-Id: I397341db1ea7195db3649f5220a3ffe8a3919681
---
M bin/impala-config.sh
1 file changed, 9 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/97/20097/3
-- 
To view, visit http://gerrit.cloudera.org:8080/20097
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I397341db1ea7195db3649f5220a3ffe8a3919681
Gerrit-Change-Number: 20097
Gerrit-PatchSet: 3
Gerrit-Owner: Tamas Mate <tm...@apache.org>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Noemi Pap-Takacs <np...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>

[Impala-ASF-CR] IMPALA-11949: Make backend AVRO C++ library available

Posted by "Tamas Mate (Code Review)" <ge...@cloudera.org>.
Tamas Mate has posted comments on this change. ( http://gerrit.cloudera.org:8080/20097 )

Change subject: IMPALA-11949: Make backend AVRO C++ library available
......................................................................


Patch Set 3:

Thank you for the review, Noemi!


-- 
To view, visit http://gerrit.cloudera.org:8080/20097
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I397341db1ea7195db3649f5220a3ffe8a3919681
Gerrit-Change-Number: 20097
Gerrit-PatchSet: 3
Gerrit-Owner: Tamas Mate <tm...@apache.org>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Noemi Pap-Takacs <np...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@apache.org>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Wed, 21 Jun 2023 09:43:27 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11949: Make backend AVRO C++ library available

Posted by "Tamas Mate (Code Review)" <ge...@cloudera.org>.
Tamas Mate has posted comments on this change. ( http://gerrit.cloudera.org:8080/20097 )

Change subject: IMPALA-11949: Make backend AVRO C++ library available
......................................................................


Patch Set 2:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/20097/2/bin/impala-config.sh
File bin/impala-config.sh:

http://gerrit.cloudera.org:8080/#/c/20097/2/bin/impala-config.sh@80
PS2, Line 80: temporary
> nit: temporarily
Done



-- 
To view, visit http://gerrit.cloudera.org:8080/20097
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I397341db1ea7195db3649f5220a3ffe8a3919681
Gerrit-Change-Number: 20097
Gerrit-PatchSet: 2
Gerrit-Owner: Tamas Mate <tm...@apache.org>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Noemi Pap-Takacs <np...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@apache.org>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Wed, 21 Jun 2023 09:46:44 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-11949: Make backend AVRO C++ library available

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/20097 )

Change subject: IMPALA-11949: Make backend AVRO C++ library available
......................................................................

IMPALA-11949: Make backend AVRO C++ library available

The C++ library has been added earlier to the toolchain.

This is a small commit to allow downloading the C++ Avro library with
the toolchain and starting a build with it. Its aim is to help
transitioning from C to C++ library, once the transition is complete
this environment variable can be deprecated and removed.

Testing:
 - Manualy tested switching and downloading the package

Change-Id: I397341db1ea7195db3649f5220a3ffe8a3919681
Reviewed-on: http://gerrit.cloudera.org:8080/20097
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M bin/impala-config.sh
1 file changed, 9 insertions(+), 1 deletion(-)

Approvals:
  Impala Public Jenkins: Looks good to me, approved; Verified

-- 
To view, visit http://gerrit.cloudera.org:8080/20097
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I397341db1ea7195db3649f5220a3ffe8a3919681
Gerrit-Change-Number: 20097
Gerrit-PatchSet: 6
Gerrit-Owner: Tamas Mate <tm...@apache.org>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Noemi Pap-Takacs <np...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@apache.org>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>

[Impala-ASF-CR] IMPALA-11949: Make backend AVRO C++ library available

Posted by "Noemi Pap-Takacs (Code Review)" <ge...@cloudera.org>.
Noemi Pap-Takacs has posted comments on this change. ( http://gerrit.cloudera.org:8080/20097 )

Change subject: IMPALA-11949: Make backend AVRO C++ library available
......................................................................


Patch Set 2: Code-Review+1

(1 comment)

Thank you for the patch!

http://gerrit.cloudera.org:8080/#/c/20097/2/bin/impala-config.sh
File bin/impala-config.sh:

http://gerrit.cloudera.org:8080/#/c/20097/2/bin/impala-config.sh@80
PS2, Line 80: temporary
nit: temporarily



-- 
To view, visit http://gerrit.cloudera.org:8080/20097
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I397341db1ea7195db3649f5220a3ffe8a3919681
Gerrit-Change-Number: 20097
Gerrit-PatchSet: 2
Gerrit-Owner: Tamas Mate <tm...@apache.org>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Noemi Pap-Takacs <np...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Wed, 21 Jun 2023 08:40:14 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-11949: Make backend AVRO C++ library available

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20097 )

Change subject: IMPALA-11949: Make backend AVRO C++ library available
......................................................................


Patch Set 2:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/13336/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/20097
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I397341db1ea7195db3649f5220a3ffe8a3919681
Gerrit-Change-Number: 20097
Gerrit-PatchSet: 2
Gerrit-Owner: Tamas Mate <tm...@apache.org>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Noemi Pap-Takacs <np...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Tue, 20 Jun 2023 14:29:35 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11949: Make backend AVRO C++ library available

Posted by "Daniel Becker (Code Review)" <ge...@cloudera.org>.
Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/20097 )

Change subject: IMPALA-11949: Make backend AVRO C++ library available
......................................................................


Patch Set 4: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/20097
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I397341db1ea7195db3649f5220a3ffe8a3919681
Gerrit-Change-Number: 20097
Gerrit-PatchSet: 4
Gerrit-Owner: Tamas Mate <tm...@apache.org>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Noemi Pap-Takacs <np...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@apache.org>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Thu, 29 Jun 2023 11:30:38 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11949: Make backend AVRO C++ library available

Posted by "Tamas Mate (Code Review)" <ge...@cloudera.org>.
Hello Impala Public Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/20097

to look at the new patch set (#2).

Change subject: IMPALA-11949: Make backend AVRO C++ library available
......................................................................

IMPALA-11949: Make backend AVRO C++ library available

The C++ library has been added earlier to the toolchain.

This is a small commit to allow downloading the C++ Avro library with
the toolchain and starting a build with it. Its aim is to help
transitioning from C to C++ library and eventually should be removed.

Testing:
 - Manualy tested switching and downloading the package

Change-Id: I397341db1ea7195db3649f5220a3ffe8a3919681
---
M bin/impala-config.sh
1 file changed, 9 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/97/20097/2
-- 
To view, visit http://gerrit.cloudera.org:8080/20097
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I397341db1ea7195db3649f5220a3ffe8a3919681
Gerrit-Change-Number: 20097
Gerrit-PatchSet: 2
Gerrit-Owner: Tamas Mate <tm...@apache.org>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>

[Impala-ASF-CR] IMPALA-11949: Make backend AVRO C++ library available

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20097 )

Change subject: IMPALA-11949: Make backend AVRO C++ library available
......................................................................


Patch Set 5: Verified+1


-- 
To view, visit http://gerrit.cloudera.org:8080/20097
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I397341db1ea7195db3649f5220a3ffe8a3919681
Gerrit-Change-Number: 20097
Gerrit-PatchSet: 5
Gerrit-Owner: Tamas Mate <tm...@apache.org>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Noemi Pap-Takacs <np...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@apache.org>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Thu, 29 Jun 2023 15:45:52 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11949: Make backend AVRO C++ library available

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20097 )

Change subject: IMPALA-11949: Make backend AVRO C++ library available
......................................................................


Patch Set 5:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/9460/ DRY_RUN=false


-- 
To view, visit http://gerrit.cloudera.org:8080/20097
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I397341db1ea7195db3649f5220a3ffe8a3919681
Gerrit-Change-Number: 20097
Gerrit-PatchSet: 5
Gerrit-Owner: Tamas Mate <tm...@apache.org>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Noemi Pap-Takacs <np...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@apache.org>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Thu, 29 Jun 2023 11:31:44 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11949: Make backend AVRO C++ library available

Posted by "Tamas Mate (Code Review)" <ge...@cloudera.org>.
Hello Daniel Becker, Gabor Kaszab, Zoltan Borok-Nagy, Noemi Pap-Takacs, Impala Public Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/20097

to look at the new patch set (#4).

Change subject: IMPALA-11949: Make backend AVRO C++ library available
......................................................................

IMPALA-11949: Make backend AVRO C++ library available

The C++ library has been added earlier to the toolchain.

This is a small commit to allow downloading the C++ Avro library with
the toolchain and starting a build with it. Its aim is to help
transitioning from C to C++ library, once the transition is complete
this environment variable can be deprecated and removed.

Testing:
 - Manualy tested switching and downloading the package

Change-Id: I397341db1ea7195db3649f5220a3ffe8a3919681
---
M bin/impala-config.sh
1 file changed, 9 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/97/20097/4
-- 
To view, visit http://gerrit.cloudera.org:8080/20097
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I397341db1ea7195db3649f5220a3ffe8a3919681
Gerrit-Change-Number: 20097
Gerrit-PatchSet: 4
Gerrit-Owner: Tamas Mate <tm...@apache.org>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Noemi Pap-Takacs <np...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@apache.org>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>

[Impala-ASF-CR] IMPALA-11949: Make backend AVRO C++ library available

Posted by "Daniel Becker (Code Review)" <ge...@cloudera.org>.
Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/20097 )

Change subject: IMPALA-11949: Make backend AVRO C++ library available
......................................................................


Patch Set 3:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/20097/3//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/20097/3//COMMIT_MSG@13
PS3, Line 13: eventually should be removed
Could you make it clearer what should eventually be removed? It was not immediately clear to me.



-- 
To view, visit http://gerrit.cloudera.org:8080/20097
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I397341db1ea7195db3649f5220a3ffe8a3919681
Gerrit-Change-Number: 20097
Gerrit-PatchSet: 3
Gerrit-Owner: Tamas Mate <tm...@apache.org>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Noemi Pap-Takacs <np...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@apache.org>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Wed, 21 Jun 2023 10:41:33 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-11949: Make backend AVRO C++ library available

Posted by "Tamas Mate (Code Review)" <ge...@cloudera.org>.
Tamas Mate has posted comments on this change. ( http://gerrit.cloudera.org:8080/20097 )

Change subject: IMPALA-11949: Make backend AVRO C++ library available
......................................................................


Patch Set 3:

(1 comment)

Thank you for the review, Daniel!

http://gerrit.cloudera.org:8080/#/c/20097/3//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/20097/3//COMMIT_MSG@13
PS3, Line 13: eventually should be removed
> Could you make it clearer what should eventually be removed? It was not imm
Done



-- 
To view, visit http://gerrit.cloudera.org:8080/20097
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I397341db1ea7195db3649f5220a3ffe8a3919681
Gerrit-Change-Number: 20097
Gerrit-PatchSet: 3
Gerrit-Owner: Tamas Mate <tm...@apache.org>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Noemi Pap-Takacs <np...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@apache.org>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Wed, 21 Jun 2023 11:37:52 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-11949: Make backend AVRO C++ library available

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20097 )

Change subject: IMPALA-11949: Make backend AVRO C++ library available
......................................................................


Patch Set 5: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/20097
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I397341db1ea7195db3649f5220a3ffe8a3919681
Gerrit-Change-Number: 20097
Gerrit-PatchSet: 5
Gerrit-Owner: Tamas Mate <tm...@apache.org>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Noemi Pap-Takacs <np...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@apache.org>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Thu, 29 Jun 2023 11:31:43 +0000
Gerrit-HasComments: No