[CLOSED][VOTE] Release Apache Airflow 1.10.10 based on 1.10.10rc4

[Kaxil Naik <ka...@gmail.com>]

The voting period has ended, the vote has passed. However, to solve the
issue with SQLA release, I have cut 1.10.10rc5 and would create an email
thread for an accelerated vote,

Regards,
Kaxil

On Thu, Apr 9, 2020 at 1:03 PM Ash Berlin-Taylor <as...@apache.org> wrote:

> https://github.com/apache/airflow/pull/8230 is the fix that we want to
> release with an accelerated vote for 1.10.10rc5.
>
> -ash
>
> On Apr 9 2020, at 12:54 pm, Ash Berlin-Taylor <as...@apache.org> wrote:
>
> > +1 binding.
> >
> > Tested with Python 3.7, postgres 12 and celery worker.
> >
> > Checked version in archives.
> > Checked keys and signatures.
> >
> > Tested RBAC and non RBAC UI (fix needed for non RBAC, see Kaxil's
> > earlier message)
> >
> > -ash
> >
> >> On Apr 9 2020, at 8:10 am, Jarek Potiuk <Ja...@polidea.com>
> wrote:
> >
> >> +1 (binding) Tested python 3.6 + postgres, 2.7 + mysql. Rat check:
> >> jarek:~/Downloads/apache-airflow-1.10.10rc4] 12m17s 130 $ java -jar
> >> ../apache-rat-0.13/apache-rat-0.13.jar -E .rat-excludes --dir .
> >> Ignored 13 lines in your exclusion files as comments or empty lines.
> >> ***************************************************** Summary -------
> >> Generated at: 2020-04-09T09:09:08+02:00 Notes: 6 Binaries: 83
> >> Archives: 0 Standards: 1367 Apache Licensed: 1364 Generated
> >> Documents: 0 JavaDocs are generated, thus a license header is
> >> optional. Generated files do not require license headers. 0 Unknown
> >> Licenses ***************************************************** On
> >> Thu, Apr 9, 2020 at 12:22 AM Kaxil Naik wrote: > If this Vote passes
> >> I intend to call for an Accelerated Vote for rc5. > Planning for rc5
> >> to solve the issue with SQLA releases ( >
> >> https://github.com/apache/airflow/issues/8211) > > Regards, > Kaxil >
> >> > On Wed, Apr 8, 2020 at 11:44 AM Robin Edwards wrote: > > > Just
> >> loaded up our dev environment and done a few sanity checks and > >
> >> also ran our test suite. > > > > Thank you everyone for their hard
> >> work very much looking forward to > > rolling this out. > > > >
> >> Python 3.7 / Postgres / Celery > > > > +1 (non-binding) > > > > On
> >> Tue, 7 Apr 2020 at 23:19, Xinbin Huang wrote: > > > > > > Test with
> >> Python 3.6 + LocalExecutor + Postgres backend > > > > > > Test both
> >> the AWS Parameter Store backend and GCP Secret Manager > backend > >
> >> > can work properly. > > > > > > +1 (non-binding). > > > > > >
> >> Regards, > > > Xinbin > > > > > > On Tue, Apr 7, 2020 at 10:59 AM
> >> Deng Xiaodong > > wrote: > > > > > > > Thanks Kaxil & Ash for the
> >> clarification! > > > > > > > > +1 (non-binding). > > > > > > > > > >
> >> > > > > > > XD > > > > > > > > > On 7 Apr 2020, at 7:46 PM, Kaxil
> >> Naik wrote: > > > > > > > > > > Thanks, XD for testing. Please check
> >> my answers to your question > > below: > > > > > > > > > > - "Delete
> >> DAG" doesn't check whether the DAG file is still in DAG > > Folder >
> >> > > > > anymore. It simply deletes all records of that DAG in DB, and
> >> that > > DAG > > > > will > > > > > re-appear in UI and DB if the DAG
> >> file is still in DAG Folder. I > > found > > > > it's > > > > > also
> >> behaving like this in 1.10.9. Is this intentional? > > > > > > > > >
> >> > This behavior is since 1.10.6 and the change was done to allow > >
> >> deleting > > > > renamed DAGs i.e "If we rename a dag_id but do not
> >> rename the file, > > then we > > > > cannot delete the old dag." > >
> >> > > > > > > > > > > > > > - "Trigger DAG" allows users to give an
> >> optional configuration JSON > > now. > > > > > How the format of this
> >> config JSON should look like? Is it > mentioned > > > > > somewhere
> >> in the doc for 1.10.10? > > > > > > > > > > The Web UI would throw an
> >> error if the string provided is not VALID > > JSON > > > > string.
> >> Example Screenshot: > > > > > > > > > > > > > > > Ash has already
> >> replied to your other questions. > > > > > > > > > > Regards, > > > >
> >> > Kaxil > > > > > > > > > > > > > > > > > > > > > > > > > On Tue, Apr
> >> 7, 2020 at 5:34 PM Ash Berlin-Taylor > > > > wrote: > > > > >
> >> "Trigger DAG" UI now exposes via the UI what was previously only > >
> >> > > > available via the `--conf` option to `airflow trigger_dag`. > >
> >> > > > > > > > > Scheduling is not strictly in UTC anymore, see > > >
> >> > > > >
> >>
> http://airflow.apache.org/docs/stable/timezone.html#time-zone-aware-dags
> >> > > > > < > >
> >>
> http://airflow.apache.org/docs/stable/timezone.html#time-zone-aware-dags
> >> > > > > > > > > > > > > On Apr 7 2020, at 5:30 pm, Deng Xiaodong > >
> >> > > xd.deng.r@gmail.com>> wrote: > > > > > > > > > > > Thanks, Kaxil,
> >> for running the release! > > > > > > > > > > > > I tested with Python
> >> 3.6 + LocalExecutor + Postgres+RBAC in > Docker > > > > > >
> >> environment ( > > > > > > > > > > > > >
> >>
> https://github.com/XD-DENG/containerized-airflow/tree/airflow-1-10-10/localexecutor_postgres
> >> > > > > < > > > > > > >
> >>
> https://github.com/XD-DENG/containerized-airflow/tree/airflow-1-10-10/localexecutor_postgres
> >> > > > > >), > > > > > > including > > > > > > > > > > > > - Run
> >> example DAGs & self-defined DAG > > > > > > - Create users via both
> >> CLI and UI > > > > > > - RBAC feature (deleting DAG as User role
> >> before & after removing > > User > > > > > > role's "delete"
> >> permission) > > > > > > - The Timzone-selection feature in UI (really
> >> nice new feature!) > > > > > > > > > > > > All of them work very well
> >> to me. > > > > > > > > > > > > Before I give +1, I have three
> >> questions to confirm: > > > > > > > > > > > > - "Delete DAG" doesn't
> >> check whether the DAG file is still in DAG > > > > Folder > > > > > >
> >> anymore. It simply deletes all records of that DAG in DB, and > that
> >> > > DAG > > > > will > > > > > > re-appear in UI and DB if the DAG
> >> file is still in DAG Folder. I > > found > > > > it's > > > > > >
> >> also behaving like this in 1.10.9. Is this intentional? > > > > > > -
> >> Timezone-selection in UI: is it highlighted anywhere in the doc > >
> >> that > > > > the > > > > > > scheduling is still ONLY based on UTC? >
> >> > > > > > - "Trigger DAG" allows users to give an optional
> >> configuration > JSON > > > > now. > > > > > > How the format of this
> >> config JSON should look like? Is it > > mentioned > > > > > >
> >> somewhere in the doc for 1.10.10? > > > > > > > > > > > > Thanks
> >> again! > > > > > > > > > > > > > > > > > > XD > > > > > > > > > > > >
> >> On Mon, Apr 6, 2020 at 9:35 PM Kaxil Naik > > > > wrote: > > > > > >
> >> > > > > > >> Hello Apache Airflow Community, > > > > > >> > > > > >
> >> >> This is a call for the vote to release Apache Airflow version > >
> >> 1.10.10. > > > > > >> > > > > > >> The release candidate: > > > > >
> >> >> https://dist.apache.org/repos/dist/dev/airflow/1.10.10rc4/ < > > >
> >> > https://dist.apache.org/repos/dist/dev/airflow/1.10.10rc4/> > > > >
> >> > >> > > > > > >> *apache-airflow-1.10.10rc4-source.tar.gz* is a
> >> source release > that > > > > comes > > > > > >> with INSTALL
> >> instructions. > > > > > >> *apache-airflow-1.10.10rc4-bin.tar.gz* is
> >> the binary Python > > "sdist" > > > > > >> release. > > > > > >>
> >> *apache_airflow-1.10.10rc4-py2.py3-none-any.whl* is the binary > >
> >> Python > > > > wheel > > > > > >> release. > > > > > >> > > > > > >>
> >> Public keys are available at > >
> >> https://www.apache.org/dist/airflow/KEYS > > > > > > > > > >> > > > >
> >> > >> For convenience, RC is also uploaded on PyPI so you can install
> >> > it > > > > using > > > > > >> *pip install
> >> apache-airflow==1.10.10rc4* > > > > > >> > > > > > >> Changes since
> >> 1.10.10rc2: > > > > > >> - Fix 500 error in Security screens (#8165)
> >> > > > > > >> - Fix Viewing Dag Code for Stateless Webserver (#8159) >
> >> > > > > >> > > > > > >> Full Change Log for the release: > > > > > >>
> >> https://github.com/apache/airflow/blob/1.10.10rc4/CHANGELOG.txt > < >
> >> > > >
> >> https://github.com/apache/airflow/blob/1.10.10rc4/CHANGELOG.txt> > >
> >> > > > >> > > > > > >> The vote will be open for at least 72 hours (9
> >> April 19:35 UTC) > or > > > > until > > > > > >> the necessary number
> >> > > > > > >> of votes are reached. > > > > > >> > > > > > >> Please
> >> vote accordingly: > > > > > >> > > > > > >> [ ] +1 approve > > > > >
> >> >> [ ] +0 no opinion > > > > > >> [ ] -1 disapprove with the reason >
> >> > > > > >> > > > > > >> Only votes from PMC members are binding, but
> >> members of the > > community > > > > are > > > > > >> encouraged to
> >> test the release and vote with "(non-binding)". > > > > > >> > > > >
> >> > >> Please note that the version number excludes the `rcX` string, >
> >> so > > > > > >> it's now > > > > > >> simply 1.10.10. This will allow
> >> us to rename the artifact > without > > > > modifying > > > > > >>
> >> the artifact checksums when we actually release it. > > > > > >> > >
> >> > > > >> Thanks, > > > > > >> Kaxil Naik > > > > > >> > > > > > > > >
> >> > > > > > > > > > -- Jarek Potiuk Polidea | Principal Software
> >> Engineer M: +48 660 796 129 <+48660796129> [image: Polidea]
>