You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@calcite.apache.org by "Julian Hyde (Jira)" <ji...@apache.org> on 2023/02/12 00:30:00 UTC

[jira] [Commented] (CALCITE-3870) Change the default value of SqlToRelConverter.Config.expand from true to false

    [ https://issues.apache.org/jira/browse/CALCITE-3870?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17687501#comment-17687501 ] 

Julian Hyde commented on CALCITE-3870:
--------------------------------------

I have created a pull request.

[~zabetak] and/or [~libenchao], Would you mind reviewing? You had some relevant comments in CALCITE-1045 and CALCITE-5127.

> Change the default value of SqlToRelConverter.Config.expand from true to false
> ------------------------------------------------------------------------------
>
>                 Key: CALCITE-3870
>                 URL: https://issues.apache.org/jira/browse/CALCITE-3870
>             Project: Calcite
>          Issue Type: Bug
>          Components: core
>            Reporter: Jiatao Tao
>            Assignee: Julian Hyde
>            Priority: Minor
>              Labels: pull-request-available
>             Fix For: 1.34.0
>
>         Attachments: image-2020-03-25-14-05-04-011.png
>
>          Time Spent: 50m
>  Remaining Estimate: 0h
>
> Set "SqlToRelConverter.ConfigBuilder#expand" default to false. Now the default "expand" in  SqlToRelConverter.ConfigBuilder is true but in calcite's main process, actually, it is false( {{withExpand(THREAD_EXPAND.get())}})
>   
> That leads we need to explicitly set {{withExpand}} to false when we use {{SqlToRelConverter}}.
>   
>  So I think we should change the default to "false" in SqlToRelConverter.ConfigBuilder.
>   
> !https://mail.google.com/mail/u/0?ui=2&ik=09d5de6bf3&attid=0.1&permmsgid=msg-a:r-1571046416348666034&th=17106774a5349d1d&view=fimg&sz=s0-l75-ft&attbid=ANGjdJ_IjYbiwT8IKlaiAIDzbkq_ehCBktd4DzCYr14Ppst6lBftqMbrrWu8hzGpN2wpCz46a3F1FKvfD_miGHkC-EMx509KPC4FEovxtN2M0WcU1up209hyLtKoZqE&disp=emb&realattid=ii_k8460q950!
> !https://mail.google.com/mail/u/0?ui=2&ik=09d5de6bf3&attid=0.2&permmsgid=msg-a:r-1571046416348666034&th=17106774a5349d1d&view=fimg&sz=s0-l75-ft&attbid=ANGjdJ_K-EyE_x0Vo66h6sHRzpEOxIE5qTzuujqG8WqZVPdprgC3khwcO_8OLLai-8ikrMRC9ksO-xAzqe2HFr-QYM1lzQDLYfSlD5x-eOXbww9CNsb5cgu-979N1lU&disp=emb&realattid=ii_k846zj601!



--
This message was sent by Atlassian Jira
(v8.20.10#820010)