You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@kafka.apache.org by ijuma <gi...@git.apache.org> on 2017/06/30 05:45:48 UTC

[GitHub] kafka pull request #3464: MINOR: Enable a number of xlint scalac warnings

GitHub user ijuma opened a pull request:

    https://github.com/apache/kafka/pull/3464

    MINOR: Enable a number of xlint scalac warnings

    Update the code where possible to fix the warnings. The unused
    warning introduced in Scala 2.12 is quite handy and provides
    a reason to compile with Scala 2.12.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/ijuma/kafka scala-xlint

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/kafka/pull/3464.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #3464
    
----
commit 206b761d21ea88e876284f54abd373f4d99784ef
Author: Ismael Juma <is...@juma.me.uk>
Date:   2017-05-02T13:20:00Z

    Enable a number of Xlint scalac warnings

commit 7a19665a4885a24f51c8ff5f2fc8f0055fcd4253
Author: Ismael Juma <is...@juma.me.uk>
Date:   2017-06-29T20:53:04Z

    Remove unused imports

commit c152050aed3c7467c1d26c45281330cc25e83797
Author: Ismael Juma <is...@juma.me.uk>
Date:   2017-06-29T20:53:45Z

    var -> val

commit c6aa06f66c8729543de7a8fed618450d0fe294a7
Author: Ismael Juma <is...@juma.me.uk>
Date:   2017-06-30T05:34:53Z

    More consistent usage of side-effect notation

commit 5fb37f93e5e8cbb0d4206f3542fbe4fa86c23c41
Author: Ismael Juma <is...@juma.me.uk>
Date:   2017-06-30T05:39:23Z

    Remove unused code

commit c6954ffd6709dfa906849107f05f3eb1cb4efee1
Author: Ismael Juma <is...@juma.me.uk>
Date:   2017-06-30T05:40:29Z

    JavaConversions -> JavaConverters

commit 6ecfdccfc1a88a6b6d8edb7571e712d4cb034672
Author: Ismael Juma <is...@juma.me.uk>
Date:   2017-06-30T05:40:49Z

    Avoid shadowing

commit 9c7401f100a2d98b8b86b9cc4b591ff0c219bd03
Author: Ismael Juma <is...@juma.me.uk>
Date:   2017-06-30T05:41:18Z

    Remove unnecessary default argument

commit 259fd9f3ae3311f1777970f0c3ef64d052d69e34
Author: Ismael Juma <is...@juma.me.uk>
Date:   2017-06-30T05:42:43Z

    Avoid unnecessary mutation

commit afbba3538d6366084ad35d529e9e4ef53053a64f
Author: Ismael Juma <is...@juma.me.uk>
Date:   2017-06-30T05:42:56Z

    Remove unnecessary rounding

commit ad106db87e403ec53630d7d82d4c85114f49bd85
Author: Ismael Juma <is...@juma.me.uk>
Date:   2017-06-30T05:43:09Z

    Add missing string interpolator

commit d690623254f27f0e6a5c64a69b0859f3692554e0
Author: Ismael Juma <is...@juma.me.uk>
Date:   2017-06-30T05:43:30Z

    Class visibility should be consistent with method returning it

commit 15d63cb1bfe1bc4cc7db7fb8f59fa946b5a014e6
Author: Ismael Juma <is...@juma.me.uk>
Date:   2017-06-30T05:43:46Z

    Add deprecated annotation to avoid warning

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] kafka pull request #3464: MINOR: Enable a number of xlint scalac warnings

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/kafka/pull/3464


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---