You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2020/11/19 12:48:55 UTC

[GitHub] [arrow] Jibbow commented on pull request #8710: ARROW-10649: [Rust] Parse manually in infer_field_schema, remove lazy static dependency

Jibbow commented on pull request #8710:
URL: https://github.com/apache/arrow/pull/8710#issuecomment-730353755


   `regex` + `lazy_static` is somewhat a nice combination, but I agree that we could also recognize dates without those two libraries. But instead of using `all_digit()` and manually dissecting the string, we could also apply `chrono`'s `parse()` function which returns a `ParseResult` and check whether parsing was successful or not. Opinions on that?
   Also, I like #8714


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org