You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/12/08 11:57:36 UTC
[GitHub] [airflow] Taragolis opened a new pull request, #28220: Migrate integrations tests to `pytest`
Taragolis opened a new pull request, #28220:
URL: https://github.com/apache/airflow/pull/28220
Migrate remaining tests from `tests/integration/*` to `pytest`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] Taragolis commented on a diff in pull request #28220: Migrate integrations tests to `pytest`
Posted by GitBox <gi...@apache.org>.
Taragolis commented on code in PR #28220:
URL: https://github.com/apache/airflow/pull/28220#discussion_r1043273964
##########
tests/integration/providers/google/cloud/transfers/test_presto_to_gcs.py:
##########
@@ -48,7 +47,7 @@
@pytest.mark.integration("presto")
-class TestPrestoToGCSOperator(unittest.TestCase):
+class TestPrestoToGCSOperator:
Review Comment:
Do we have a plan to keep presto integration tests?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #28220: Migrate integrations tests to `pytest`
Posted by GitBox <gi...@apache.org>.
potiuk commented on PR #28220:
URL: https://github.com/apache/airflow/pull/28220#issuecomment-1342666635
> Hmmm... to be honest there is still one `unittests.TestCase` available `tests/integration/providers/google/cloud/transfers/test_presto_to_gcs_system.py::PrestoToGCSSystemTest`
>
> * It based on `GoogleSystemTest`
> * presto integration
Yes. We lost presto integration when trino separated out and presto did not have the right Docker image that we could use for integration (they basically stopped maintaining the image). https://github.com/testcontainers/testcontainers-java/issues/3928
Maybe we can finde a good image now to restore it - it's been quite a long time :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #28220: Migrate integrations tests to `pytest`
Posted by GitBox <gi...@apache.org>.
potiuk commented on PR #28220:
URL: https://github.com/apache/airflow/pull/28220#issuecomment-1342667099
And yeah - it could have been a system test even
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] Taragolis commented on pull request #28220: Migrate integrations tests to `pytest`
Posted by GitBox <gi...@apache.org>.
Taragolis commented on PR #28220:
URL: https://github.com/apache/airflow/pull/28220#issuecomment-1342728149
> Yes. We lost presto integration when trino separated out and presto did not have the right Docker image that we could use for integration (they basically stopped maintaining the image). https://github.com/testcontainers/testcontainers-java/issues/3928Yes. We lost presto integration when trino separated out and presto did not have the right Docker image that we could use for integration (they basically stopped maintaining the image). https://github.com/testcontainers/testcontainers-java/issues/3928
Hmmm.. seems like Trino (previously known as PrestoSQL) support also image for PrestoDB or just some naming miss-leading.
I've found this image [ahanaio/prestodb-sandbox](https://hub.docker.com/r/ahanaio/prestodb-sandbox) in [PrestoDB Getting Started](https://prestodb.io/getting-started.html) so we might try to use it later.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] Taragolis commented on pull request #28220: Migrate integrations tests to `pytest`
Posted by GitBox <gi...@apache.org>.
Taragolis commented on PR #28220:
URL: https://github.com/apache/airflow/pull/28220#issuecomment-1342635181
Hmmm... to be honest there is still one `unittests.TestCase` available `tests/integration/providers/google/cloud/transfers/test_presto_to_gcs_system.py::PrestoToGCSSystemTest`
- It based on `GoogleSystemTest`
- presto integration
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk merged pull request #28220: Migrate integrations tests to `pytest`
Posted by GitBox <gi...@apache.org>.
potiuk merged PR #28220:
URL: https://github.com/apache/airflow/pull/28220
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org