[GitHub] [tomee-site-generator] cesarhernandezgt commented on pull request #37: TOMEE-3846 improve main comparison page and fix per version comparison pages

[GitBox <gi...@apache.org>]

cesarhernandezgt commented on PR #37:
URL: https://github.com/apache/tomee-site-generator/pull/37#issuecomment-1095587774

   Thank you @sultan for the PR updates and @rzo1 for the review. 
   So awesome to see that the Windows issue was fixed! 
   
   > do we both need Jakarta EE 9.0 and 9.1 javadoc on site ? we totally can but maybe 9.1 only is enough? what do you think ?
   
   I would vote +1 for only 9.1. But my opinion is that this work/proposal can be part of a new ticket to limit the scope of the current ticket to only comparison page content.
   
   I won't duplicate Richard's feedback, but the only table I don't fully understand is why the first table [1] has some specifications when the full list is already provided with major detail in the table: "Detailed list of Jakarta EE and MicroProfile specifications".
   
   You previously mentioned:
   
   > so I thought some specs could be usefull. i selected them based on what can help my students configure TomEE and Eclipse :
   
   But I still don't get the problem this part of the table is solving. I used Eclipse IDE and configuration steps for TomEE in Eclipse are documented here: https://tomee.apache.org/latest/docs/tomee-and-eclipse.html. If your students are creating projects from scratch, maybe a maven archetype could be better to customize their project setup in terms of dependencies and version numbers.
   
   [1]
   ![image](https://user-images.githubusercontent.com/1454523/162835474-efb413e1-f316-4d08-8b81-31d91f83a518.png)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@tomee.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org