You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/12/09 08:50:52 UTC
[GitHub] [airflow] eladkal opened a new pull request #20157: Organize EC2 classes in Amazon provider
eladkal opened a new pull request #20157:
URL: https://github.com/apache/airflow/pull/20157
Part of https://github.com/apache/airflow/issues/20139
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/main/UPDATING.md).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil commented on a change in pull request #20157: Organize EC2 classes in Amazon provider
Posted by GitBox <gi...@apache.org>.
kaxil commented on a change in pull request #20157:
URL: https://github.com/apache/airflow/pull/20157#discussion_r765772091
##########
File path: airflow/providers/amazon/provider.yaml
##########
@@ -263,6 +264,7 @@ sensors:
- integration-name: Amazon EC2
python-modules:
- airflow.providers.amazon.aws.sensors.ec2_instance_state
+ - airflow.providers.amazon.aws.sensors.ec2
Review comment:
Shouldn't we remove the line above this? or do we need to keep it until we remove it entirely?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] eladkal commented on a change in pull request #20157: Organize EC2 classes in Amazon provider
Posted by GitBox <gi...@apache.org>.
eladkal commented on a change in pull request #20157:
URL: https://github.com/apache/airflow/pull/20157#discussion_r765824624
##########
File path: airflow/providers/amazon/provider.yaml
##########
@@ -263,6 +264,7 @@ sensors:
- integration-name: Amazon EC2
python-modules:
- airflow.providers.amazon.aws.sensors.ec2_instance_state
+ - airflow.providers.amazon.aws.sensors.ec2
Review comment:
Removing it will cause failures for `verify_provider_package`.
pre-commits checks for comptability between yaml and modules found in the provider package.
removing the entries should be done when we remove the modules
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #20157: Organize EC2 classes in Amazon provider
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #20157:
URL: https://github.com/apache/airflow/pull/20157#issuecomment-989932955
The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest main at your convenience, or amend the last commit of the PR, and push it with --force-with-lease.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil commented on a change in pull request #20157: Organize EC2 classes in Amazon provider
Posted by GitBox <gi...@apache.org>.
kaxil commented on a change in pull request #20157:
URL: https://github.com/apache/airflow/pull/20157#discussion_r765772228
##########
File path: airflow/providers/amazon/provider.yaml
##########
@@ -263,6 +264,7 @@ sensors:
- integration-name: Amazon EC2
python-modules:
- airflow.providers.amazon.aws.sensors.ec2_instance_state
+ - airflow.providers.amazon.aws.sensors.ec2
Review comment:
cc @potiuk
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] eladkal commented on a change in pull request #20157: Organize EC2 classes in Amazon provider
Posted by GitBox <gi...@apache.org>.
eladkal commented on a change in pull request #20157:
URL: https://github.com/apache/airflow/pull/20157#discussion_r765826130
##########
File path: airflow/providers/amazon/provider.yaml
##########
@@ -263,6 +264,7 @@ sensors:
- integration-name: Amazon EC2
python-modules:
- airflow.providers.amazon.aws.sensors.ec2_instance_state
+ - airflow.providers.amazon.aws.sensors.ec2
Review comment:
We have several of similar cases. For example:
https://github.com/apache/airflow/blob/fa96b093952f96449d6d328a2b9e9300b81cf08e/airflow/providers/amazon/provider.yaml#L312-L314
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] eladkal merged pull request #20157: Organize EC2 classes in Amazon provider
Posted by GitBox <gi...@apache.org>.
eladkal merged pull request #20157:
URL: https://github.com/apache/airflow/pull/20157
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] eladkal commented on pull request #20157: Organize EC2 classes in Amazon provider
Posted by GitBox <gi...@apache.org>.
eladkal commented on pull request #20157:
URL: https://github.com/apache/airflow/pull/20157#issuecomment-990039612
No need to waste CI resources for full test matrix for this change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org