You are viewing a plain text version of this content. The canonical link for it is here.
Posted to derby-dev@db.apache.org by TomohitoNakayama <to...@basil.ocn.ne.jp> on 2005/05/05 11:30:04 UTC
DERBY-167 has done but ...
Hello.
I think coding for solution-1 of DERBY-167 has done.
I attach patch file to this mail for others to confirm it.
Relating test , autoincrement and columnDefaults , was passed.
However, In derbyall test , I found many errors which seems not caused by my
modification.
Errors seems to be devided three kind ...
1:Error of parameterMapping. I don't know what is parameter Mapping mean,
but file names told so.
2:Error of i18n. It seems that English message was generated though test
assume Spanish.
3:Error of derbynetclientmats.
I uploaded $TEST_DIR/derbyall_fail.txt and $TEST_DIR/derbyall_diff.txt to my
web directory,
because size was too large.
http://www5.ocn.ne.jp/~tomohito/20050505/derbyall_fail.txt
http://www5.ocn.ne.jp/~tomohito/20050505/derbyall_diff.txt
Something is going on ...?
Best regards.
/*
Tomohito Nakayama
tomonaka@basil.ocn.ne.jp
tomohito@rose.zero.ad.jp
Naka
http://www5.ocn.ne.jp/~tomohito/TopPage.html
*/
Re: DERBY-167 has done but ...
Posted by Daniel John Debrunner <dj...@debrunners.com>.
TomohitoNakayama wrote:
> Hello.
>
> I think coding for solution-1 of DERBY-167 has done.
> I attach patch file to this mail for others to confirm it.
There seems to be a lot of code re-formatting in this patch. This makes
it much harder for the reviewers to see the actual changes. For example
are there any real changes to TableElementList.java or is it just
re-formatting? This seems to be the case with several files. Try to
avoid re-formatting code while making changes.
For the upgrade check, the string passed should not include the bug
number, just the syntax being disallowed.
+ checkVersion(DataDictionary.DD_VERSION_DERBY_10_1,
+ "GENERATED BY DEFAULT");
The creation of the DefaultNode needs to go through the factory,
nodeFactory.getNode(...) like all the other nodes.
In sqlgrammar.jj you increase the size of the long[] autoIncrementInfo
but don't seem to use the extra space.
The assigning of 'value' in the GENERATED rule in sqlgrammar.jj seems to
be wrong. It seems if the DEFAULT option is there it is set to a
DefaultNode, but that will be overwritten if the optional START BY or
INCREMENT BY are used.
Some more testing would be good:
- do inserts into t2 without giving a value for T2_AUTOGEN continue to
work after the insert that provided a value.
- test BY DEFAULT with the INCREMENT/START BY options, I think that
would have exposed the value assignment bug in sqlgrammar.jj
- what happens if there is a primary key, unique index or unique
constraint on the column and user value is provided that matches the
next automatically generated value.
Dan.
Re: DERBY-167 has done but ...
Posted by Sunitha Kambhampati <ks...@gmail.com>.
[Kathey Marsden wrote.. ]
>>
>> For derbynetclientmats You are getting class not found on the new
>> ClientDriver which was checked in last week. I am not sure why you are
>> not picking it up. I suggest you svn update, ant clobber and rebuild.
>> Hopefully that will fix it.
>>
>>
The client driver related classes are bundled into derbyclient.jar
Not sure what is in your classpath , but if you are using jars anohter
check would be to see if you have derbyclient.jar in your classpath or not.
Sunitha.
Re: DERBY-167 has done but ...
Posted by TomohitoNakayama <to...@basil.ocn.ne.jp>.
Hello.
I had made CLASSPATH resemble to that of
derby/trunk/frameworks/embedded/bin/setEmbeddedCP.bat.
Seeing those, I couldn't find configuration for derbyLocale_es.jar...
Hmm...
I will try it.
Thank you !
Best regards.
/*
Tomohito Nakayama
tomonaka@basil.ocn.ne.jp
tomohito@rose.zero.ad.jp
Naka
http://www5.ocn.ne.jp/~tomohito/TopPage.html
*/
----- Original Message -----
From: "Myrna van Lunteren" <m....@gmail.com>
To: "Derby Development" <de...@db.apache.org>
Sent: Thursday, May 05, 2005 11:05 PM
Subject: Re: DERBY-167 has done but ...
Not knowing your classpath, for the i18n failure you describe, I'm
guessing that you generated, then ran with jars but you don't have all
the locale jars - in particular the spanish one (derbyLocale_es.jar) -
in your classpath.
re parameterMapping - haven't seent hat fail recently...
Myrna
On 5/5/05, TomohitoNakayama <to...@basil.ocn.ne.jp> wrote:
> Hello.
> >> However, In derbyall test , I found many errors which seems not caused
> >> by my modification.
> >
> >> Errors seems to be devided three kind ...
> >> 1:Error of parameterMapping. I don't know what is parameter Mapping
> >> mean,
> >> but file names told so.
> >> 2:Error of i18n. It seems that English message was generated though
--
No virus found in this incoming message.
Checked by AVG Anti-Virus.
Version: 7.0.308 / Virus Database: 266.11.5 - Release Date: 2005/05/04
--
No virus found in this outgoing message.
Checked by AVG Anti-Virus.
Version: 7.0.308 / Virus Database: 266.11.5 - Release Date: 2005/05/04
Re: DERBY-167 has done but ...
Posted by Myrna van Lunteren <m....@gmail.com>.
Not knowing your classpath, for the i18n failure you describe, I'm
guessing that you generated, then ran with jars but you don't have all
the locale jars - in particular the spanish one (derbyLocale_es.jar) -
in your classpath.
re parameterMapping - haven't seent hat fail recently...
Myrna
On 5/5/05, TomohitoNakayama <to...@basil.ocn.ne.jp> wrote:
> Hello.
> >> However, In derbyall test , I found many errors which seems not caused
> >> by my modification.
> >
> >> Errors seems to be devided three kind ...
> >> 1:Error of parameterMapping. I don't know what is parameter Mapping mean,
> >> but file names told so.
> >> 2:Error of i18n. It seems that English message was generated though
Re: DERBY-167 has done but ...
Posted by Myrna van Lunteren <m....@gmail.com>.
Actually, using the settings from the set*.* scripts are *not*
sufficient for the testing.
The testing is functional testing & for instance assumes you'd run
both embedded and networkserver tests and various locales with the
same setup, which would be highly unusual for any other situation. If
you want to run with jars, use the classpath setting as described in
the file <trunk>/java/testing/README.htm. You can also run with just
pointing your classpath to your classes dir...
Myrna
On 5/5/05, Jeremy Boynes <jb...@apache.org> wrote:
> TomohitoNakayama wrote:
> > Hello.
> >
> > I have execused svn updated ,
> > but code for derbynetclientmats seems not updated.
> >
> > I will check building.
> > There may be mistake especially where around "sane" option...
> >
>
> derbynetclientmats was passing for me last night. Did you remember to
> add the new derbyclient.jar to your CLASSPATH?
>
> --
> Jeremy
>
Re: DERBY-167 has done but ...
Posted by Jeremy Boynes <jb...@apache.org>.
TomohitoNakayama wrote:
> Hello.
>
> I have execused svn updated ,
> but code for derbynetclientmats seems not updated.
>
> I will check building.
> There may be mistake especially where around "sane" option...
>
derbynetclientmats was passing for me last night. Did you remember to
add the new derbyclient.jar to your CLASSPATH?
--
Jeremy
Re: DERBY-167 has done but ...
Posted by TomohitoNakayama <to...@basil.ocn.ne.jp>.
Hello.
I have execused svn updated ,
but code for derbynetclientmats seems not updated.
I will check building.
There may be mistake especially where around "sane" option...
Best regards.
/*
Tomohito Nakayama
tomonaka@basil.ocn.ne.jp
tomohito@rose.zero.ad.jp
Naka
http://www5.ocn.ne.jp/~tomohito/TopPage.html
*/
----- Original Message -----
From: "Kathey Marsden" <km...@sbcglobal.net>
To: "Derby Development" <de...@db.apache.org>
Sent: Thursday, May 05, 2005 8:10 PM
Subject: Re: DERBY-167 has done but ...
> TomohitoNakayama wrote:
>
>>
>> However, In derbyall test , I found many errors which seems not caused
>> by my modification.
>
>> Errors seems to be devided three kind ...
>> 1:Error of parameterMapping. I don't know what is parameter Mapping mean,
>> but file names told so.
>> 2:Error of i18n. It seems that English message was generated though
>> test assume Spanish.
>> 3:Error of derbynetclientmats.
>
> For derbynetclientmats You are getting class not found on the new
> ClientDriver which was checked in last week. I am not sure why you are
> not picking it up. I suggest you svn update, ant clobber and rebuild.
> Hopefully that will fix it.
>
>
>
>
>
>
>
> --
> No virus found in this incoming message.
> Checked by AVG Anti-Virus.
> Version: 7.0.308 / Virus Database: 266.11.5 - Release Date: 2005/05/04
>
>
--
No virus found in this outgoing message.
Checked by AVG Anti-Virus.
Version: 7.0.308 / Virus Database: 266.11.5 - Release Date: 2005/05/04
Re: DERBY-167 has done but ...
Posted by Kathey Marsden <km...@sbcglobal.net>.
TomohitoNakayama wrote:
>
> However, In derbyall test , I found many errors which seems not caused
> by my modification.
> Errors seems to be devided three kind ...
> 1:Error of parameterMapping. I don't know what is parameter Mapping mean,
> but file names told so.
> 2:Error of i18n. It seems that English message was generated though
> test assume Spanish.
> 3:Error of derbynetclientmats.
For derbynetclientmats You are getting class not found on the new
ClientDriver which was checked in last week. I am not sure why you are
not picking it up. I suggest you svn update, ant clobber and rebuild.
Hopefully that will fix it.
Re: DERBY-167 has done but ...
Posted by Mamta Satoor <ms...@gmail.com>.
Hi David,
The patch you reviewed has not been committed yet. So, the change
conflict on the 2 files ResultColumnList and ColumnDescriptor might be
from some one else.
Mamta
On 5/5/05, David Van Couvering <Da...@sun.com> wrote:
> ResultColumnList and ColumnDescriptor were modified by Mamta's patch, I
> remember reviewing them...
>
> David
>
> Satheesh Bandaram wrote:
> > Great job getting this done. This is indeed a very useful Enhancement to
> > Derby.
> >
> > Looking briefly at the attached patch, some comments:
> >
> > 1. I think syntax for GENERATED BY DEFAULT needs to include the *BY*,
> > according to SQL standard.
> > 2. One of the main uses of this new clause is for importing data into
> > IDENTITY columns. I would like to see some tests that import data
> > into tables created with the new identity option. Import code
> > actually uses bulkInsert option, so it would be good to test this
> > code path too. I can help, if needed, on these tests. Before
> > commiting the patch, it would be good to add more tests in general.
> > 3. I couldn't fully apply the patch. Had issues with two files,
> > ResultColumnList and ColumnDescriptor. I think these files might
> > have been updated since you started working on the patch. It would
> > be good if you can merge up to the latest version.
> >
> > Again, great to see the patch.
> >
> > Satheesh
> >
> > TomohitoNakayama wrote:
> >
> >> Hello.
> >>
> >> I think coding for solution-1 of DERBY-167 has done.
> >> I attach patch file to this mail for others to confirm it.
> >>
> >> Relating test , autoincrement and columnDefaults , was passed.
> >>
> >>
> >> However, In derbyall test , I found many errors which seems not caused
> >> by my modification.
> >> Errors seems to be devided three kind ...
> >> 1:Error of parameterMapping. I don't know what is parameter Mapping mean,
> >> but file names told so.
> >> 2:Error of i18n. It seems that English message was generated though
> >> test assume Spanish.
> >> 3:Error of derbynetclientmats.
> >>
> >> I uploaded $TEST_DIR/derbyall_fail.txt and $TEST_DIR/derbyall_diff.txt
> >> to my web directory,
> >> because size was too large.
> >> http://www5.ocn.ne.jp/~tomohito/20050505/derbyall_fail.txt
> >> http://www5.ocn.ne.jp/~tomohito/20050505/derbyall_diff.txt
> >>
> >> Something is going on ...?
> >>
> >>
> >> Best regards.
> >>
> >>
> >> /*
> >>
> >> Tomohito Nakayama
> >> tomonaka@basil.ocn.ne.jp
> >> tomohito@rose.zero.ad.jp
> >>
> >> Naka
> >> http://www5.ocn.ne.jp/~tomohito/TopPage.html
> >>
> >> */
> >>
> >>------------------------------------------------------------------------
> >>
> >>No virus found in this outgoing message.
> >>Checked by AVG Anti-Virus.
> >>Version: 7.0.308 / Virus Database: 266.11.5 - Release Date: 2005/05/04
> >>
> >>
>
Re: DERBY-167 has done but ...
Posted by David Van Couvering <Da...@Sun.COM>.
ResultColumnList and ColumnDescriptor were modified by Mamta's patch, I
remember reviewing them...
David
Satheesh Bandaram wrote:
> Great job getting this done. This is indeed a very useful Enhancement to
> Derby.
>
> Looking briefly at the attached patch, some comments:
>
> 1. I think syntax for GENERATED BY DEFAULT needs to include the *BY*,
> according to SQL standard.
> 2. One of the main uses of this new clause is for importing data into
> IDENTITY columns. I would like to see some tests that import data
> into tables created with the new identity option. Import code
> actually uses bulkInsert option, so it would be good to test this
> code path too. I can help, if needed, on these tests. Before
> commiting the patch, it would be good to add more tests in general.
> 3. I couldn't fully apply the patch. Had issues with two files,
> ResultColumnList and ColumnDescriptor. I think these files might
> have been updated since you started working on the patch. It would
> be good if you can merge up to the latest version.
>
> Again, great to see the patch.
>
> Satheesh
>
> TomohitoNakayama wrote:
>
>> Hello.
>>
>> I think coding for solution-1 of DERBY-167 has done.
>> I attach patch file to this mail for others to confirm it.
>>
>> Relating test , autoincrement and columnDefaults , was passed.
>>
>>
>> However, In derbyall test , I found many errors which seems not caused
>> by my modification.
>> Errors seems to be devided three kind ...
>> 1:Error of parameterMapping. I don't know what is parameter Mapping mean,
>> but file names told so.
>> 2:Error of i18n. It seems that English message was generated though
>> test assume Spanish.
>> 3:Error of derbynetclientmats.
>>
>> I uploaded $TEST_DIR/derbyall_fail.txt and $TEST_DIR/derbyall_diff.txt
>> to my web directory,
>> because size was too large.
>> http://www5.ocn.ne.jp/~tomohito/20050505/derbyall_fail.txt
>> http://www5.ocn.ne.jp/~tomohito/20050505/derbyall_diff.txt
>>
>> Something is going on ...?
>>
>>
>> Best regards.
>>
>>
>> /*
>>
>> Tomohito Nakayama
>> tomonaka@basil.ocn.ne.jp
>> tomohito@rose.zero.ad.jp
>>
>> Naka
>> http://www5.ocn.ne.jp/~tomohito/TopPage.html
>>
>> */
>>
>>------------------------------------------------------------------------
>>
>>No virus found in this outgoing message.
>>Checked by AVG Anti-Virus.
>>Version: 7.0.308 / Virus Database: 266.11.5 - Release Date: 2005/05/04
>>
>>
Re: "-Dframework=DerbyNetClient"? (Re: BulkInsert ? (Re: DERBY-167 has done but ...))
Posted by TomohitoNakayama <to...@basil.ocn.ne.jp>.
Hello ....
I found mistake in CLASSPATH.
I misconfigurated CLASSPATH for db2jcc_license_c.jar....
Well ... I need to learn more about drivers....
Thank you for your advising !
Best regards.
/*
Tomohito Nakayama
tomonaka@basil.ocn.ne.jp
tomohito@rose.zero.ad.jp
Naka
http://www5.ocn.ne.jp/~tomohito/TopPage.html
*/
----- Original Message -----
From: "Myrna van Lunteren" <m....@gmail.com>
To: "Derby Development" <de...@db.apache.org>
Sent: Wednesday, May 11, 2005 10:47 PM
Subject: Re: "-Dframework=DerbyNetClient"? (Re: BulkInsert ? (Re: DERBY-167
has done but ...))
Hi...
but, in
http://svn.apache.org/repos/asf/incubator/derby/code/trunk/java/testing/org/apache/derbyTesting/functionTests/suites/derbynetclientmats.properties
it already shows:framework=DerbyNetClient
derbynetmats is included in the suite derbynetclientmats (see
derbynetclientmats.properties) - when running from within
derbynetclientmats, the higher level's suite's property overwrites the
lower level property & thus, the test will then run with
framework=DerbyNetClient, i.e. test with derbyclient.jar.
But derbynetmats is also separate suite in its own right, intended to
test the jcc driver - db2jcc.jar, which is when the
framework=DerbyNet.
Both drivers need to be tested as they're both supported by/with derby.
So, derbyall.properties includes both suites derbynetmats &
derbynetclientmats.
Myrna
On 5/11/05, TomohitoNakayama <to...@basil.ocn.ne.jp> wrote:
> Hello.
>
> In derbynetmats.properties,
> http://svn.apache.org/repos/asf/incubator/derby/code/trunk/java/testing/org/apache/derbyTesting/functionTests/suites/derbynetmats.properties
> cofiguration was as next ...
>
> framework=DerbyNet
>
> I think this should be ,
> framework=DerbyNetClient.
>
> This may be reason....
>
> #And second reason is that I don't know much about common knoledge of test
> suite ;P
> #I feel that derbyall test suite does not suit for my task....
>
> Thanks.
>
> Best regards.
>
> /*
>
> Tomohito Nakayama
> tomonaka@basil.ocn.ne.jp
> tomohito@rose.zero.ad.jp
>
> Naka
> http://www5.ocn.ne.jp/~tomohito/TopPage.html
>
> */
> ----- Original Message -----
> From: "Myrna van Lunteren" <m....@gmail.com>
> To: "Derby Development" <de...@db.apache.org>
> Sent: Wednesday, May 11, 2005 2:04 AM
> Subject: Re: "-Dframework=DerbyNetClient"? (Re: BulkInsert ? (Re:
> DERBY-167
> has done but ...))
>
> Hi,
>
> Well, derbyall runs derbynetmats & derbynetclientmats. With
> derbynetmats, the intent of the suite is to test derbynet, i.e.
> networkserver via IBMs Universal JDBC driver ('db2jcc*.jar'). With
> derbynetclientmats, the intent of the suite is to test the (new)
> derbyclient - and thus, in that subsuite, -Dframework=DerbyNetClient.
>
> So, it's not the default, the default framework is none - which means,
> using the embedded driver & not networkserver at all. The property
> gets set by the harness because it's in the derbynetmats.properties
> file.
>
> RunSuite derbyall should not be run with any framework properties
> passed in...the individual suites will add the framework properties as
> needed.
>
> As to why you got a hang...??? If you have the db2jcc*.jar in your
> classpath, it should just run, if you don't it should just skip that
> test. I've not seen that test hang recently...You should check what
> the last thing is the test did - this you would see in the .tmp file.
> Also, do other derbynetmats tests pass? Also, the derbynet.out and
> derbynet.err (drill down into the derbynetmats dir untill you find
> them) will have more info.
>
> Myrna
>
> On 5/10/05, TomohitoNakayama <to...@basil.ocn.ne.jp> wrote:
> > Follows ....
> >
> > > Well .. I'm not sure default command option "-Dframework=DerbyNet"
> > > generated by RunSuite ....
> >
> > This means that I wonder why default of the option is this value...
> >
> > Best regards.
> >
> > /*
> >
> > Tomohito Nakayama
> > tomonaka@basil.ocn.ne.jp
> > tomohito@rose.zero.ad.jp
> >
> > Naka
> > http://www5.ocn.ne.jp/~tomohito/TopPage.html
> >
> > */
> > ----- Original Message -----
> > From: "TomohitoNakayama" <to...@basil.ocn.ne.jp>
> > To: "Derby Development" <de...@db.apache.org>
> > Sent: Tuesday, May 10, 2005 10:45 PM
> > Subject: "-Dframework=DerbyNetClient"? (Re: BulkInsert ? (Re: DERBY-167
> > has
> > done but ...))
> >
> > > Hello.
> > >
> > > I have tried alljava test suite , but failed in executing
> > > DerbyNetAutoStart.
> > > Many hours but the test does not finised.
> > >
> > > Executing command generated by RunSuite for that test was as next:
> > > Execute command:
> > > java -DjavaCmd=java -Dframework=DerbyNet -Dtimeout=60 -Djdk12te
> > > st=true -Doutputdir=C:\ProgramDev\derbyUser\derbyall.20050510\derbyall\derbynetm
> > > ats\DerbyNet\derbynetmats -Dtopsuitedir=C:\ProgramDev\derbyUser\derbyall.2005051
> > > 0\derbyall\derbynetmats\DerbyNet -Dtopreportdir=C:\ProgramDev\derbyUser\derbyall
> > > .20050510\derbyall\derbynetmats -Drundir=C:\ProgramDev\derbyUser\derbyall.200505
> > > 10 -DtestSpecialProps=derby.debug.true=enableBtreeConsistencyCheck^derby.stream.
> > > error.logSeverityLevel=0^excludeJCC=at-or-after:3.0,when-at-or-before:jdk1.3.1^r
> > > unwithj9=false -Dsuitename=derbynetmats:derbynetmats -Dtopsuitename=derbyall
> > > org
> > > .apache.derbyTesting.functionTests.harness.RunTest
> > > derbynet/DerbyNetAutoStart.ja
> > > va
> > >
> > > Seeing next url , I found option of "-Dframework=DerbyNetClient" is
> > > needed
> > > for RunTest.
> > > http://svn.apache.org/repos/asf/incubator/derby/code/trunk/java/testing/README.htm
> > >
> > > Adding above option to RunSuite also.
> > > After that test seems to be done.
> > >
> > > Well .. I'm not sure default command option "-Dframework=DerbyNet"
> > > generated by RunSuite ....
> > >
> > > Best regards.
> > >
> > > /*
> > >
> > > Tomohito Nakayama
> > > tomonaka@basil.ocn.ne.jp
> > > tomohito@rose.zero.ad.jp
> > >
> > > Naka
> > > http://www5.ocn.ne.jp/~tomohito/TopPage.html
> > >
> > > */
> > > ----- Original Message -----
> > > From: "TomohitoNakayama" <to...@basil.ocn.ne.jp>
> > > To: "Derby Development" <de...@db.apache.org>
> > > Sent: Tuesday, May 10, 2005 8:37 PM
> > > Subject: Re: BulkInsert ? (Re: DERBY-167 has done but ...)
> > >
> > >
> > >> Hello.
> > >>
> > >> I see.
> > >> I understood bulk insert.
> > >> Thank you.
> > >> Now, I have just tryed derbyall-test problem and there seems to be
> > >> trouble in derbynet/DerbyNetAutoStart..
> > >>
> > >> I will report it in detail later.
> > >>
> > >> Best regards.
> > >> /*
> > >>
> > >> Tomohito Nakayama
> > >> tomonaka@basil.ocn.ne.jp
> > >> tomohito@rose.zero.ad.jp
> > >>
> > >> Naka
> > >> http://www5.ocn.ne.jp/~tomohito/TopPage.html
> > >>
> > >> */
> > >> ----- Original Message -----
> > >> From: "Kathey Marsden" <km...@sbcglobal.net>
> > >> To: "Derby Development" <de...@db.apache.org>
> > >> Sent: Tuesday, May 10, 2005 5:02 AM
> > >> Subject: Re: BulkInsert ? (Re: DERBY-167 has done but ...)
> > >>
> > >>
> > >>> Satheesh Bandaram wrote:
> > >>>
> > >>>> BulkInsert is an internal mechanism, that gets used when you import
> > >>>> data into a table, using Derby's import mechanism.
> > >>>> (SYSCS_UTIL.SYSCS_IMPORT_TABLE
> > >>>> <http://incubator.apache.org/derby/docs/ref/>) This is not directly
> > >>>> exposed to applications using JDBC or SQL, so there is no way to
> > >>>> directly invoke it. If you write some test cases for your feature
> > >>>> using this procedure, you are testing bulkInsert code. Are you
> > >>>> familiar with importing/exporting tables? Looking at Derby manuals
> > >>>> for
> > >>>> information would be very useful.
> > >>>
> > >>> I think you could add a test to tools/ieptests.sql
> > >>> which tests loading a table with an identity column.
> > >>>
> > >>> Kathey
> > >>>
> > >>>
> > >>>
> > >>>
> > >>>
> > >>> --
> > >>> No virus found in this incoming message.
> > >>> Checked by AVG Anti-Virus.
> > >>> Version: 7.0.308 / Virus Database: 266.11.6 - Release Date:
> > >>> 2005/05/06
> > >>>
> > >>
> > >>
> > >> --
> > >> No virus found in this outgoing message.
> > >> Checked by AVG Anti-Virus.
> > >> Version: 7.0.308 / Virus Database: 266.11.7 - Release Date:
> > >> 2005/05/09
> > >>
> > >>
> > >>
> > >>
> > >> --
> > >> No virus found in this incoming message.
> > >> Checked by AVG Anti-Virus.
> > >> Version: 7.0.308 / Virus Database: 266.11.7 - Release Date:
> > >> 2005/05/09
> > >>
> > >>
> > >
> > >
> > >
> > > --
> > > No virus found in this outgoing message.
> > > Checked by AVG Anti-Virus.
> > > Version: 7.0.308 / Virus Database: 266.11.7 - Release Date: 2005/05/09
> > >
> > >
> > >
> > >
> > > --
> > > No virus found in this incoming message.
> > > Checked by AVG Anti-Virus.
> > > Version: 7.0.308 / Virus Database: 266.11.7 - Release Date: 2005/05/09
> > >
> >
> > --
> > No virus found in this outgoing message.
> > Checked by AVG Anti-Virus.
> > Version: 7.0.308 / Virus Database: 266.11.7 - Release Date: 2005/05/09
> >
> >
>
> --
> No virus found in this incoming message.
> Checked by AVG Anti-Virus.
> Version: 7.0.308 / Virus Database: 266.11.7 - Release Date: 2005/05/09
>
> --
> No virus found in this outgoing message.
> Checked by AVG Anti-Virus.
> Version: 7.0.308 / Virus Database: 266.11.8 - Release Date: 2005/05/10
>
>
--
No virus found in this incoming message.
Checked by AVG Anti-Virus.
Version: 7.0.308 / Virus Database: 266.11.8 - Release Date: 2005/05/10
--
No virus found in this outgoing message.
Checked by AVG Anti-Virus.
Version: 7.0.308 / Virus Database: 266.11.8 - Release Date: 2005/05/10
Re: "-Dframework=DerbyNetClient"? (Re: BulkInsert ? (Re: DERBY-167 has done but ...))
Posted by Myrna van Lunteren <m....@gmail.com>.
Hi...
but, in
http://svn.apache.org/repos/asf/incubator/derby/code/trunk/java/testing/org/apache/derbyTesting/functionTests/suites/derbynetclientmats.properties
it already shows:framework=DerbyNetClient
derbynetmats is included in the suite derbynetclientmats (see
derbynetclientmats.properties) - when running from within
derbynetclientmats, the higher level's suite's property overwrites the
lower level property & thus, the test will then run with
framework=DerbyNetClient, i.e. test with derbyclient.jar.
But derbynetmats is also separate suite in its own right, intended to
test the jcc driver - db2jcc.jar, which is when the
framework=DerbyNet.
Both drivers need to be tested as they're both supported by/with derby.
So, derbyall.properties includes both suites derbynetmats & derbynetclientmats.
Myrna
On 5/11/05, TomohitoNakayama <to...@basil.ocn.ne.jp> wrote:
> Hello.
>
> In derbynetmats.properties,
> http://svn.apache.org/repos/asf/incubator/derby/code/trunk/java/testing/org/apache/derbyTesting/functionTests/suites/derbynetmats.properties
> cofiguration was as next ...
>
> framework=DerbyNet
>
> I think this should be ,
> framework=DerbyNetClient.
>
> This may be reason....
>
> #And second reason is that I don't know much about common knoledge of test
> suite ;P
> #I feel that derbyall test suite does not suit for my task....
>
> Thanks.
>
> Best regards.
>
> /*
>
> Tomohito Nakayama
> tomonaka@basil.ocn.ne.jp
> tomohito@rose.zero.ad.jp
>
> Naka
> http://www5.ocn.ne.jp/~tomohito/TopPage.html
>
> */
> ----- Original Message -----
> From: "Myrna van Lunteren" <m....@gmail.com>
> To: "Derby Development" <de...@db.apache.org>
> Sent: Wednesday, May 11, 2005 2:04 AM
> Subject: Re: "-Dframework=DerbyNetClient"? (Re: BulkInsert ? (Re: DERBY-167
> has done but ...))
>
> Hi,
>
> Well, derbyall runs derbynetmats & derbynetclientmats. With
> derbynetmats, the intent of the suite is to test derbynet, i.e.
> networkserver via IBMs Universal JDBC driver ('db2jcc*.jar'). With
> derbynetclientmats, the intent of the suite is to test the (new)
> derbyclient - and thus, in that subsuite, -Dframework=DerbyNetClient.
>
> So, it's not the default, the default framework is none - which means,
> using the embedded driver & not networkserver at all. The property
> gets set by the harness because it's in the derbynetmats.properties
> file.
>
> RunSuite derbyall should not be run with any framework properties
> passed in...the individual suites will add the framework properties as
> needed.
>
> As to why you got a hang...??? If you have the db2jcc*.jar in your
> classpath, it should just run, if you don't it should just skip that
> test. I've not seen that test hang recently...You should check what
> the last thing is the test did - this you would see in the .tmp file.
> Also, do other derbynetmats tests pass? Also, the derbynet.out and
> derbynet.err (drill down into the derbynetmats dir untill you find
> them) will have more info.
>
> Myrna
>
> On 5/10/05, TomohitoNakayama <to...@basil.ocn.ne.jp> wrote:
> > Follows ....
> >
> > > Well .. I'm not sure default command option "-Dframework=DerbyNet"
> > > generated by RunSuite ....
> >
> > This means that I wonder why default of the option is this value...
> >
> > Best regards.
> >
> > /*
> >
> > Tomohito Nakayama
> > tomonaka@basil.ocn.ne.jp
> > tomohito@rose.zero.ad.jp
> >
> > Naka
> > http://www5.ocn.ne.jp/~tomohito/TopPage.html
> >
> > */
> > ----- Original Message -----
> > From: "TomohitoNakayama" <to...@basil.ocn.ne.jp>
> > To: "Derby Development" <de...@db.apache.org>
> > Sent: Tuesday, May 10, 2005 10:45 PM
> > Subject: "-Dframework=DerbyNetClient"? (Re: BulkInsert ? (Re: DERBY-167
> > has
> > done but ...))
> >
> > > Hello.
> > >
> > > I have tried alljava test suite , but failed in executing
> > > DerbyNetAutoStart.
> > > Many hours but the test does not finised.
> > >
> > > Executing command generated by RunSuite for that test was as next:
> > > Execute command:
> > > java -DjavaCmd=java -Dframework=DerbyNet -Dtimeout=60 -Djdk12te
> > > st=true -Doutputdir=C:\ProgramDev\derbyUser\derbyall.20050510\derbyall\derbynetm
> > > ats\DerbyNet\derbynetmats -Dtopsuitedir=C:\ProgramDev\derbyUser\derbyall.2005051
> > > 0\derbyall\derbynetmats\DerbyNet -Dtopreportdir=C:\ProgramDev\derbyUser\derbyall
> > > .20050510\derbyall\derbynetmats -Drundir=C:\ProgramDev\derbyUser\derbyall.200505
> > > 10 -DtestSpecialProps=derby.debug.true=enableBtreeConsistencyCheck^derby.stream.
> > > error.logSeverityLevel=0^excludeJCC=at-or-after:3.0,when-at-or-before:jdk1.3.1^r
> > > unwithj9=false -Dsuitename=derbynetmats:derbynetmats -Dtopsuitename=derbyall
> > > org
> > > .apache.derbyTesting.functionTests.harness.RunTest
> > > derbynet/DerbyNetAutoStart.ja
> > > va
> > >
> > > Seeing next url , I found option of "-Dframework=DerbyNetClient" is
> > > needed
> > > for RunTest.
> > > http://svn.apache.org/repos/asf/incubator/derby/code/trunk/java/testing/README.htm
> > >
> > > Adding above option to RunSuite also.
> > > After that test seems to be done.
> > >
> > > Well .. I'm not sure default command option "-Dframework=DerbyNet"
> > > generated by RunSuite ....
> > >
> > > Best regards.
> > >
> > > /*
> > >
> > > Tomohito Nakayama
> > > tomonaka@basil.ocn.ne.jp
> > > tomohito@rose.zero.ad.jp
> > >
> > > Naka
> > > http://www5.ocn.ne.jp/~tomohito/TopPage.html
> > >
> > > */
> > > ----- Original Message -----
> > > From: "TomohitoNakayama" <to...@basil.ocn.ne.jp>
> > > To: "Derby Development" <de...@db.apache.org>
> > > Sent: Tuesday, May 10, 2005 8:37 PM
> > > Subject: Re: BulkInsert ? (Re: DERBY-167 has done but ...)
> > >
> > >
> > >> Hello.
> > >>
> > >> I see.
> > >> I understood bulk insert.
> > >> Thank you.
> > >> Now, I have just tryed derbyall-test problem and there seems to be
> > >> trouble in derbynet/DerbyNetAutoStart..
> > >>
> > >> I will report it in detail later.
> > >>
> > >> Best regards.
> > >> /*
> > >>
> > >> Tomohito Nakayama
> > >> tomonaka@basil.ocn.ne.jp
> > >> tomohito@rose.zero.ad.jp
> > >>
> > >> Naka
> > >> http://www5.ocn.ne.jp/~tomohito/TopPage.html
> > >>
> > >> */
> > >> ----- Original Message -----
> > >> From: "Kathey Marsden" <km...@sbcglobal.net>
> > >> To: "Derby Development" <de...@db.apache.org>
> > >> Sent: Tuesday, May 10, 2005 5:02 AM
> > >> Subject: Re: BulkInsert ? (Re: DERBY-167 has done but ...)
> > >>
> > >>
> > >>> Satheesh Bandaram wrote:
> > >>>
> > >>>> BulkInsert is an internal mechanism, that gets used when you import
> > >>>> data into a table, using Derby's import mechanism.
> > >>>> (SYSCS_UTIL.SYSCS_IMPORT_TABLE
> > >>>> <http://incubator.apache.org/derby/docs/ref/>) This is not directly
> > >>>> exposed to applications using JDBC or SQL, so there is no way to
> > >>>> directly invoke it. If you write some test cases for your feature
> > >>>> using this procedure, you are testing bulkInsert code. Are you
> > >>>> familiar with importing/exporting tables? Looking at Derby manuals
> > >>>> for
> > >>>> information would be very useful.
> > >>>
> > >>> I think you could add a test to tools/ieptests.sql
> > >>> which tests loading a table with an identity column.
> > >>>
> > >>> Kathey
> > >>>
> > >>>
> > >>>
> > >>>
> > >>>
> > >>> --
> > >>> No virus found in this incoming message.
> > >>> Checked by AVG Anti-Virus.
> > >>> Version: 7.0.308 / Virus Database: 266.11.6 - Release Date: 2005/05/06
> > >>>
> > >>
> > >>
> > >> --
> > >> No virus found in this outgoing message.
> > >> Checked by AVG Anti-Virus.
> > >> Version: 7.0.308 / Virus Database: 266.11.7 - Release Date: 2005/05/09
> > >>
> > >>
> > >>
> > >>
> > >> --
> > >> No virus found in this incoming message.
> > >> Checked by AVG Anti-Virus.
> > >> Version: 7.0.308 / Virus Database: 266.11.7 - Release Date: 2005/05/09
> > >>
> > >>
> > >
> > >
> > >
> > > --
> > > No virus found in this outgoing message.
> > > Checked by AVG Anti-Virus.
> > > Version: 7.0.308 / Virus Database: 266.11.7 - Release Date: 2005/05/09
> > >
> > >
> > >
> > >
> > > --
> > > No virus found in this incoming message.
> > > Checked by AVG Anti-Virus.
> > > Version: 7.0.308 / Virus Database: 266.11.7 - Release Date: 2005/05/09
> > >
> >
> > --
> > No virus found in this outgoing message.
> > Checked by AVG Anti-Virus.
> > Version: 7.0.308 / Virus Database: 266.11.7 - Release Date: 2005/05/09
> >
> >
>
> --
> No virus found in this incoming message.
> Checked by AVG Anti-Virus.
> Version: 7.0.308 / Virus Database: 266.11.7 - Release Date: 2005/05/09
>
> --
> No virus found in this outgoing message.
> Checked by AVG Anti-Virus.
> Version: 7.0.308 / Virus Database: 266.11.8 - Release Date: 2005/05/10
>
>
I postpone modification to dblook.(Re: Patch again again for DERBY-167.)
Posted by TomohitoNakayama <to...@basil.ocn.ne.jp>.
Hello.
I decide to postpone modification of dblook.
Modification itself is not difficult.
However , it is needed to know all about SYSTEM table , to check
modification was correctly done.
It is a little hard for me to understand all about SYSTEM table right now.
//This may be suitable for my next task ...
Best regards.
/*
Tomohito Nakayama
tomonaka@basil.ocn.ne.jp
tomohito@rose.zero.ad.jp
Naka
http://www5.ocn.ne.jp/~tomohito/TopPage.html
*/
----- Original Message -----
From: "TomohitoNakayama" <to...@basil.ocn.ne.jp>
To: "Derby Development" <de...@db.apache.org>
Sent: Wednesday, May 18, 2005 11:36 PM
Subject: Re: Patch again again for DERBY-167.
> Hello.
>
> Daniel John Debrunner wrote:
>
>>> 1st:
>>>
>>>> The Derby "dblook" utility will have to be modified to account for the
>>>> "BY DEFAULT" keyword--right now, it generates all autoincrement
>>>> columns using the "ALWAYS" keyword. See
>>>> org/apache/derby/impl/tools/dblook/DB_Table.java, in the
>>>> "reinsateAutoIncrement" method. Luckily, this change should be fairly
>>>> easy given the changes in your patch.
>>>
>>>
>>> I see.
>>> I will modify dblook.
>>> Thank you for your notifying :D
>>
>> The dblook changes could be a separate patch. Incremental development
>> is a good process, rather than requiring all the related changes to
>> be in one huge patch.
>
> Well ....
> I just have started modification of dblook.
> Then I will include it.
> But if encountered some problem , I will postpone it for other task.
>
>
>> if (defaultInfo != null && ! colDesc.isAutoincrement())
>>
>> it would be good to add some descriptive comment. The issue here is that
>> the test is two negative conditions 'anded (&&)' together. Somewhat hard
>> for humans (well at least me) to understand quickly. A comment is also
>> useful for the original coder to help them ensure they have the correct
>> condition.
>
> Well ....
> This condition is surely difficult.
> Comment will be needed .
> I will add.
>
> Sometimes comment can be barrier for reading code.
> Therefore, I hesitate to write comment.
>
>
>> BITS_MASK_IS_DEFAULTVALUE_AUTOINC should be 'final' if it is intended to
>> be a constant.
>>
>> In DefaultInfoImpl the calculating of definitionBits and
>> isDefaultValueAutoinc using those static methods seems too complex. If
>> there are ever a few more types to calculate we end up with a lot of
>> code to deal with it. Why not just have a single instance field
>> representing the type (matching your defintion bits), remove
>> isDefaultValueAutoinc field. Then the read/writeExternal methods just
>> write the type directly, and the isDefaultValueAutoinc method is
>> something like
>>
>> + public boolean isDefaultValueAutoinc(){
>> + return (type & BITS_MASK_IS_DEFAULTVALUE_AUTOINC) != 0;
>> + }
>
> I hesitated calculating each time calling isDefaultValueAutoinc() method.
> Well .... But its very small price.
> Price of calculating each time will correspond to simple code.
> I will modify it.
>
>
> Best regards.
>
>
> /*
>
> Tomohito Nakayama
> tomonaka@basil.ocn.ne.jp
> tomohito@rose.zero.ad.jp
>
> Naka
> http://www5.ocn.ne.jp/~tomohito/TopPage.html
>
> */
> ----- Original Message -----
> From: "Daniel John Debrunner" <dj...@debrunners.com>
> To: "Derby Development" <de...@db.apache.org>
> Sent: Wednesday, May 18, 2005 10:22 PM
> Subject: Re: Patch again again for DERBY-167.
>
>
>> TomohitoNakayama wrote:
>>
>>> Hello.
>>>
>>> 1st:
>>>
>>>> The Derby "dblook" utility will have to be modified to account for the
>>>> "BY DEFAULT" keyword--right now, it generates all autoincrement
>>>> columns using the "ALWAYS" keyword. See
>>>> org/apache/derby/impl/tools/dblook/DB_Table.java, in the
>>>> "reinsateAutoIncrement" method. Luckily, this change should be fairly
>>>> easy given the changes in your patch.
>>>
>>>
>>> I see.
>>> I will modify dblook.
>>> Thank you for your notifying :D
>>
>> The dblook changes could be a separate patch. Incremental development
>> is a good process, rather than requiring all the related changes to
>> be in one huge patch.
>>
>>
>>> 2nd:
>>>
>>>> Second (minor):
>>>>
>>>> I noticed that in DefaultInfoImpl.java, the two new methods
>>>> (getDefinitionBitsValue and calcIsDefaultValueAutoinc) are declared as
>>>> static--is there a reason for that? I made them non-static and
>>>> everything compiled, so I'm just wondering if this was intentional?
>>>
>>>
>>> Yes. That was intentional.
>>>
>>> I prefer static method because it have narrower scope than instance
>>> method.
>>
>> I agree, static methods are the correct type here.
>>
>>
>> I would encourage you (and anyone else) to keep any description (or
>> modified version of it) from the original patch e-mail in newer e-mails
>> with modified patches. This makes it easier for the committers to
>> understand and track patches. E.g. you last Derby-167 patch just had the
>> patch attached, you should keep any description from the first e-mail
>> with the patch. Another reason is that the description may have changed
>> due to comments etc.
>>
>>
>> In general the patch looks good, thanks for making changes for my
>> previous feedback.
>>
>> Some minor comments on the patch:
>>
>> In ResultSetNode and ColumnDefintionNode for this line you changed
>>
>> if (defaultInfo != null && ! colDesc.isAutoincrement())
>>
>> it would be good to add some descriptive comment. The issue here is that
>> the test is two negative conditions 'anded (&&)' together. Somewhat hard
>> for humans (well at least me) to understand quickly. A comment is also
>> useful for the original coder to help them ensure they have the correct
>> condition.
>>
>> BITS_MASK_IS_DEFAULTVALUE_AUTOINC should be 'final' if it is intended to
>> be a constant.
>>
>> In DefaultInfoImpl the calculating of definitionBits and
>> isDefaultValueAutoinc using those static methods seems too complex. If
>> there are ever a few more types to calculate we end up with a lot of
>> code to deal with it. Why not just have a single instance field
>> representing the type (matching your defintion bits), remove
>> isDefaultValueAutoinc field. Then the read/writeExternal methods just
>> write the type directly, and the isDefaultValueAutoinc method is
>> something like
>>
>> + public boolean isDefaultValueAutoinc(){
>> + return (type & BITS_MASK_IS_DEFAULTVALUE_AUTOINC) != 0;
>> + }
>>
>>
>> Dan.
>>
>>
>>
>>
>>
>> --
>> No virus found in this incoming message.
>> Checked by AVG Anti-Virus.
>> Version: 7.0.308 / Virus Database: 266.11.12 - Release Date: 2005/05/17
>>
>
>
>
> --
> No virus found in this outgoing message.
> Checked by AVG Anti-Virus.
> Version: 7.0.308 / Virus Database: 266.11.12 - Release Date: 2005/05/17
>
>
>
>
> --
> No virus found in this incoming message.
> Checked by AVG Anti-Virus.
> Version: 7.0.308 / Virus Database: 266.11.12 - Release Date: 2005/05/17
>
--
No virus found in this outgoing message.
Checked by AVG Anti-Virus.
Version: 7.0.322 / Virus Database: 266.11.12 - Release Date: 2005/05/17
Re: Patch again again for DERBY-167.
Posted by TomohitoNakayama <to...@basil.ocn.ne.jp>.
Hello.
Daniel John Debrunner wrote:
>> 1st:
>>
>>> The Derby "dblook" utility will have to be modified to account for the
>>> "BY DEFAULT" keyword--right now, it generates all autoincrement
>>> columns using the "ALWAYS" keyword. See
>>> org/apache/derby/impl/tools/dblook/DB_Table.java, in the
>>> "reinsateAutoIncrement" method. Luckily, this change should be fairly
>>> easy given the changes in your patch.
>>
>>
>> I see.
>> I will modify dblook.
>> Thank you for your notifying :D
>
> The dblook changes could be a separate patch. Incremental development
> is a good process, rather than requiring all the related changes to
> be in one huge patch.
Well ....
I just have started modification of dblook.
Then I will include it.
But if encountered some problem , I will postpone it for other task.
> if (defaultInfo != null && ! colDesc.isAutoincrement())
>
> it would be good to add some descriptive comment. The issue here is that
> the test is two negative conditions 'anded (&&)' together. Somewhat hard
> for humans (well at least me) to understand quickly. A comment is also
> useful for the original coder to help them ensure they have the correct
> condition.
Well ....
This condition is surely difficult.
Comment will be needed .
I will add.
Sometimes comment can be barrier for reading code.
Therefore, I hesitate to write comment.
> BITS_MASK_IS_DEFAULTVALUE_AUTOINC should be 'final' if it is intended to
> be a constant.
>
> In DefaultInfoImpl the calculating of definitionBits and
> isDefaultValueAutoinc using those static methods seems too complex. If
> there are ever a few more types to calculate we end up with a lot of
> code to deal with it. Why not just have a single instance field
> representing the type (matching your defintion bits), remove
> isDefaultValueAutoinc field. Then the read/writeExternal methods just
> write the type directly, and the isDefaultValueAutoinc method is
> something like
>
> + public boolean isDefaultValueAutoinc(){
> + return (type & BITS_MASK_IS_DEFAULTVALUE_AUTOINC) != 0;
> + }
I hesitated calculating each time calling isDefaultValueAutoinc() method.
Well .... But its very small price.
Price of calculating each time will correspond to simple code.
I will modify it.
Best regards.
/*
Tomohito Nakayama
tomonaka@basil.ocn.ne.jp
tomohito@rose.zero.ad.jp
Naka
http://www5.ocn.ne.jp/~tomohito/TopPage.html
*/
----- Original Message -----
From: "Daniel John Debrunner" <dj...@debrunners.com>
To: "Derby Development" <de...@db.apache.org>
Sent: Wednesday, May 18, 2005 10:22 PM
Subject: Re: Patch again again for DERBY-167.
> TomohitoNakayama wrote:
>
>> Hello.
>>
>> 1st:
>>
>>> The Derby "dblook" utility will have to be modified to account for the
>>> "BY DEFAULT" keyword--right now, it generates all autoincrement
>>> columns using the "ALWAYS" keyword. See
>>> org/apache/derby/impl/tools/dblook/DB_Table.java, in the
>>> "reinsateAutoIncrement" method. Luckily, this change should be fairly
>>> easy given the changes in your patch.
>>
>>
>> I see.
>> I will modify dblook.
>> Thank you for your notifying :D
>
> The dblook changes could be a separate patch. Incremental development
> is a good process, rather than requiring all the related changes to
> be in one huge patch.
>
>
>> 2nd:
>>
>>> Second (minor):
>>>
>>> I noticed that in DefaultInfoImpl.java, the two new methods
>>> (getDefinitionBitsValue and calcIsDefaultValueAutoinc) are declared as
>>> static--is there a reason for that? I made them non-static and
>>> everything compiled, so I'm just wondering if this was intentional?
>>
>>
>> Yes. That was intentional.
>>
>> I prefer static method because it have narrower scope than instance
>> method.
>
> I agree, static methods are the correct type here.
>
>
> I would encourage you (and anyone else) to keep any description (or
> modified version of it) from the original patch e-mail in newer e-mails
> with modified patches. This makes it easier for the committers to
> understand and track patches. E.g. you last Derby-167 patch just had the
> patch attached, you should keep any description from the first e-mail
> with the patch. Another reason is that the description may have changed
> due to comments etc.
>
>
> In general the patch looks good, thanks for making changes for my
> previous feedback.
>
> Some minor comments on the patch:
>
> In ResultSetNode and ColumnDefintionNode for this line you changed
>
> if (defaultInfo != null && ! colDesc.isAutoincrement())
>
> it would be good to add some descriptive comment. The issue here is that
> the test is two negative conditions 'anded (&&)' together. Somewhat hard
> for humans (well at least me) to understand quickly. A comment is also
> useful for the original coder to help them ensure they have the correct
> condition.
>
> BITS_MASK_IS_DEFAULTVALUE_AUTOINC should be 'final' if it is intended to
> be a constant.
>
> In DefaultInfoImpl the calculating of definitionBits and
> isDefaultValueAutoinc using those static methods seems too complex. If
> there are ever a few more types to calculate we end up with a lot of
> code to deal with it. Why not just have a single instance field
> representing the type (matching your defintion bits), remove
> isDefaultValueAutoinc field. Then the read/writeExternal methods just
> write the type directly, and the isDefaultValueAutoinc method is
> something like
>
> + public boolean isDefaultValueAutoinc(){
> + return (type & BITS_MASK_IS_DEFAULTVALUE_AUTOINC) != 0;
> + }
>
>
> Dan.
>
>
>
>
>
> --
> No virus found in this incoming message.
> Checked by AVG Anti-Virus.
> Version: 7.0.308 / Virus Database: 266.11.12 - Release Date: 2005/05/17
>
--
No virus found in this outgoing message.
Checked by AVG Anti-Virus.
Version: 7.0.308 / Virus Database: 266.11.12 - Release Date: 2005/05/17
Re: Patch again again for DERBY-167.
Posted by Daniel John Debrunner <dj...@debrunners.com>.
TomohitoNakayama wrote:
> Hello.
>
> 1st:
>
>> The Derby "dblook" utility will have to be modified to account for the
>> "BY DEFAULT" keyword--right now, it generates all autoincrement
>> columns using the "ALWAYS" keyword. See
>> org/apache/derby/impl/tools/dblook/DB_Table.java, in the
>> "reinsateAutoIncrement" method. Luckily, this change should be fairly
>> easy given the changes in your patch.
>
>
> I see.
> I will modify dblook.
> Thank you for your notifying :D
The dblook changes could be a separate patch. Incremental development
is a good process, rather than requiring all the related changes to
be in one huge patch.
> 2nd:
>
>> Second (minor):
>>
>> I noticed that in DefaultInfoImpl.java, the two new methods
>> (getDefinitionBitsValue and calcIsDefaultValueAutoinc) are declared as
>> static--is there a reason for that? I made them non-static and
>> everything compiled, so I'm just wondering if this was intentional?
>
>
> Yes. That was intentional.
>
> I prefer static method because it have narrower scope than instance method.
I agree, static methods are the correct type here.
I would encourage you (and anyone else) to keep any description (or
modified version of it) from the original patch e-mail in newer e-mails
with modified patches. This makes it easier for the committers to
understand and track patches. E.g. you last Derby-167 patch just had the
patch attached, you should keep any description from the first e-mail
with the patch. Another reason is that the description may have changed
due to comments etc.
In general the patch looks good, thanks for making changes for my
previous feedback.
Some minor comments on the patch:
In ResultSetNode and ColumnDefintionNode for this line you changed
if (defaultInfo != null && ! colDesc.isAutoincrement())
it would be good to add some descriptive comment. The issue here is that
the test is two negative conditions 'anded (&&)' together. Somewhat hard
for humans (well at least me) to understand quickly. A comment is also
useful for the original coder to help them ensure they have the correct
condition.
BITS_MASK_IS_DEFAULTVALUE_AUTOINC should be 'final' if it is intended to
be a constant.
In DefaultInfoImpl the calculating of definitionBits and
isDefaultValueAutoinc using those static methods seems too complex. If
there are ever a few more types to calculate we end up with a lot of
code to deal with it. Why not just have a single instance field
representing the type (matching your defintion bits), remove
isDefaultValueAutoinc field. Then the read/writeExternal methods just
write the type directly, and the isDefaultValueAutoinc method is
something like
+ public boolean isDefaultValueAutoinc(){
+ return (type & BITS_MASK_IS_DEFAULTVALUE_AUTOINC) != 0;
+ }
Dan.
Re: Patch again again for DERBY-167.
Posted by TomohitoNakayama <to...@basil.ocn.ne.jp>.
Hello.
1st:
> The Derby "dblook" utility will have to be modified to account for the "BY
> DEFAULT" keyword--right now, it generates all autoincrement columns using
> the "ALWAYS" keyword. See
> org/apache/derby/impl/tools/dblook/DB_Table.java, in the
> "reinsateAutoIncrement" method. Luckily, this change should be fairly
> easy given the changes in your patch.
I see.
I will modify dblook.
Thank you for your notifying :D
2nd:
> Second (minor):
>
> I noticed that in DefaultInfoImpl.java, the two new methods
> (getDefinitionBitsValue and calcIsDefaultValueAutoinc) are declared as
> static--is there a reason for that? I made them non-static and everything
> compiled, so I'm just wondering if this was intentional?
Yes. That was intentional.
I prefer static method because it have narrower scope than instance method.
Static method can not access instance variable.
On the contrast , calling instance method would change instance variable ,
and state of the object so on.
Then , I prefer static method than instance methood.
I know method , which are to be overridden , must be instance method.
But I think those methods which I added was not such methods.
Best regards.
/*
Tomohito Nakayama
tomonaka@basil.ocn.ne.jp
tomohito@rose.zero.ad.jp
Naka
http://www5.ocn.ne.jp/~tomohito/TopPage.html
*/
----- Original Message -----
From: "Army" <qo...@sbcglobal.net>
To: "Derby Development" <de...@db.apache.org>
Sent: Tuesday, May 17, 2005 9:50 AM
Subject: Re: Patch again again for DERBY-167.
> TomohitoNakayama wrote:
>> Hello.
>>
>> I send new patch for DERBY-167 , which is attached to this mail.
>> Please review it.
>
> Thanks for the sending the new patch.
>
> I've reviewed it and I have the following comments. The first one is an
> important one, the second one is very minor.
>
> First:
>
> The Derby "dblook" utility will have to be modified to account for the "BY
> DEFAULT" keyword--right now, it generates all autoincrement columns using
> the "ALWAYS" keyword. See
> org/apache/derby/impl/tools/dblook/DB_Table.java, in the
> "reinsateAutoIncrement" method. Luckily, this change should be fairly
> easy given the changes in your patch.
>
> Since your patch sets the "DefaultInfo" for a BY DEFAULT column to a
> non-null value, I think dblook can just check the "COLUMNDEFAULT" column
> in the SYS.SYSCOLUMNS table. If it is _not_ null, then dblook can
> generate "BY DEFAULT" instead of "ALWAYS".
>
> For example, you could change the "getAutoIncStmt" statement at the top of
> DB_Table.java to retrieve the COLUMNDEFAULT column:
>
> getAutoIncStmt =
> conn.prepareStatement("SELECT AUTOINCREMENTSTART, " +
> "AUTOINCREMENTINC, COLUMNDEFAULT FROM SYS.SYSCOLUMNS " +
> "WHERE COLUMNNAME = ? AND REFERENCEID = ?");
>
> and then change the "reinstateAutoIncrement(...)" method to do the
> following:
>
> .
> .
> .
> if (autoIncCols.next()) {
> long start = autoIncCols.getLong(1);
> if (!autoIncCols.wasNull()) {
> colDef.append(" GENERATED ");
> // -- begin new logic --
> String def = autoIncCols.getString(3);
> colDef.append(autoIncCols.wasNull() ? "ALWAYS" : "BY DEFAULT");
> // -- end new logic --
> colDef.append(" AS IDENTITY (START WITH ");
> colDef.append(autoIncCols.getLong(1));
> colDef.append(", INCREMENT BY ");
> colDef.append(autoIncCols.getLong(2));
> colDef.append(")");
> }
> }
>
> This will make it so that dblook generates "BY DEFAULT" correctly for
> columns that require it.
>
> And then it'd probably be good to add a case for this in
> java/testing/org/apache/derbyTesting/tests/tools/dblook_makeDB.sql, which
> is the script that is used for testing dblook. In that script, there's a
> section under the "Tables" heading that indicates "auto increment/default"
> test cases. You could add a simple table for the "GENERATED BY DEFAULT"
> case. If you have any problems getting that to work, feel free to post
> your questions and I'll try to help where I can.
>
> Second (minor):
>
> I noticed that in DefaultInfoImpl.java, the two new methods
> (getDefinitionBitsValue and calcIsDefaultValueAutoinc) are declared as
> static--is there a reason for that? I made them non-static and everything
> compiled, so I'm just wondering if this was intentional?
>
> Thanks again for re-sending the patch, and please feel free to ask if you
> have any questions about I've written here.
>
> Army
>
>
>
>
> --
> No virus found in this incoming message.
> Checked by AVG Anti-Virus.
> Version: 7.0.308 / Virus Database: 266.11.11 - Release Date: 2005/05/16
>
>
--
No virus found in this outgoing message.
Checked by AVG Anti-Virus.
Version: 7.0.308 / Virus Database: 266.11.12 - Release Date: 2005/05/17
Re: Patch again again for DERBY-167.
Posted by Army <qo...@sbcglobal.net>.
TomohitoNakayama wrote:
> Hello.
>
> I send new patch for DERBY-167 , which is attached to this mail.
> Please review it.
Thanks for the sending the new patch.
I've reviewed it and I have the following comments. The first one is an
important one, the second one is very minor.
First:
The Derby "dblook" utility will have to be modified to account for the "BY
DEFAULT" keyword--right now, it generates all autoincrement columns using the
"ALWAYS" keyword. See org/apache/derby/impl/tools/dblook/DB_Table.java, in the
"reinsateAutoIncrement" method. Luckily, this change should be fairly easy
given the changes in your patch.
Since your patch sets the "DefaultInfo" for a BY DEFAULT column to a non-null
value, I think dblook can just check the "COLUMNDEFAULT" column in the
SYS.SYSCOLUMNS table. If it is _not_ null, then dblook can generate "BY
DEFAULT" instead of "ALWAYS".
For example, you could change the "getAutoIncStmt" statement at the top of
DB_Table.java to retrieve the COLUMNDEFAULT column:
getAutoIncStmt =
conn.prepareStatement("SELECT AUTOINCREMENTSTART, " +
"AUTOINCREMENTINC, COLUMNDEFAULT FROM SYS.SYSCOLUMNS " +
"WHERE COLUMNNAME = ? AND REFERENCEID = ?");
and then change the "reinstateAutoIncrement(...)" method to do the following:
.
.
.
if (autoIncCols.next()) {
long start = autoIncCols.getLong(1);
if (!autoIncCols.wasNull()) {
colDef.append(" GENERATED ");
// -- begin new logic --
String def = autoIncCols.getString(3);
colDef.append(autoIncCols.wasNull() ? "ALWAYS" : "BY DEFAULT");
// -- end new logic --
colDef.append(" AS IDENTITY (START WITH ");
colDef.append(autoIncCols.getLong(1));
colDef.append(", INCREMENT BY ");
colDef.append(autoIncCols.getLong(2));
colDef.append(")");
}
}
This will make it so that dblook generates "BY DEFAULT" correctly for columns
that require it.
And then it'd probably be good to add a case for this in
java/testing/org/apache/derbyTesting/tests/tools/dblook_makeDB.sql, which is the
script that is used for testing dblook. In that script, there's a section under
the "Tables" heading that indicates "auto increment/default" test cases. You
could add a simple table for the "GENERATED BY DEFAULT" case. If you have any
problems getting that to work, feel free to post your questions and I'll try to
help where I can.
Second (minor):
I noticed that in DefaultInfoImpl.java, the two new methods
(getDefinitionBitsValue and calcIsDefaultValueAutoinc) are declared as
static--is there a reason for that? I made them non-static and everything
compiled, so I'm just wondering if this was intentional?
Thanks again for re-sending the patch, and please feel free to ask if you have
any questions about I've written here.
Army
Re: Patch again again for DERBY-167.
Posted by TomohitoNakayama <to...@basil.ocn.ne.jp>.
Hello.
>ColumnDefinitionNode: I would like to see following comments be more
>descriptive. Initially I thought these refer to another method, but that is
>not the case.
>+ //validateDefaultOfAutoInc
>+ //validateDefaultOfDefault
Firstly I thought make each part as separated method.
But I abort it because separated method will make it difficult to see how
instance variable of defaultInfo are handled.
I will write a English sentence there.
>ColumnDescriptor.java: Is there an extra assert for autoincInc being
>non-zero at line: 156
I will erase unnecessary part...
>Also 'static' is not needed for assertAutoinc() method.
As written in reply mail for Army , I prefer static method .....
How should do it ...?
Best regards.
/*
Tomohito Nakayama
tomonaka@basil.ocn.ne.jp
tomohito@rose.zero.ad.jp
Naka
http://www5.ocn.ne.jp/~tomohito/TopPage.html
*/
----- Original Message -----
From: Satheesh Bandaram
To: Derby Development
Sent: Wednesday, May 18, 2005 10:00 AM
Subject: Re: Patch again again for DERBY-167.
Thanks for applying review comments. Overall, the patch looks good.
Some minor comments:
ColumnDefinitionNode: I would like to see following comments be more
descriptive. Initially I thought these refer to another method, but that is
not the case.
+ //validateDefaultOfAutoInc
+ //validateDefaultOfDefault
ColumnDescriptor.java: Is there an extra assert for autoincInc being
non-zero at line: 156? (Second constructor). Also 'static' is not needed for
assertAutoinc() method.
Please apply Army's and my comments. I also invite others to review the
patch, since I will be looking to commit this one soon, after getting an
updated patch. :-)
Satheesh
TomohitoNakayama wrote:
Hello.
I send new patch for DERBY-167 , which is attached to this mail.
Please review it.
Best regards.
/*
Tomohito Nakayama
tomonaka@basil.ocn.ne.jp
tomohito@rose.zero.ad.jp
Naka
http://www5.ocn.ne.jp/~tomohito/TopPage.html
*/
----- Original Message ----- From: "Army" <qo...@sbcglobal.net>
To: "Derby Development" <de...@db.apache.org>
Sent: Saturday, May 14, 2005 9:13 AM
Subject: Re: Patch again for DERBY-167.
TomohitoNakayama wrote:
Hello.
I send new patch for DERBY-167.
Please review it again.
I tried to apply this patch to my local codeline (which I just updated) so
that I could review it more closely, but the patch fails to apply in
several places.
I know it's annoying, but could you perhaps "svn update" your codeline and
then re-create the patch based on the latest files?
If I can get the patch to apply, it makes it easier to review the code.
Also, I can then run the new/updated tests and verify that everything
works as intended...
Thanks,
Army
--
No virus found in this incoming message.
Checked by AVG Anti-Virus.
Version: 7.0.308 / Virus Database: 266.11.10 - Release Date: 2005/05/13
No virus found in this outgoing message.
Checked by AVG Anti-Virus.
Version: 7.0.308 / Virus Database: 266.11.10 - Release Date: 2005/05/13
No virus found in this incoming message.
Checked by AVG Anti-Virus.
Version: 7.0.308 / Virus Database: 266.11.12 - Release Date: 2005/05/17
--
No virus found in this outgoing message.
Checked by AVG Anti-Virus.
Version: 7.0.308 / Virus Database: 266.11.12 - Release Date: 2005/05/17
Patch again again for DERBY-167.
Posted by TomohitoNakayama <to...@basil.ocn.ne.jp>.
Hello.
I send new patch for DERBY-167 , which is attached to this mail.
Please review it.
Best regards.
/*
Tomohito Nakayama
tomonaka@basil.ocn.ne.jp
tomohito@rose.zero.ad.jp
Naka
http://www5.ocn.ne.jp/~tomohito/TopPage.html
*/
----- Original Message -----
From: "Army" <qo...@sbcglobal.net>
To: "Derby Development" <de...@db.apache.org>
Sent: Saturday, May 14, 2005 9:13 AM
Subject: Re: Patch again for DERBY-167.
> TomohitoNakayama wrote:
>> Hello.
>>
>> I send new patch for DERBY-167.
>> Please review it again.
>
> I tried to apply this patch to my local codeline (which I just updated) so
> that I could review it more closely, but the patch fails to apply in
> several places.
>
> I know it's annoying, but could you perhaps "svn update" your codeline and
> then re-create the patch based on the latest files?
>
> If I can get the patch to apply, it makes it easier to review the code.
> Also, I can then run the new/updated tests and verify that everything
> works as intended...
>
> Thanks,
> Army
>
>
>
>
> --
> No virus found in this incoming message.
> Checked by AVG Anti-Virus.
> Version: 7.0.308 / Virus Database: 266.11.10 - Release Date: 2005/05/13
>
>
Re: Patch again for DERBY-167.
Posted by Army <qo...@sbcglobal.net>.
TomohitoNakayama wrote:
> Hello.
>
> I send new patch for DERBY-167.
> Please review it again.
I tried to apply this patch to my local codeline (which I just updated) so that
I could review it more closely, but the patch fails to apply in several places.
I know it's annoying, but could you perhaps "svn update" your codeline and then
re-create the patch based on the latest files?
If I can get the patch to apply, it makes it easier to review the code. Also, I
can then run the new/updated tests and verify that everything works as intended...
Thanks,
Army
Re: Patch again for DERBY-167.
Posted by TomohitoNakayama <to...@basil.ocn.ne.jp>.
Hello.
Daniel John Debrunner wrote:
> Hard upgrade works currently, I checked in a manual test under
> java/testing/org/apache/derbyTesting/upgradeTests.
Do you means that upgrade=true option surely update DD_Version in database ?
If so, I might mistake what happened at my testing.
Any way , I will check hardupgrade test again.
Best regards.
/*
Tomohito Nakayama
tomonaka@basil.ocn.ne.jp
tomohito@rose.zero.ad.jp
Naka
http://www5.ocn.ne.jp/~tomohito/TopPage.html
*/
----- Original Message -----
From: "Daniel John Debrunner" <dj...@debrunners.com>
To: "Derby Development" <de...@db.apache.org>
Sent: Friday, May 13, 2005 1:23 AM
Subject: Re: Patch again for DERBY-167.
> TomohitoNakayama wrote:
>> Hello.
>>
>>
>> I send new patch for DERBY-167.
>> Please review it again.
>>
>>
>> I have one question.
>>
>> There seems to be NO implementation to update externalized DD_Version.
>> So now, hardupgrade does not works and we can't use BY DEFAULT .
>>
>> Should it be implemented in this task ?
>>
>> I have hesitation about updating version info myself ....
>
> I don't understand your question.
>
> In the previous e-mails I had thought that the only upgrade change
> required was the checkVersion if specifying BY DEFAULT.
>
>
> Hard upgrade works currently, I checked in a manual test under
> java/testing/org/apache/derbyTesting/upgradeTests. It doesn't run as
> part of the test harness and thius is not part of derbyall. This is
> because it boots several JVMs sequentially with different class paths
> (e.g. old version and new version). There is a shell script to run the
> test, runphases.ksh
>
> Dan.
>
>
>
>
>
> --
> No virus found in this incoming message.
> Checked by AVG Anti-Virus.
> Version: 7.0.308 / Virus Database: 266.11.9 - Release Date: 2005/05/12
>
--
No virus found in this outgoing message.
Checked by AVG Anti-Virus.
Version: 7.0.308 / Virus Database: 266.11.9 - Release Date: 2005/05/12
Re: Patch again for DERBY-167.
Posted by Daniel John Debrunner <dj...@debrunners.com>.
TomohitoNakayama wrote:
> Hello.
>
>
> I send new patch for DERBY-167.
> Please review it again.
>
>
> I have one question.
>
> There seems to be NO implementation to update externalized DD_Version.
> So now, hardupgrade does not works and we can't use BY DEFAULT .
>
> Should it be implemented in this task ?
>
> I have hesitation about updating version info myself ....
I don't understand your question.
In the previous e-mails I had thought that the only upgrade change
required was the checkVersion if specifying BY DEFAULT.
Hard upgrade works currently, I checked in a manual test under
java/testing/org/apache/derbyTesting/upgradeTests. It doesn't run as
part of the test harness and thius is not part of derbyall. This is
because it boots several JVMs sequentially with different class paths
(e.g. old version and new version). There is a shell script to run the
test, runphases.ksh
Dan.
Patch again for DERBY-167.
Posted by TomohitoNakayama <to...@basil.ocn.ne.jp>.
Hello.
I send new patch for DERBY-167.
Please review it again.
I have one question.
There seems to be NO implementation to update externalized DD_Version.
So now, hardupgrade does not works and we can't use BY DEFAULT .
Should it be implemented in this task ?
I have hesitation about updating version info myself ....
Best regards.
/*
Tomohito Nakayama
tomonaka@basil.ocn.ne.jp
tomohito@rose.zero.ad.jp
Naka
http://www5.ocn.ne.jp/~tomohito/TopPage.html
*/
----- Original Message -----
From: Satheesh Bandaram
To: Derby Development
Sent: Thursday, May 12, 2005 9:21 AM
Subject: Re: "-Dframework=DerbyNetClient"? (Re: BulkInsert ? (Re:
DERBY-167 has done but ...))
Hi Tomohito,
How is the patch comming along? Were you able to apply both Dan's and my
comments? Glad you resolved the problem with derbyAll suite. Post your patch
when ready to be reviewed.
I have created a sub-task (Derby-275) to document new syntax once done. We
don't have to worry about this for now.
Do attempt both soft-upgrade and full upgrades to see if the patch works
as expected.
Satheesh
TomohitoNakayama wrote:
Hello.
In derbynetmats.properties,
http://svn.apache.org/repos/asf/incubator/derby/code/trunk/java/testing/org/apache/derbyTesting/functionTests/suites/derbynetmats.properties
cofiguration was as next ...
framework=DerbyNet
I think this should be ,
framework=DerbyNetClient.
This may be reason....
#And second reason is that I don't know much about common knoledge of
test suite ;P
#I feel that derbyall test suite does not suit for my task....
Thanks.
Best regards.
/*
Tomohito Nakayama
tomonaka@basil.ocn.ne.jp
tomohito@rose.zero.ad.jp
Naka
http://www5.ocn.ne.jp/~tomohito/TopPage.html
*/
----- Original Message ----- From: "Myrna van Lunteren"
<m....@gmail.com>
To: "Derby Development" <de...@db.apache.org>
Sent: Wednesday, May 11, 2005 2:04 AM
Subject: Re: "-Dframework=DerbyNetClient"? (Re: BulkInsert ? (Re:
DERBY-167 has done but ...))
Hi,
Well, derbyall runs derbynetmats & derbynetclientmats. With
derbynetmats, the intent of the suite is to test derbynet, i.e.
networkserver via IBMs Universal JDBC driver ('db2jcc*.jar'). With
derbynetclientmats, the intent of the suite is to test the (new)
derbyclient - and thus, in that subsuite, -Dframework=DerbyNetClient.
So, it's not the default, the default framework is none - which means,
using the embedded driver & not networkserver at all. The property
gets set by the harness because it's in the derbynetmats.properties
file.
RunSuite derbyall should not be run with any framework properties
passed in...the individual suites will add the framework properties as
needed.
As to why you got a hang...??? If you have the db2jcc*.jar in your
classpath, it should just run, if you don't it should just skip that
test. I've not seen that test hang recently...You should check what
the last thing is the test did - this you would see in the .tmp file.
Also, do other derbynetmats tests pass? Also, the derbynet.out and
derbynet.err (drill down into the derbynetmats dir untill you find
them) will have more info.
Myrna
On 5/10/05, TomohitoNakayama <to...@basil.ocn.ne.jp> wrote:
Follows ....
> Well .. I'm not sure default command option "-Dframework=DerbyNet"
> generated by RunSuite ....
This means that I wonder why default of the option is this value...
Best regards.
/*
Tomohito Nakayama
tomonaka@basil.ocn.ne.jp
tomohito@rose.zero.ad.jp
Naka
http://www5.ocn.ne.jp/~tomohito/TopPage.html
*/
----- Original Message -----
From: "TomohitoNakayama" <to...@basil.ocn.ne.jp>
To: "Derby Development" <de...@db.apache.org>
Sent: Tuesday, May 10, 2005 10:45 PM
Subject: "-Dframework=DerbyNetClient"? (Re: BulkInsert ? (Re:
DERBY-167 has
done but ...))
> Hello.
>
> I have tried alljava test suite , but failed in executing
> DerbyNetAutoStart.
> Many hours but the test does not finised.
>
> Executing command generated by RunSuite for that test was as next:
> Execute command:
> java -DjavaCmd=java -Dframework=DerbyNet -Dtimeout=60 -Djdk12te
>
st=true -Doutputdir=C:\ProgramDev\derbyUser\derbyall.20050510\derbyall\derbynetm
>
ats\DerbyNet\derbynetmats -Dtopsuitedir=C:\ProgramDev\derbyUser\derbyall.2005051
>
0\derbyall\derbynetmats\DerbyNet -Dtopreportdir=C:\ProgramDev\derbyUser\derbyall
>
.20050510\derbyall\derbynetmats -Drundir=C:\ProgramDev\derbyUser\derbyall.200505
>
10 -DtestSpecialProps=derby.debug.true=enableBtreeConsistencyCheck^derby.stream.
>
error.logSeverityLevel=0^excludeJCC=at-or-after:3.0,when-at-or-before:jdk1.3.1^r
>
unwithj9=false -Dsuitename=derbynetmats:derbynetmats -Dtopsuitename=derbyall
> org
> .apache.derbyTesting.functionTests.harness.RunTest
> derbynet/DerbyNetAutoStart.ja
> va
>
> Seeing next url , I found option of "-Dframework=DerbyNetClient" is
> needed
> for RunTest.
>
http://svn.apache.org/repos/asf/incubator/derby/code/trunk/java/testing/README.htm
>
> Adding above option to RunSuite also.
> After that test seems to be done.
>
> Well .. I'm not sure default command option "-Dframework=DerbyNet"
> generated by RunSuite ....
>
> Best regards.
>
> /*
>
> Tomohito Nakayama
> tomonaka@basil.ocn.ne.jp
> tomohito@rose.zero.ad.jp
>
> Naka
> http://www5.ocn.ne.jp/~tomohito/TopPage.html
>
> */
> ----- Original Message -----
> From: "TomohitoNakayama" <to...@basil.ocn.ne.jp>
> To: "Derby Development" <de...@db.apache.org>
> Sent: Tuesday, May 10, 2005 8:37 PM
> Subject: Re: BulkInsert ? (Re: DERBY-167 has done but ...)
>
>
>> Hello.
>>
>> I see.
>> I understood bulk insert.
>> Thank you.
>> Now, I have just tryed derbyall-test problem and there seems to be
>> trouble in derbynet/DerbyNetAutoStart..
>>
>> I will report it in detail later.
>>
>> Best regards.
>> /*
>>
>> Tomohito Nakayama
>> tomonaka@basil.ocn.ne.jp
>> tomohito@rose.zero.ad.jp
>>
>> Naka
>> http://www5.ocn.ne.jp/~tomohito/TopPage.html
>>
>> */
>> ----- Original Message -----
>> From: "Kathey Marsden" <km...@sbcglobal.net>
>> To: "Derby Development" <de...@db.apache.org>
>> Sent: Tuesday, May 10, 2005 5:02 AM
>> Subject: Re: BulkInsert ? (Re: DERBY-167 has done but ...)
>>
>>
>>> Satheesh Bandaram wrote:
>>>
>>>> BulkInsert is an internal mechanism, that gets used when you
import
>>>> data into a table, using Derby's import mechanism.
>>>> (SYSCS_UTIL.SYSCS_IMPORT_TABLE
>>>> <http://incubator.apache.org/derby/docs/ref/>) This is not
directly
>>>> exposed to applications using JDBC or SQL, so there is no way to
>>>> directly invoke it. If you write some test cases for your feature
>>>> using this procedure, you are testing bulkInsert code. Are you
>>>> familiar with importing/exporting tables? Looking at Derby
manuals >>>> for
>>>> information would be very useful.
>>>
>>> I think you could add a test to tools/ieptests.sql
>>> which tests loading a table with an identity column.
>>>
>>> Kathey
>>>
>>>
>>>
>>>
>>>
>>> --
>>> No virus found in this incoming message.
>>> Checked by AVG Anti-Virus.
>>> Version: 7.0.308 / Virus Database: 266.11.6 - Release Date:
2005/05/06
>>>
>>
>>
>> --
>> No virus found in this outgoing message.
>> Checked by AVG Anti-Virus.
>> Version: 7.0.308 / Virus Database: 266.11.7 - Release Date:
2005/05/09
>>
>>
>>
>>
>> --
>> No virus found in this incoming message.
>> Checked by AVG Anti-Virus.
>> Version: 7.0.308 / Virus Database: 266.11.7 - Release Date:
2005/05/09
>>
>>
>
>
>
> --
> No virus found in this outgoing message.
> Checked by AVG Anti-Virus.
> Version: 7.0.308 / Virus Database: 266.11.7 - Release Date:
2005/05/09
>
>
>
>
> --
> No virus found in this incoming message.
> Checked by AVG Anti-Virus.
> Version: 7.0.308 / Virus Database: 266.11.7 - Release Date:
2005/05/09
>
--
No virus found in this outgoing message.
Checked by AVG Anti-Virus.
Version: 7.0.308 / Virus Database: 266.11.7 - Release Date: 2005/05/09
------------------------------------------------------------------------------
No virus found in this incoming message.
Checked by AVG Anti-Virus.
Version: 7.0.308 / Virus Database: 266.11.9 - Release Date: 2005/05/12
Re: "-Dframework=DerbyNetClient"? (Re: BulkInsert ? (Re: DERBY-167 has done but ...))
Posted by TomohitoNakayama <to...@basil.ocn.ne.jp>.
Hello.
In derbynetmats.properties,
http://svn.apache.org/repos/asf/incubator/derby/code/trunk/java/testing/org/apache/derbyTesting/functionTests/suites/derbynetmats.properties
cofiguration was as next ...
framework=DerbyNet
I think this should be ,
framework=DerbyNetClient.
This may be reason....
#And second reason is that I don't know much about common knoledge of test
suite ;P
#I feel that derbyall test suite does not suit for my task....
Thanks.
Best regards.
/*
Tomohito Nakayama
tomonaka@basil.ocn.ne.jp
tomohito@rose.zero.ad.jp
Naka
http://www5.ocn.ne.jp/~tomohito/TopPage.html
*/
----- Original Message -----
From: "Myrna van Lunteren" <m....@gmail.com>
To: "Derby Development" <de...@db.apache.org>
Sent: Wednesday, May 11, 2005 2:04 AM
Subject: Re: "-Dframework=DerbyNetClient"? (Re: BulkInsert ? (Re: DERBY-167
has done but ...))
Hi,
Well, derbyall runs derbynetmats & derbynetclientmats. With
derbynetmats, the intent of the suite is to test derbynet, i.e.
networkserver via IBMs Universal JDBC driver ('db2jcc*.jar'). With
derbynetclientmats, the intent of the suite is to test the (new)
derbyclient - and thus, in that subsuite, -Dframework=DerbyNetClient.
So, it's not the default, the default framework is none - which means,
using the embedded driver & not networkserver at all. The property
gets set by the harness because it's in the derbynetmats.properties
file.
RunSuite derbyall should not be run with any framework properties
passed in...the individual suites will add the framework properties as
needed.
As to why you got a hang...??? If you have the db2jcc*.jar in your
classpath, it should just run, if you don't it should just skip that
test. I've not seen that test hang recently...You should check what
the last thing is the test did - this you would see in the .tmp file.
Also, do other derbynetmats tests pass? Also, the derbynet.out and
derbynet.err (drill down into the derbynetmats dir untill you find
them) will have more info.
Myrna
On 5/10/05, TomohitoNakayama <to...@basil.ocn.ne.jp> wrote:
> Follows ....
>
> > Well .. I'm not sure default command option "-Dframework=DerbyNet"
> > generated by RunSuite ....
>
> This means that I wonder why default of the option is this value...
>
> Best regards.
>
> /*
>
> Tomohito Nakayama
> tomonaka@basil.ocn.ne.jp
> tomohito@rose.zero.ad.jp
>
> Naka
> http://www5.ocn.ne.jp/~tomohito/TopPage.html
>
> */
> ----- Original Message -----
> From: "TomohitoNakayama" <to...@basil.ocn.ne.jp>
> To: "Derby Development" <de...@db.apache.org>
> Sent: Tuesday, May 10, 2005 10:45 PM
> Subject: "-Dframework=DerbyNetClient"? (Re: BulkInsert ? (Re: DERBY-167
> has
> done but ...))
>
> > Hello.
> >
> > I have tried alljava test suite , but failed in executing
> > DerbyNetAutoStart.
> > Many hours but the test does not finised.
> >
> > Executing command generated by RunSuite for that test was as next:
> > Execute command:
> > java -DjavaCmd=java -Dframework=DerbyNet -Dtimeout=60 -Djdk12te
> > st=true -Doutputdir=C:\ProgramDev\derbyUser\derbyall.20050510\derbyall\derbynetm
> > ats\DerbyNet\derbynetmats -Dtopsuitedir=C:\ProgramDev\derbyUser\derbyall.2005051
> > 0\derbyall\derbynetmats\DerbyNet -Dtopreportdir=C:\ProgramDev\derbyUser\derbyall
> > .20050510\derbyall\derbynetmats -Drundir=C:\ProgramDev\derbyUser\derbyall.200505
> > 10 -DtestSpecialProps=derby.debug.true=enableBtreeConsistencyCheck^derby.stream.
> > error.logSeverityLevel=0^excludeJCC=at-or-after:3.0,when-at-or-before:jdk1.3.1^r
> > unwithj9=false -Dsuitename=derbynetmats:derbynetmats -Dtopsuitename=derbyall
> > org
> > .apache.derbyTesting.functionTests.harness.RunTest
> > derbynet/DerbyNetAutoStart.ja
> > va
> >
> > Seeing next url , I found option of "-Dframework=DerbyNetClient" is
> > needed
> > for RunTest.
> > http://svn.apache.org/repos/asf/incubator/derby/code/trunk/java/testing/README.htm
> >
> > Adding above option to RunSuite also.
> > After that test seems to be done.
> >
> > Well .. I'm not sure default command option "-Dframework=DerbyNet"
> > generated by RunSuite ....
> >
> > Best regards.
> >
> > /*
> >
> > Tomohito Nakayama
> > tomonaka@basil.ocn.ne.jp
> > tomohito@rose.zero.ad.jp
> >
> > Naka
> > http://www5.ocn.ne.jp/~tomohito/TopPage.html
> >
> > */
> > ----- Original Message -----
> > From: "TomohitoNakayama" <to...@basil.ocn.ne.jp>
> > To: "Derby Development" <de...@db.apache.org>
> > Sent: Tuesday, May 10, 2005 8:37 PM
> > Subject: Re: BulkInsert ? (Re: DERBY-167 has done but ...)
> >
> >
> >> Hello.
> >>
> >> I see.
> >> I understood bulk insert.
> >> Thank you.
> >> Now, I have just tryed derbyall-test problem and there seems to be
> >> trouble in derbynet/DerbyNetAutoStart..
> >>
> >> I will report it in detail later.
> >>
> >> Best regards.
> >> /*
> >>
> >> Tomohito Nakayama
> >> tomonaka@basil.ocn.ne.jp
> >> tomohito@rose.zero.ad.jp
> >>
> >> Naka
> >> http://www5.ocn.ne.jp/~tomohito/TopPage.html
> >>
> >> */
> >> ----- Original Message -----
> >> From: "Kathey Marsden" <km...@sbcglobal.net>
> >> To: "Derby Development" <de...@db.apache.org>
> >> Sent: Tuesday, May 10, 2005 5:02 AM
> >> Subject: Re: BulkInsert ? (Re: DERBY-167 has done but ...)
> >>
> >>
> >>> Satheesh Bandaram wrote:
> >>>
> >>>> BulkInsert is an internal mechanism, that gets used when you import
> >>>> data into a table, using Derby's import mechanism.
> >>>> (SYSCS_UTIL.SYSCS_IMPORT_TABLE
> >>>> <http://incubator.apache.org/derby/docs/ref/>) This is not directly
> >>>> exposed to applications using JDBC or SQL, so there is no way to
> >>>> directly invoke it. If you write some test cases for your feature
> >>>> using this procedure, you are testing bulkInsert code. Are you
> >>>> familiar with importing/exporting tables? Looking at Derby manuals
> >>>> for
> >>>> information would be very useful.
> >>>
> >>> I think you could add a test to tools/ieptests.sql
> >>> which tests loading a table with an identity column.
> >>>
> >>> Kathey
> >>>
> >>>
> >>>
> >>>
> >>>
> >>> --
> >>> No virus found in this incoming message.
> >>> Checked by AVG Anti-Virus.
> >>> Version: 7.0.308 / Virus Database: 266.11.6 - Release Date: 2005/05/06
> >>>
> >>
> >>
> >> --
> >> No virus found in this outgoing message.
> >> Checked by AVG Anti-Virus.
> >> Version: 7.0.308 / Virus Database: 266.11.7 - Release Date: 2005/05/09
> >>
> >>
> >>
> >>
> >> --
> >> No virus found in this incoming message.
> >> Checked by AVG Anti-Virus.
> >> Version: 7.0.308 / Virus Database: 266.11.7 - Release Date: 2005/05/09
> >>
> >>
> >
> >
> >
> > --
> > No virus found in this outgoing message.
> > Checked by AVG Anti-Virus.
> > Version: 7.0.308 / Virus Database: 266.11.7 - Release Date: 2005/05/09
> >
> >
> >
> >
> > --
> > No virus found in this incoming message.
> > Checked by AVG Anti-Virus.
> > Version: 7.0.308 / Virus Database: 266.11.7 - Release Date: 2005/05/09
> >
>
> --
> No virus found in this outgoing message.
> Checked by AVG Anti-Virus.
> Version: 7.0.308 / Virus Database: 266.11.7 - Release Date: 2005/05/09
>
>
--
No virus found in this incoming message.
Checked by AVG Anti-Virus.
Version: 7.0.308 / Virus Database: 266.11.7 - Release Date: 2005/05/09
--
No virus found in this outgoing message.
Checked by AVG Anti-Virus.
Version: 7.0.308 / Virus Database: 266.11.8 - Release Date: 2005/05/10
Re: "-Dframework=DerbyNetClient"? (Re: BulkInsert ? (Re: DERBY-167 has done but ...))
Posted by Myrna van Lunteren <m....@gmail.com>.
Hi,
Well, derbyall runs derbynetmats & derbynetclientmats. With
derbynetmats, the intent of the suite is to test derbynet, i.e.
networkserver via IBMs Universal JDBC driver ('db2jcc*.jar'). With
derbynetclientmats, the intent of the suite is to test the (new)
derbyclient - and thus, in that subsuite, -Dframework=DerbyNetClient.
So, it's not the default, the default framework is none - which means,
using the embedded driver & not networkserver at all. The property
gets set by the harness because it's in the derbynetmats.properties
file.
RunSuite derbyall should not be run with any framework properties
passed in...the individual suites will add the framework properties as
needed.
As to why you got a hang...??? If you have the db2jcc*.jar in your
classpath, it should just run, if you don't it should just skip that
test. I've not seen that test hang recently...You should check what
the last thing is the test did - this you would see in the .tmp file.
Also, do other derbynetmats tests pass? Also, the derbynet.out and
derbynet.err (drill down into the derbynetmats dir untill you find
them) will have more info.
Myrna
On 5/10/05, TomohitoNakayama <to...@basil.ocn.ne.jp> wrote:
> Follows ....
>
> > Well .. I'm not sure default command option "-Dframework=DerbyNet"
> > generated by RunSuite ....
>
> This means that I wonder why default of the option is this value...
>
> Best regards.
>
> /*
>
> Tomohito Nakayama
> tomonaka@basil.ocn.ne.jp
> tomohito@rose.zero.ad.jp
>
> Naka
> http://www5.ocn.ne.jp/~tomohito/TopPage.html
>
> */
> ----- Original Message -----
> From: "TomohitoNakayama" <to...@basil.ocn.ne.jp>
> To: "Derby Development" <de...@db.apache.org>
> Sent: Tuesday, May 10, 2005 10:45 PM
> Subject: "-Dframework=DerbyNetClient"? (Re: BulkInsert ? (Re: DERBY-167 has
> done but ...))
>
> > Hello.
> >
> > I have tried alljava test suite , but failed in executing
> > DerbyNetAutoStart.
> > Many hours but the test does not finised.
> >
> > Executing command generated by RunSuite for that test was as next:
> > Execute command:
> > java -DjavaCmd=java -Dframework=DerbyNet -Dtimeout=60 -Djdk12te
> > st=true -Doutputdir=C:\ProgramDev\derbyUser\derbyall.20050510\derbyall\derbynetm
> > ats\DerbyNet\derbynetmats -Dtopsuitedir=C:\ProgramDev\derbyUser\derbyall.2005051
> > 0\derbyall\derbynetmats\DerbyNet -Dtopreportdir=C:\ProgramDev\derbyUser\derbyall
> > .20050510\derbyall\derbynetmats -Drundir=C:\ProgramDev\derbyUser\derbyall.200505
> > 10 -DtestSpecialProps=derby.debug.true=enableBtreeConsistencyCheck^derby.stream.
> > error.logSeverityLevel=0^excludeJCC=at-or-after:3.0,when-at-or-before:jdk1.3.1^r
> > unwithj9=false -Dsuitename=derbynetmats:derbynetmats -Dtopsuitename=derbyall
> > org
> > .apache.derbyTesting.functionTests.harness.RunTest
> > derbynet/DerbyNetAutoStart.ja
> > va
> >
> > Seeing next url , I found option of "-Dframework=DerbyNetClient" is needed
> > for RunTest.
> > http://svn.apache.org/repos/asf/incubator/derby/code/trunk/java/testing/README.htm
> >
> > Adding above option to RunSuite also.
> > After that test seems to be done.
> >
> > Well .. I'm not sure default command option "-Dframework=DerbyNet"
> > generated by RunSuite ....
> >
> > Best regards.
> >
> > /*
> >
> > Tomohito Nakayama
> > tomonaka@basil.ocn.ne.jp
> > tomohito@rose.zero.ad.jp
> >
> > Naka
> > http://www5.ocn.ne.jp/~tomohito/TopPage.html
> >
> > */
> > ----- Original Message -----
> > From: "TomohitoNakayama" <to...@basil.ocn.ne.jp>
> > To: "Derby Development" <de...@db.apache.org>
> > Sent: Tuesday, May 10, 2005 8:37 PM
> > Subject: Re: BulkInsert ? (Re: DERBY-167 has done but ...)
> >
> >
> >> Hello.
> >>
> >> I see.
> >> I understood bulk insert.
> >> Thank you.
> >> Now, I have just tryed derbyall-test problem and there seems to be
> >> trouble in derbynet/DerbyNetAutoStart..
> >>
> >> I will report it in detail later.
> >>
> >> Best regards.
> >> /*
> >>
> >> Tomohito Nakayama
> >> tomonaka@basil.ocn.ne.jp
> >> tomohito@rose.zero.ad.jp
> >>
> >> Naka
> >> http://www5.ocn.ne.jp/~tomohito/TopPage.html
> >>
> >> */
> >> ----- Original Message -----
> >> From: "Kathey Marsden" <km...@sbcglobal.net>
> >> To: "Derby Development" <de...@db.apache.org>
> >> Sent: Tuesday, May 10, 2005 5:02 AM
> >> Subject: Re: BulkInsert ? (Re: DERBY-167 has done but ...)
> >>
> >>
> >>> Satheesh Bandaram wrote:
> >>>
> >>>> BulkInsert is an internal mechanism, that gets used when you import
> >>>> data into a table, using Derby's import mechanism.
> >>>> (SYSCS_UTIL.SYSCS_IMPORT_TABLE
> >>>> <http://incubator.apache.org/derby/docs/ref/>) This is not directly
> >>>> exposed to applications using JDBC or SQL, so there is no way to
> >>>> directly invoke it. If you write some test cases for your feature
> >>>> using this procedure, you are testing bulkInsert code. Are you
> >>>> familiar with importing/exporting tables? Looking at Derby manuals for
> >>>> information would be very useful.
> >>>
> >>> I think you could add a test to tools/ieptests.sql
> >>> which tests loading a table with an identity column.
> >>>
> >>> Kathey
> >>>
> >>>
> >>>
> >>>
> >>>
> >>> --
> >>> No virus found in this incoming message.
> >>> Checked by AVG Anti-Virus.
> >>> Version: 7.0.308 / Virus Database: 266.11.6 - Release Date: 2005/05/06
> >>>
> >>
> >>
> >> --
> >> No virus found in this outgoing message.
> >> Checked by AVG Anti-Virus.
> >> Version: 7.0.308 / Virus Database: 266.11.7 - Release Date: 2005/05/09
> >>
> >>
> >>
> >>
> >> --
> >> No virus found in this incoming message.
> >> Checked by AVG Anti-Virus.
> >> Version: 7.0.308 / Virus Database: 266.11.7 - Release Date: 2005/05/09
> >>
> >>
> >
> >
> >
> > --
> > No virus found in this outgoing message.
> > Checked by AVG Anti-Virus.
> > Version: 7.0.308 / Virus Database: 266.11.7 - Release Date: 2005/05/09
> >
> >
> >
> >
> > --
> > No virus found in this incoming message.
> > Checked by AVG Anti-Virus.
> > Version: 7.0.308 / Virus Database: 266.11.7 - Release Date: 2005/05/09
> >
>
> --
> No virus found in this outgoing message.
> Checked by AVG Anti-Virus.
> Version: 7.0.308 / Virus Database: 266.11.7 - Release Date: 2005/05/09
>
>
Re: "-Dframework=DerbyNetClient"? (Re: BulkInsert ? (Re: DERBY-167 has done but ...))
Posted by TomohitoNakayama <to...@basil.ocn.ne.jp>.
Follows ....
> Well .. I'm not sure default command option "-Dframework=DerbyNet"
> generated by RunSuite ....
This means that I wonder why default of the option is this value...
Best regards.
/*
Tomohito Nakayama
tomonaka@basil.ocn.ne.jp
tomohito@rose.zero.ad.jp
Naka
http://www5.ocn.ne.jp/~tomohito/TopPage.html
*/
----- Original Message -----
From: "TomohitoNakayama" <to...@basil.ocn.ne.jp>
To: "Derby Development" <de...@db.apache.org>
Sent: Tuesday, May 10, 2005 10:45 PM
Subject: "-Dframework=DerbyNetClient"? (Re: BulkInsert ? (Re: DERBY-167 has
done but ...))
> Hello.
>
> I have tried alljava test suite , but failed in executing
> DerbyNetAutoStart.
> Many hours but the test does not finised.
>
> Executing command generated by RunSuite for that test was as next:
> Execute command:
> java -DjavaCmd=java -Dframework=DerbyNet -Dtimeout=60 -Djdk12te
> st=true -Doutputdir=C:\ProgramDev\derbyUser\derbyall.20050510\derbyall\derbynetm
> ats\DerbyNet\derbynetmats -Dtopsuitedir=C:\ProgramDev\derbyUser\derbyall.2005051
> 0\derbyall\derbynetmats\DerbyNet -Dtopreportdir=C:\ProgramDev\derbyUser\derbyall
> .20050510\derbyall\derbynetmats -Drundir=C:\ProgramDev\derbyUser\derbyall.200505
> 10 -DtestSpecialProps=derby.debug.true=enableBtreeConsistencyCheck^derby.stream.
> error.logSeverityLevel=0^excludeJCC=at-or-after:3.0,when-at-or-before:jdk1.3.1^r
> unwithj9=false -Dsuitename=derbynetmats:derbynetmats -Dtopsuitename=derbyall
> org
> .apache.derbyTesting.functionTests.harness.RunTest
> derbynet/DerbyNetAutoStart.ja
> va
>
> Seeing next url , I found option of "-Dframework=DerbyNetClient" is needed
> for RunTest.
> http://svn.apache.org/repos/asf/incubator/derby/code/trunk/java/testing/README.htm
>
> Adding above option to RunSuite also.
> After that test seems to be done.
>
> Well .. I'm not sure default command option "-Dframework=DerbyNet"
> generated by RunSuite ....
>
> Best regards.
>
> /*
>
> Tomohito Nakayama
> tomonaka@basil.ocn.ne.jp
> tomohito@rose.zero.ad.jp
>
> Naka
> http://www5.ocn.ne.jp/~tomohito/TopPage.html
>
> */
> ----- Original Message -----
> From: "TomohitoNakayama" <to...@basil.ocn.ne.jp>
> To: "Derby Development" <de...@db.apache.org>
> Sent: Tuesday, May 10, 2005 8:37 PM
> Subject: Re: BulkInsert ? (Re: DERBY-167 has done but ...)
>
>
>> Hello.
>>
>> I see.
>> I understood bulk insert.
>> Thank you.
>> Now, I have just tryed derbyall-test problem and there seems to be
>> trouble in derbynet/DerbyNetAutoStart..
>>
>> I will report it in detail later.
>>
>> Best regards.
>> /*
>>
>> Tomohito Nakayama
>> tomonaka@basil.ocn.ne.jp
>> tomohito@rose.zero.ad.jp
>>
>> Naka
>> http://www5.ocn.ne.jp/~tomohito/TopPage.html
>>
>> */
>> ----- Original Message -----
>> From: "Kathey Marsden" <km...@sbcglobal.net>
>> To: "Derby Development" <de...@db.apache.org>
>> Sent: Tuesday, May 10, 2005 5:02 AM
>> Subject: Re: BulkInsert ? (Re: DERBY-167 has done but ...)
>>
>>
>>> Satheesh Bandaram wrote:
>>>
>>>> BulkInsert is an internal mechanism, that gets used when you import
>>>> data into a table, using Derby's import mechanism.
>>>> (SYSCS_UTIL.SYSCS_IMPORT_TABLE
>>>> <http://incubator.apache.org/derby/docs/ref/>) This is not directly
>>>> exposed to applications using JDBC or SQL, so there is no way to
>>>> directly invoke it. If you write some test cases for your feature
>>>> using this procedure, you are testing bulkInsert code. Are you
>>>> familiar with importing/exporting tables? Looking at Derby manuals for
>>>> information would be very useful.
>>>
>>> I think you could add a test to tools/ieptests.sql
>>> which tests loading a table with an identity column.
>>>
>>> Kathey
>>>
>>>
>>>
>>>
>>>
>>> --
>>> No virus found in this incoming message.
>>> Checked by AVG Anti-Virus.
>>> Version: 7.0.308 / Virus Database: 266.11.6 - Release Date: 2005/05/06
>>>
>>
>>
>> --
>> No virus found in this outgoing message.
>> Checked by AVG Anti-Virus.
>> Version: 7.0.308 / Virus Database: 266.11.7 - Release Date: 2005/05/09
>>
>>
>>
>>
>> --
>> No virus found in this incoming message.
>> Checked by AVG Anti-Virus.
>> Version: 7.0.308 / Virus Database: 266.11.7 - Release Date: 2005/05/09
>>
>>
>
>
>
> --
> No virus found in this outgoing message.
> Checked by AVG Anti-Virus.
> Version: 7.0.308 / Virus Database: 266.11.7 - Release Date: 2005/05/09
>
>
>
>
> --
> No virus found in this incoming message.
> Checked by AVG Anti-Virus.
> Version: 7.0.308 / Virus Database: 266.11.7 - Release Date: 2005/05/09
>
--
No virus found in this outgoing message.
Checked by AVG Anti-Virus.
Version: 7.0.308 / Virus Database: 266.11.7 - Release Date: 2005/05/09
"-Dframework=DerbyNetClient"? (Re: BulkInsert ? (Re: DERBY-167 has done but ...))
Posted by TomohitoNakayama <to...@basil.ocn.ne.jp>.
Hello.
I have tried alljava test suite , but failed in executing DerbyNetAutoStart.
Many hours but the test does not finised.
Executing command generated by RunSuite for that test was as next:
Execute command:
java -DjavaCmd=java -Dframework=DerbyNet -Dtimeout=60 -Djdk12te
st=true -Doutputdir=C:\ProgramDev\derbyUser\derbyall.20050510\derbyall\derbynetm
ats\DerbyNet\derbynetmats -Dtopsuitedir=C:\ProgramDev\derbyUser\derbyall.2005051
0\derbyall\derbynetmats\DerbyNet -Dtopreportdir=C:\ProgramDev\derbyUser\derbyall
.20050510\derbyall\derbynetmats -Drundir=C:\ProgramDev\derbyUser\derbyall.200505
10 -DtestSpecialProps=derby.debug.true=enableBtreeConsistencyCheck^derby.stream.
error.logSeverityLevel=0^excludeJCC=at-or-after:3.0,when-at-or-before:jdk1.3.1^r
unwithj9=false -Dsuitename=derbynetmats:derbynetmats -Dtopsuitename=derbyall
org
.apache.derbyTesting.functionTests.harness.RunTest
derbynet/DerbyNetAutoStart.ja
va
Seeing next url , I found option of "-Dframework=DerbyNetClient" is needed
for RunTest.
http://svn.apache.org/repos/asf/incubator/derby/code/trunk/java/testing/README.htm
Adding above option to RunSuite also.
After that test seems to be done.
Well .. I'm not sure default command option "-Dframework=DerbyNet" generated
by RunSuite ....
Best regards.
/*
Tomohito Nakayama
tomonaka@basil.ocn.ne.jp
tomohito@rose.zero.ad.jp
Naka
http://www5.ocn.ne.jp/~tomohito/TopPage.html
*/
----- Original Message -----
From: "TomohitoNakayama" <to...@basil.ocn.ne.jp>
To: "Derby Development" <de...@db.apache.org>
Sent: Tuesday, May 10, 2005 8:37 PM
Subject: Re: BulkInsert ? (Re: DERBY-167 has done but ...)
> Hello.
>
> I see.
> I understood bulk insert.
> Thank you.
> Now, I have just tryed derbyall-test problem and there seems to be trouble
> in derbynet/DerbyNetAutoStart..
>
> I will report it in detail later.
>
> Best regards.
> /*
>
> Tomohito Nakayama
> tomonaka@basil.ocn.ne.jp
> tomohito@rose.zero.ad.jp
>
> Naka
> http://www5.ocn.ne.jp/~tomohito/TopPage.html
>
> */
> ----- Original Message -----
> From: "Kathey Marsden" <km...@sbcglobal.net>
> To: "Derby Development" <de...@db.apache.org>
> Sent: Tuesday, May 10, 2005 5:02 AM
> Subject: Re: BulkInsert ? (Re: DERBY-167 has done but ...)
>
>
>> Satheesh Bandaram wrote:
>>
>>> BulkInsert is an internal mechanism, that gets used when you import
>>> data into a table, using Derby's import mechanism.
>>> (SYSCS_UTIL.SYSCS_IMPORT_TABLE
>>> <http://incubator.apache.org/derby/docs/ref/>) This is not directly
>>> exposed to applications using JDBC or SQL, so there is no way to
>>> directly invoke it. If you write some test cases for your feature
>>> using this procedure, you are testing bulkInsert code. Are you
>>> familiar with importing/exporting tables? Looking at Derby manuals for
>>> information would be very useful.
>>
>> I think you could add a test to tools/ieptests.sql
>> which tests loading a table with an identity column.
>>
>> Kathey
>>
>>
>>
>>
>>
>> --
>> No virus found in this incoming message.
>> Checked by AVG Anti-Virus.
>> Version: 7.0.308 / Virus Database: 266.11.6 - Release Date: 2005/05/06
>>
>
>
> --
> No virus found in this outgoing message.
> Checked by AVG Anti-Virus.
> Version: 7.0.308 / Virus Database: 266.11.7 - Release Date: 2005/05/09
>
>
>
>
> --
> No virus found in this incoming message.
> Checked by AVG Anti-Virus.
> Version: 7.0.308 / Virus Database: 266.11.7 - Release Date: 2005/05/09
>
>
--
No virus found in this outgoing message.
Checked by AVG Anti-Virus.
Version: 7.0.308 / Virus Database: 266.11.7 - Release Date: 2005/05/09
Re: BulkInsert ? (Re: DERBY-167 has done but ...)
Posted by TomohitoNakayama <to...@basil.ocn.ne.jp>.
Hello.
I see.
I understood bulk insert.
Thank you.
Now, I have just tryed derbyall-test problem and
there seems to be trouble in derbynet/DerbyNetAutoStart..
I will report it in detail later.
Best regards.
/*
Tomohito Nakayama
tomonaka@basil.ocn.ne.jp
tomohito@rose.zero.ad.jp
Naka
http://www5.ocn.ne.jp/~tomohito/TopPage.html
*/
----- Original Message -----
From: "Kathey Marsden" <km...@sbcglobal.net>
To: "Derby Development" <de...@db.apache.org>
Sent: Tuesday, May 10, 2005 5:02 AM
Subject: Re: BulkInsert ? (Re: DERBY-167 has done but ...)
> Satheesh Bandaram wrote:
>
>> BulkInsert is an internal mechanism, that gets used when you import
>> data into a table, using Derby's import mechanism.
>> (SYSCS_UTIL.SYSCS_IMPORT_TABLE
>> <http://incubator.apache.org/derby/docs/ref/>) This is not directly
>> exposed to applications using JDBC or SQL, so there is no way to
>> directly invoke it. If you write some test cases for your feature
>> using this procedure, you are testing bulkInsert code. Are you
>> familiar with importing/exporting tables? Looking at Derby manuals for
>> information would be very useful.
>
> I think you could add a test to tools/ieptests.sql
> which tests loading a table with an identity column.
>
> Kathey
>
>
>
>
>
> --
> No virus found in this incoming message.
> Checked by AVG Anti-Virus.
> Version: 7.0.308 / Virus Database: 266.11.6 - Release Date: 2005/05/06
>
>
--
No virus found in this outgoing message.
Checked by AVG Anti-Virus.
Version: 7.0.308 / Virus Database: 266.11.7 - Release Date: 2005/05/09
Re: BulkInsert ? (Re: DERBY-167 has done but ...)
Posted by Kathey Marsden <km...@sbcglobal.net>.
Satheesh Bandaram wrote:
> BulkInsert is an internal mechanism, that gets used when you import
> data into a table, using Derby's import mechanism.
> (SYSCS_UTIL.SYSCS_IMPORT_TABLE
> <http://incubator.apache.org/derby/docs/ref/>) This is not directly
> exposed to applications using JDBC or SQL, so there is no way to
> directly invoke it. If you write some test cases for your feature
> using this procedure, you are testing bulkInsert code. Are you
> familiar with importing/exporting tables? Looking at Derby manuals for
> information would be very useful.
I think you could add a test to tools/ieptests.sql
which tests loading a table with an identity column.
Kathey
BulkInsert ? (Re: DERBY-167 has done but ...)
Posted by TomohitoNakayama <to...@basil.ocn.ne.jp>.
Hello.
Satheesh Bandaram wrote:
>Import code actually uses bulkInsert option, so it would be good to test
>this code path too. I can help, if needed, on these tests. Before commiting
>the patch, it would be good to add more tests
Can I execute bulkInsert using next method ?
http://java.sun.com/j2se/1.4.2/docs/api/java/sql/Statement.html#executeBatch()
Best regards.
/*
Tomohito Nakayama
tomonaka@basil.ocn.ne.jp
tomohito@rose.zero.ad.jp
Naka
http://www5.ocn.ne.jp/~tomohito/TopPage.html
*/
----- Original Message -----
From: "TomohitoNakayama" <to...@basil.ocn.ne.jp>
To: "Derby Development" <de...@db.apache.org>
Sent: Saturday, May 07, 2005 1:44 AM
Subject: Re: DERBY-167 has done but ...
> Hello.
>
>>created with the new identity option. Import code actually uses bulkInsert
>>option, so it would be good to test this code path too. I can help, if
>> >needed, on these tests. Before commiting the patch, it would be good to
>>add more tests in general.
>
> I don't know much about bulkInsert option.
> Can you tell me entry point for the information about that ?
>
> Best regards.
>
>
> /*
>
> Tomohito Nakayama
> tomonaka@basil.ocn.ne.jp
> tomohito@rose.zero.ad.jp
>
> Naka
> http://www5.ocn.ne.jp/~tomohito/TopPage.html
>
> */
> ----- Original Message -----
> From: Satheesh Bandaram
> To: Derby Development
> Sent: Friday, May 06, 2005 2:04 AM
> Subject: Re: DERBY-167 has done but ...
>
>
> Great job getting this done. This is indeed a very useful Enhancement to
> Derby.
>
> Looking briefly at the attached patch, some comments:
>
> I think syntax for GENERATED BY DEFAULT needs to include the BY, according
> to SQL standard.
> One of the main uses of this new clause is for importing data into
> IDENTITY columns. I would like to see some tests that import data into
> tables created with the new identity option. Import code actually uses
> bulkInsert option, so it would be good to test this code path too. I can
> help, if needed, on these tests. Before commiting the patch, it would be
> good to add more tests in general.
> I couldn't fully apply the patch. Had issues with two files,
> ResultColumnList and ColumnDescriptor. I think these files might have been
> updated since you started working on the patch. It would be good if you
> can merge up to the latest version.
>
> Again, great to see the patch.
>
> Satheesh
>
> TomohitoNakayama wrote:
> Hello.
>
> I think coding for solution-1 of DERBY-167 has done.
> I attach patch file to this mail for others to confirm it.
>
> Relating test , autoincrement and columnDefaults , was passed.
>
>
> However, In derbyall test , I found many errors which seems not caused by
> my modification.
> Errors seems to be devided three kind ...
> 1:Error of parameterMapping. I don't know what is parameter Mapping mean,
> but file names told so.
> 2:Error of i18n. It seems that English message was generated though test
> assume Spanish.
> 3:Error of derbynetclientmats.
>
> I uploaded $TEST_DIR/derbyall_fail.txt and $TEST_DIR/derbyall_diff.txt to
> my web directory,
> because size was too large.
> http://www5.ocn.ne.jp/~tomohito/20050505/derbyall_fail.txt
> http://www5.ocn.ne.jp/~tomohito/20050505/derbyall_diff.txt
>
> Something is going on ...?
>
>
> Best regards.
>
>
> /*
>
> Tomohito Nakayama
> tomonaka@basil.ocn.ne.jp
> tomohito@rose.zero.ad.jp
>
> Naka
> http://www5.ocn.ne.jp/~tomohito/TopPage.html
>
> */
>
> No virus found in this outgoing message.
> Checked by AVG Anti-Virus.
> Version: 7.0.308 / Virus Database: 266.11.5 - Release Date: 2005/05/04
>
>
>
>
> No virus found in this incoming message.
> Checked by AVG Anti-Virus.
> Version: 7.0.308 / Virus Database: 266.11.5 - Release Date: 2005/05/04
>
>
> --
> No virus found in this outgoing message.
> Checked by AVG Anti-Virus.
> Version: 7.0.308 / Virus Database: 266.11.5 - Release Date: 2005/05/04
>
>
>
>
> --
> No virus found in this incoming message.
> Checked by AVG Anti-Virus.
> Version: 7.0.308 / Virus Database: 266.11.5 - Release Date: 2005/05/04
>
--
No virus found in this outgoing message.
Checked by AVG Anti-Virus.
Version: 7.0.308 / Virus Database: 266.11.6 - Release Date: 2005/05/06
Re: DERBY-167 has done but ...
Posted by TomohitoNakayama <to...@basil.ocn.ne.jp>.
Hello.
>created with the new identity option. Import code actually uses bulkInsert
>option, so it would be good to test this code path too. I can help, if
> >needed, on these tests. Before commiting the patch, it would be good to
>add more tests in general.
I don't know much about bulkInsert option.
Can you tell me entry point for the information about that ?
Best regards.
/*
Tomohito Nakayama
tomonaka@basil.ocn.ne.jp
tomohito@rose.zero.ad.jp
Naka
http://www5.ocn.ne.jp/~tomohito/TopPage.html
*/
----- Original Message -----
From: Satheesh Bandaram
To: Derby Development
Sent: Friday, May 06, 2005 2:04 AM
Subject: Re: DERBY-167 has done but ...
Great job getting this done. This is indeed a very useful Enhancement to
Derby.
Looking briefly at the attached patch, some comments:
I think syntax for GENERATED BY DEFAULT needs to include the BY, according
to SQL standard.
One of the main uses of this new clause is for importing data into IDENTITY
columns. I would like to see some tests that import data into tables created
with the new identity option. Import code actually uses bulkInsert option,
so it would be good to test this code path too. I can help, if needed, on
these tests. Before commiting the patch, it would be good to add more tests
in general.
I couldn't fully apply the patch. Had issues with two files,
ResultColumnList and ColumnDescriptor. I think these files might have been
updated since you started working on the patch. It would be good if you can
merge up to the latest version.
Again, great to see the patch.
Satheesh
TomohitoNakayama wrote:
Hello.
I think coding for solution-1 of DERBY-167 has done.
I attach patch file to this mail for others to confirm it.
Relating test , autoincrement and columnDefaults , was passed.
However, In derbyall test , I found many errors which seems not caused by my
modification.
Errors seems to be devided three kind ...
1:Error of parameterMapping. I don't know what is parameter Mapping mean,
but file names told so.
2:Error of i18n. It seems that English message was generated though test
assume Spanish.
3:Error of derbynetclientmats.
I uploaded $TEST_DIR/derbyall_fail.txt and $TEST_DIR/derbyall_diff.txt to my
web directory,
because size was too large.
http://www5.ocn.ne.jp/~tomohito/20050505/derbyall_fail.txt
http://www5.ocn.ne.jp/~tomohito/20050505/derbyall_diff.txt
Something is going on ...?
Best regards.
/*
Tomohito Nakayama
tomonaka@basil.ocn.ne.jp
tomohito@rose.zero.ad.jp
Naka
http://www5.ocn.ne.jp/~tomohito/TopPage.html
*/
No virus found in this outgoing message.
Checked by AVG Anti-Virus.
Version: 7.0.308 / Virus Database: 266.11.5 - Release Date: 2005/05/04
No virus found in this incoming message.
Checked by AVG Anti-Virus.
Version: 7.0.308 / Virus Database: 266.11.5 - Release Date: 2005/05/04
--
No virus found in this outgoing message.
Checked by AVG Anti-Virus.
Version: 7.0.308 / Virus Database: 266.11.5 - Release Date: 2005/05/04