You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "dongjoon-hyun (via GitHub)" <gi...@apache.org> on 2026/05/26 18:40:47 UTC
[PR] [SPARK-57084] Add `geometry` and `geography` SQL tests and answer files [spark-connect-swift]
dongjoon-hyun opened a new pull request, #392:
URL: https://github.com/apache/spark-connect-swift/pull/392
### What changes were proposed in this pull request?
This PR aims to add `geometry.sql` and `geography.sql` test queries for the new `GEOMETRY` and `GEOGRAPHY` geospatial types introduced in Apache Spark 4.2.
### Why are the changes needed?
Apache Spark 4.2 introduces new geospatial types (`GEOMETRY` and `GEOGRAPHY`). We need test coverage for these types in the Swift client.
- https://spark.apache.org/docs/4.2.0-preview5/sql-ref-geospatial-types.html
### Does this PR introduce _any_ user-facing change?
No.
### How was this patch tested?
Pass the CIs with the newly added test queries. The `spark.sql.geospatial.enabled=true` configuration is enabled in the Spark 4.2 integration test jobs.
### Was this patch authored or co-authored using generative AI tooling?
Generated-by: Claude Opus 4.7
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-57084] Add `geometry` and `geography` SQL tests and answer files [spark-connect-swift]
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on code in PR #392:
URL: https://github.com/apache/spark-connect-swift/pull/392#discussion_r3306072321
##########
.github/workflows/build_and_test.yml:
##########
@@ -117,6 +117,7 @@ jobs:
docker run -d --name spark -p 15003:15002 -e SPARK_NO_DAEMONIZE=1 \
--entrypoint /opt/spark/sbin/start-connect-server.sh \
apache/spark:4.2.0-preview5-scala \
+ -c spark.sql.geospatial.enabled=true \
Review Comment:
This is required until Apache Spark 4.2.0-preview5 because it's enabled after preview5.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-57084] Add `geometry` and `geography` SQL tests and answer files [spark-connect-swift]
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on code in PR #392:
URL: https://github.com/apache/spark-connect-swift/pull/392#discussion_r3306072321
##########
.github/workflows/build_and_test.yml:
##########
@@ -117,6 +117,7 @@ jobs:
docker run -d --name spark -p 15003:15002 -e SPARK_NO_DAEMONIZE=1 \
--entrypoint /opt/spark/sbin/start-connect-server.sh \
apache/spark:4.2.0-preview5-scala \
+ -c spark.sql.geospatial.enabled=true \
Review Comment:
This is required because it's enabled after Apache Spark 4.2.0-preview5 .
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-57084] Add `geometry` and `geography` SQL tests and answer files [spark-connect-swift]
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun closed pull request #392: [SPARK-57084] Add `geometry` and `geography` SQL tests and answer files
URL: https://github.com/apache/spark-connect-swift/pull/392
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-57084] Add `geometry` and `geography` SQL tests and answer files [spark-connect-swift]
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on PR #392:
URL: https://github.com/apache/spark-connect-swift/pull/392#issuecomment-4547585851
Thank you, @viirya .
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-57084] Add `geometry` and `geography` SQL tests and answer files [spark-connect-swift]
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on PR #392:
URL: https://github.com/apache/spark-connect-swift/pull/392#issuecomment-4547687476
Merged to main
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org