You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hc.apache.org by "Gary Gregory (JIRA)" <ji...@apache.org> on 2019/02/01 13:40:00 UTC
[jira] [Comment Edited] (HTTPCLIENT-1968) Encoded forward slashes
are not preserved when rewriting URI
[ https://issues.apache.org/jira/browse/HTTPCLIENT-1968?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16758301#comment-16758301 ]
Gary Gregory edited comment on HTTPCLIENT-1968 at 2/1/19 1:39 PM:
------------------------------------------------------------------
Hi All.
I am thinking about moving forward here and how to help Here is a possible path forward:
* State a specific use case with a unit test
* Propose a patch _which does not break binary compatibility_
* Ideally these are new APIs like {{setThisKindOfPath}}
* It might be possible to workaround this with documentation. Is it?
Then we can move away from changing the behavior of the current API to adding APIs you can use and discuss if your patch fits in here.
Thoughts?
was (Author: garydgregory):
Hi All.
I am thinking about moving forward here and how to help Here is a possible path forward:
* State a specific use case with a unit test
* Propose a patch _which does not break binary compatibility_
Then we can move away from changing the behavior of the current API to adding APIs you can use and discuss if your patch fits in here.
Thoughts?
> Encoded forward slashes are not preserved when rewriting URI
> ------------------------------------------------------------
>
> Key: HTTPCLIENT-1968
> URL: https://issues.apache.org/jira/browse/HTTPCLIENT-1968
> Project: HttpComponents HttpClient
> Issue Type: Bug
> Affects Versions: 4.5.7
> Reporter: Jay Modi
> Priority: Major
> Attachments: rewrite_preserve_forward_slash.diff
>
>
> URIs that contain an encoded forward slash (%2F) are no longer preserved when the HTTP client executes. I came across this when upgrading from 4.5.2 to 4.5.7 and my requests that contained an encoded forward slash suddenly started failing. The appears to be due to decoding and re-encoding of the path that takes place in the URIUtils#rewriteURI method. I've attached a patch that restores the old behavior but if a URI contains two slashes in a row in addition to an encoded slash the encoded forward slash will be decoded.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org