[GitHub] [ozone] guihecheng commented on a change in pull request #2083: HDDS-4818. Add command to get status of Finalize in OM & SCM

[GitBox <gi...@apache.org>]

guihecheng commented on a change in pull request #2083:
URL: https://github.com/apache/ozone/pull/2083#discussion_r605334524



##########
File path: hadoop-ozone/tools/src/main/java/org/apache/hadoop/ozone/admin/om/FinalizeStatusSubCommand.java
##########
@@ -0,0 +1,64 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with this
+ * work for additional information regarding copyright ownership.  The ASF
+ * licenses this file to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ * <p>
+ * http://www.apache.org/licenses/LICENSE-2.0
+ * <p>
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,WITHOUT
+ * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
+ * License for the specific language governing permissions and limitations under
+ * the License.
+ */
+
+package org.apache.hadoop.ozone.admin.om;
+
+import org.apache.hadoop.hdds.cli.HddsVersionProvider;
+import org.apache.hadoop.ozone.om.protocol.OzoneManagerProtocol;
+import org.apache.hadoop.ozone.upgrade.UpgradeFinalizer;
+import picocli.CommandLine;
+
+import java.util.UUID;
+import java.util.concurrent.Callable;
+
+/**
+ * Handler of ozone admin om finalizestatus command.
+ */
+@CommandLine.Command(
+    name = "finalizestatus",
+    description = "Get the finalize status of om cluster.",
+    mixinStandardHelpOptions = true,
+    versionProvider = HddsVersionProvider.class
+)
+public class FinalizeStatusSubCommand implements Callable<Void> {
+
+  @CommandLine.ParentCommand
+  private OMAdmin parent;
+
+  @CommandLine.Option(
+      names = {"-id", "--service-id"},
+      description = "Ozone Manager Service ID"
+  )
+  private String omServiceId;
+
+  @CommandLine.Option(
+      names = {"-host", "--service-host"},
+      description = "Ozone Manager Host"
+  )
+  private String omHost;
+
+  @Override
+  public Void call() throws Exception {
+    OzoneManagerProtocol client =
+        parent.createOmClient(omServiceId, omHost, false);
+    String upgradeClientID = "Upgrade-Client-" + UUID.randomUUID().toString();
+    UpgradeFinalizer.StatusAndMessages progress =
+        client.queryUpgradeFinalizationProgress(upgradeClientID, true);

Review comment:
       https://github.com/apache/ozone/blob/ed00db7a52bf1acce9a82b21642032b42c0fb223/hadoop-hdds/common/src/main/java/org/apache/hadoop/ozone/upgrade/UpgradeFinalizer.java#L169
   
   As I read through the comments of the interface, I found that the assert on clientId might be optional by design?
   Suppose we could just remove the assertion in `BasicUPgradeFinalizer` and let any client fetch the status of finalization? I'm not sure whether it will cause any problems?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org